# patch for fix build git on Haiku

3 messages from 2013-02-22 to 2013-02-24. Participants: diger, Jonathan Nieder, Andreas Färber.
Thread: https://gitlist.dev/t/32974

## diger, 2013-02-22 15:13

Subject: patch for fix build git on Haiku
Message-ID: <254e4f8fb172cec1e547413e2828b642@freenet59.ru>
URL: https://gitlist.dev/e/254e4f8fb172cec1e547413e2828b642%40freenet59.ru

```
This patch fixes build git on Haiku


----------------
$NetBSD$

--- Makefile.orig	2012-10-21 21:32:15.000000000 +0000
+++ Makefile
@@ -1211,6 +1204,16 @@ ifeq ($(uname_S),HP-UX)
 	endif
 	GIT_TEST_CMP = cmp
 endif
+ifeq ($(uname_S),Haiku)
+    NO_R_TO_GCC_LINKER = YesPlease
+    NO_LIBGEN_H = YesPlease
+    NO_MEMMEM = YesPlease
+    NO_MKSTEMPS = YesPlease
+    NEEDS_LIBICONV = YesPlease
+    DEFAULT_EDITOR = nano
+    PTHREAD_LIBS =    -lroot
+    NO_CROSS_DIRECTORY_HARDLINKS = YesPlease
+endif
 ifeq ($(uname_S),Windows)
 	GIT_VERSION := $(GIT_VERSION).MSVC
 	pathsep = ;









--------------------




-- 
Jabber ID: admin@freenet59.ru
-- 

```

## Jonathan Nieder, 2013-02-23 20:42

Subject: Re: patch for fix build git on Haiku
Message-ID: <20130223204208.GB3222@elie.Belkin>
URL: https://gitlist.dev/e/20130223204208.GB3222%40elie.Belkin
In-Reply-To: <254e4f8fb172cec1e547413e2828b642@freenet59.ru>

```
Hi,

diger wrote:

> This patch fixes build git on Haiku

Lovely.  May we have your sign-off?  (See
Documentation/SubmittingPatches for what this means.)  Does "make
test" pass?  (Just curious --- it's fine if it doesn't, though in that
case a list of test failures would be helpful.)

Thanks,
Jonathan

(patch left unsnipped for reference)

> --- Makefile.orig	2012-10-21 21:32:15.000000000 +0000
> +++ Makefile
> @@ -1211,6 +1204,16 @@ ifeq ($(uname_S),HP-UX)
>  	endif
>  	GIT_TEST_CMP = cmp
>  endif
> +ifeq ($(uname_S),Haiku)
> +    NO_R_TO_GCC_LINKER = YesPlease
> +    NO_LIBGEN_H = YesPlease
> +    NO_MEMMEM = YesPlease
> +    NO_MKSTEMPS = YesPlease
> +    NEEDS_LIBICONV = YesPlease
> +    DEFAULT_EDITOR = nano
> +    PTHREAD_LIBS =    -lroot
> +    NO_CROSS_DIRECTORY_HARDLINKS = YesPlease
> +endif
>  ifeq ($(uname_S),Windows)
>  	GIT_VERSION := $(GIT_VERSION).MSVC
>  	pathsep = ;

```

## Andreas Färber, 2013-02-24 09:36

Subject: Re: patch for fix build git on Haiku
Message-ID: <5129DF23.7050206@web.de>
URL: https://gitlist.dev/e/5129DF23.7050206%40web.de
In-Reply-To: <20130223204208.GB3222@elie.Belkin>

```
Hi,

Am 23.02.2013 21:42, schrieb Jonathan Nieder:
> diger wrote:
> 
>> This patch fixes build git on Haiku
> 
> Lovely.  May we have your sign-off?  (See
> Documentation/SubmittingPatches for what this means.)  Does "make
> test" pass?  (Just curious --- it's fine if it doesn't, though in that
> case a list of test failures would be helpful.)
> 
> Thanks,
> Jonathan
> 
> (patch left unsnipped for reference)
> 
>> --- Makefile.orig	2012-10-21 21:32:15.000000000 +0000
>> +++ Makefile
>> @@ -1211,6 +1204,16 @@ ifeq ($(uname_S),HP-UX)
>>  	endif
>>  	GIT_TEST_CMP = cmp
>>  endif
>> +ifeq ($(uname_S),Haiku)
>> +    NO_R_TO_GCC_LINKER = YesPlease
>> +    NO_LIBGEN_H = YesPlease
>> +    NO_MEMMEM = YesPlease
>> +    NO_MKSTEMPS = YesPlease
>> +    NEEDS_LIBICONV = YesPlease
>> +    DEFAULT_EDITOR = nano

Patch looks okay from what I have from my earlier ones in mind, but I
believe nano is an Optional Package on Haiku and thus not guaranteed to
be installed. CC'ing HaikuPorts.

Regards,
Andreas

>> +    PTHREAD_LIBS =    -lroot
>> +    NO_CROSS_DIRECTORY_HARDLINKS = YesPlease
>> +endif
>>  ifeq ($(uname_S),Windows)
>>  	GIT_VERSION := $(GIT_VERSION).MSVC
>>  	pathsep = ;

```