threads / patch / 32967

v4, 4 partst7800: "defaults" is no longer a builtin tool name

Subject: [PATCH v4 4/4] t7800: "defaults" is no longer a builtin tool name

## tl;dr

2 messages between Feb 21, 2013 and Feb 21, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

David Aguilar· Feb 21, 2013, 23:32 UTC · lore

073678b8e6324a155fa99f40eee0637941a70a34 reworked the mergetools/ directory so that every file corresponds to a difftool-supported tool. When this happened the "defaults" file went away as it was no longer needed by mergetool--lib.

t7800 tests that configured commands can override builtins, but this test was not adjusted when the "defaults" file was removed because the test continued to pass.

Adjust the test to use the everlasting "vimdiff" tool name instead of "defaults" so that it correctly tests against a tool that is known by mergetool--lib.

Signed-off-by: David Aguilar <davvid@gmail.com>
---
Replacement patch to fix my botched rebase.
 t/t7800-difftool.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to t/t7800-difftool.sh +2 −2
diff --git a/t/t7800-difftool.sh b/t/t7800-difftool.sh
index fb00273..3aab6e1 100755
--- a/t/t7800-difftool.sh
+++ b/t/t7800-difftool.sh
@@ -60,9 +60,9 @@ test_expect_success PERL 'custom commands' '
 '
 
 test_expect_success PERL 'custom tool commands override built-ins' '
-	test_config difftool.defaults.cmd "cat \"\$REMOTE\"" &&
+	test_config difftool.vimdiff.cmd "cat \"\$REMOTE\"" &&
 	echo master >expect &&
-	git difftool --tool defaults --no-prompt branch >actual &&
+	git difftool --tool vimdiff --no-prompt branch >actual &&
 	test_cmp expect actual
 '
 
-- 
1.8.2.rc0.20.gf548dd7

← back to recent threads