threads / patch / 32843

patch, 4 partsMake git-send-email git-credential

Subject: [PATCH 0/4] Make git-send-email git-credential

## tl;dr

3 messages between Feb 6, 2013 and Feb 6, 2013. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Michal Nazarewicz· Feb 6, 2013, 20:34 UTC · lore

From: Michal Nazarewicz <mina86@mina86.com>

As discussed on the list, adding git-credential interface to Git.pm (sort of copied from git-remote-mediawiki) and making git-send-email use it.

I see git-remote-mediawiki does not have “use Git” so I did not touch it. On top of that I'd have no way to tests the changes anyway.

Michal Nazarewicz (4):
  Git.pm: Allow command_close_bidi_pipe() to be called as method
  Git.pm: Allow pipes to be closed prior to calling
    command_close_bidi_pipe
  Git.pm: Add interface for git credential command.
  git-send-email: Use git credential to obtain password.

 Documentation/git-send-email.txt |   4 +-
 git-send-email.perl              |  60 +++++++++++---------
 perl/Git.pm                      | 116 ++++++++++++++++++++++++++++++++++++++-
 3 files changed, 149 insertions(+), 31 deletions(-)

-- 
1.8.1.2.550.g0d3a9c0.dirty

Michal Nazarewicz· Feb 6, 2013, 20:38 UTC · re: Michal Nazarewicz · lore

Re: [PATCH 0/4] Make git-send-email git-credential

On Wed, Feb 06 2013, Michal Nazarewicz wrote:

Show 18 quoted lines

> As discussed on the list, adding git-credential interface to Git.pm
> (sort of copied from git-remote-mediawiki) and making git-send-email
> use it.
>
> I see git-remote-mediawiki does not have “use Git” so I did not touch
> it.  On top of that I'd have no way to tests the changes anyway.
>
> Michal Nazarewicz (4):
>   Git.pm: Allow command_close_bidi_pipe() to be called as method
>   Git.pm: Allow pipes to be closed prior to calling
>     command_close_bidi_pipe
>   Git.pm: Add interface for git credential command.
>   git-send-email: Use git credential to obtain password.
>
>  Documentation/git-send-email.txt |   4 +-
>  git-send-email.perl              |  60 +++++++++++---------
>  perl/Git.pm                      | 116 ++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 149 insertions(+), 31 deletions(-)

On second thought, give me a moment, ;) I've just discovered a bug preventing git-send-email from mailing a patchset.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--

Junio C Hamano· Feb 6, 2013, 20:54 UTC · re: Michal Nazarewicz · lore

Re: [PATCH 0/4] Make git-send-email git-credential

Michal Nazarewicz <mina86@mina86.com> writes:

> On second thought, give me a moment, ;) I've just discovered a bug
> preventing git-send-email from mailing a patchset.

I somehow found this highly amusing.

I wish all the bugs are like that: if your series is buggy, some parts of the system prevents you from sending it to the list.

;-)