threads / discuss / 32807

Re: Re: Segmentation fault with latest git (070c57df)

Subject: Re: Re: Segmentation fault with latest git (070c57df)

## tl;dr

2 messages between Feb 1, 2013 and Feb 1, 2013.

replies: 1people: 2as markdown or json

Jongman Heo· Feb 1, 2013, 09:14 UTC · lore
Junio C Hamano<gitster@pobox.com> wrote :
Show 7 quoted lines
> 허종만 writes:
>> But usually when I build upstream Linux kernel, I don't do "make
>> clean" after git pull..  I didn't expect that I needed "make
>> clean" for git build.
>
> We don't expect anybody need "make clean", either.  There is
> something wrong in the dependency.
Hi all,

I can reproduce the issue in my machine (RedHat Enterprise 5, x86 PAE) as follows. But in my different machine (Fedora 16 x86) I can't reproduce.

  $ git reset --hard v1.8.1       # back to v1.8.1
  $ make clean 
  $ make all install               # this git works fine
  $ git pull                          # top commit 9a6c84e6, "Merge git://ozlabs.org/~paulus/gitk"
  $ make all install
  $ git fetch                         # this git segfaults
  Segmentation fault
So if there is any patch to test, just let me know  (but will not available during weekend).

Regards, Jongman Heo

Jeff King· Feb 1, 2013, 09:57 UTC · re: Jongman Heo · lore
On Fri, Feb 01, 2013 at 09:14:41AM +0000, Jongman Heo wrote:
> I can reproduce the issue in my machine (RedHat Enterprise 5, x86 PAE) as follows. 
Great, thanks for taking the time to reproduce.
> But in my different machine (Fedora 16 x86) I can't reproduce.

That makes me wonder if it is related to the gcc or make version. I couldn't reproduce the problem on my gcc-4.1 system, though. My make is:

  $ make --version
  GNU Make 3.81
  [...]
>   $ git reset --hard v1.8.1       # back to v1.8.1
>   $ make clean 
>   $ make all install               # this git works fine

After this step, what does builtin/.depend/fetch.o.d contain? It should show a dependency of builtin/fetch.o on string-list (among other things).

>   $ git pull                          # top commit 9a6c84e6, "Merge git://ozlabs.org/~paulus/gitk"
>   $ make all install

Can you try running "make -d builtin/fetch.o" here instead of "make all install"? Can you confirm that it reads builtin/.depend/fetch.o, and that fetch.o gets rebuilt (you should even be able to see the list of "newer than" dependencies in the debug output)?

Another thing to double-check: does it work if you instead run
  make all install COMPUTE_HEADER_DEPENDENCIES=no
?
-Peff

← back to recent threads