# Build broken for contrib/remote-helpers... 4 messages from 2013-01-22 to 2013-01-22. Participants: John Szakmeister, Jeff King, Torsten Bögershausen, Junio C Hamano. Thread: https://gitlist.dev/t/32690 ## John Szakmeister, 2013-01-22 05:49 Subject: Build broken for contrib/remote-helpers... Message-ID: URL: https://gitlist.dev/e/CAEBDL5U%2BYrny-YgN1fZj1T%2BXTJRVaiFvMixT13Zzb2DhhYgQsA%40mail.gmail.com ``` I tried running make in contrib/remote-helpers and it died with: :: make make -e -C ../../t test rm -f -r test-results duplicate test numbers: /Users/jszakmeister/sources/git make[1]: *** [test-lint-duplicates] Error 1 make: *** [test] Error 2 The path shown is not quite correct. I have the sources extracted to /Users/jszakmeister/sources/git-1.8.1.1. It appears that the Makefile in contrib/remote-helpers is exporting T, which is causing the duplicate test detection to fail. Thought you'd like to know! -John ``` ## Jeff King, 2013-01-22 19:41 Subject: Re: Build broken for contrib/remote-helpers... Message-ID: <20130122194135.GA23521@sigill.intra.peff.net> URL: https://gitlist.dev/e/20130122194135.GA23521%40sigill.intra.peff.net In-Reply-To: ``` On Tue, Jan 22, 2013 at 12:49:31AM -0500, John Szakmeister wrote: > I tried running make in contrib/remote-helpers and it died with: > > :: make > make -e -C ../../t test > rm -f -r test-results > duplicate test numbers: /Users/jszakmeister/sources/git > make[1]: *** [test-lint-duplicates] Error 1 > make: *** [test] Error 2 > > The path shown is not quite correct. I have the sources extracted to > /Users/jszakmeister/sources/git-1.8.1.1. It appears that the Makefile > in contrib/remote-helpers is exporting T, which is causing the > duplicate test detection to fail. It has to set T, because that is how t/Makefile knows what the set of tests is. The problem is that test-lint-duplicates does not understand absolute pathnames, as its regex is too simplistic: sed 's/-.*//' | sort | uniq -d So it finds whatever is before the first "-", which would be the test number in "t0000-basic.sh" or similar, and then looks for duplicates. We can make the regex more strict to handle full paths, like: perl -lne 'print $1 if m{(?:^|/)(t\d{4})-}' but that still would not help, as the tests in remote-helpers do not follow the tXXXX convention. So I think even running test-lint-duplicates on them is nonsensical. Maybe something like this would be more appropriate, though it kills off all test-lint checks, not just test-lint-duplicates: diff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile index 9a76575..9c18ed8 100644 --- a/contrib/remote-helpers/Makefile +++ b/contrib/remote-helpers/Makefile @@ -3,6 +3,7 @@ export PATH := $(CURDIR):$(PATH) export T := $(addprefix $(CURDIR)/,$(TESTS)) export MAKE := $(MAKE) -e export PATH := $(CURDIR):$(PATH) +export TEST_LINT := test: $(MAKE) -C ../../t $@ ``` ## Torsten Bögershausen, 2013-01-22 20:55 Subject: Re: Build broken for contrib/remote-helpers... Message-ID: <50FEFCD7.2060402@web.de> URL: https://gitlist.dev/e/50FEFCD7.2060402%40web.de In-Reply-To: <20130122194135.GA23521@sigill.intra.peff.net> ``` On 22.01.13 20:41, Jeff King wrote: > On Tue, Jan 22, 2013 at 12:49:31AM -0500, John Szakmeister wrote: > >> I tried running make in contrib/remote-helpers and it died with: >> >> :: make >> make -e -C ../../t test >> rm -f -r test-results >> duplicate test numbers: /Users/jszakmeister/sources/git >> make[1]: *** [test-lint-duplicates] Error 1 >> make: *** [test] Error 2 >> >> The path shown is not quite correct. I have the sources extracted to >> /Users/jszakmeister/sources/git-1.8.1.1. It appears that the Makefile >> in contrib/remote-helpers is exporting T, which is causing the >> duplicate test detection to fail. > > It has to set T, because that is how t/Makefile knows what the set of > tests is. The problem is that test-lint-duplicates does not understand > absolute pathnames, as its regex is too simplistic: > > sed 's/-.*//' | sort | uniq -d > > So it finds whatever is before the first "-", which would be the test > number in "t0000-basic.sh" or similar, and then looks for duplicates. would it help to filter for numbered tests before sorting like this: sed 's/-.*//' | grep "[0-9][0-9][0-9][0-9]"| sort | uniq -d ``` ## Junio C Hamano, 2013-01-22 22:22 Subject: Re: Build broken for contrib/remote-helpers... Message-ID: <7vehhcn9i9.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vehhcn9i9.fsf%40alter.siamese.dyndns.org In-Reply-To: <50FEFCD7.2060402@web.de> ``` Torsten Bögershausen writes: >> So it finds whatever is before the first "-", which would be the test >> number in "t0000-basic.sh" or similar, and then looks for duplicates. > > would it help to filter for numbered tests before sorting like this: > > sed 's/-.*//' | grep "[0-9][0-9][0-9][0-9]"| sort | uniq -d If you are using sed you do not need grep. Just do that in a single process, perhaps like sed -ne 's|\(.*/\)*t\([0-9][0-9][0-9][0-9]\)-.*|\2|p' But more importantly, what do we want "duplicate numbers" sanity check to mean in this context? Is this other directory allowed to have a numbered test that shares the same number as the main test suite? Is uniqueness inside the contrib/remote-helpers/ directory sufficient? Do we envision that perhaps someday the contrib material becomes mature enough and will want to migrate to the main part of the tree? If that is the case, perhaps should the check complain that these tests are not numbered, instead of ignoring? ```