# [PATCH] test-lib.sh: unfilter GIT_PERF_* 7 messages from 2013-01-15 to 2013-01-16. Participants: Nguyễn Thái Ngọc Duy, Thomas Rast, Duy Nguyen, Junio C Hamano, Jonathan Nieder. Thread: https://gitlist.dev/t/32637 ## Nguyễn Thái Ngọc Duy, 2013-01-15 12:53 Subject: [PATCH] test-lib.sh: unfilter GIT_PERF_* Message-ID: <1358254409-15187-1-git-send-email-pclouds@gmail.com> URL: https://gitlist.dev/e/1358254409-15187-1-git-send-email-pclouds%40gmail.com ``` These variables are user parameters to control how to run the perf tests. Allow users to do so. Signed-off-by: Nguyễn Thái Ngọc Duy --- t/test-lib.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/test-lib.sh b/t/test-lib.sh index f50f834..b8d35d1 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e ' PROVE VALGRIND PERF_AGGREGATING_LATER + PERF_LARGE_REPO + PERF_REPEAT_COUNT + PERF_REPO )); my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env); print join("\n", @vars); -- 1.8.0.rc2.23.g1fb49df ``` ## Thomas Rast, 2013-01-15 13:43 Subject: Re: [PATCH] test-lib.sh: unfilter GIT_PERF_* Message-ID: <87ehhmr28g.fsf@pctrast.inf.ethz.ch> URL: https://gitlist.dev/e/87ehhmr28g.fsf%40pctrast.inf.ethz.ch In-Reply-To: <1358254409-15187-1-git-send-email-pclouds@gmail.com> ``` Nguyễn Thái Ngọc Duy writes: > These variables are user parameters to control how to run the perf > tests. Allow users to do so. [...] > @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e ' > PROVE > VALGRIND > PERF_AGGREGATING_LATER > + PERF_LARGE_REPO > + PERF_REPEAT_COUNT > + PERF_REPO > )); Wouldn't it be more futureproof to put simply PERF as an entry, and rely on the leading-match logic > my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env); to allow all GIT_PERF variables? Other than that, Ack. I never noticed because I set mine through config.mak, which goes to GIT-BUILD-OPTIONS. Those options are not exported, which means perl does not pick them up. (That just took me far too long to realize.) -- Thomas Rast trast@{inf,student}.ethz.ch ``` ## Duy Nguyen, 2013-01-15 13:47 Subject: Re: [PATCH] test-lib.sh: unfilter GIT_PERF_* Message-ID: URL: https://gitlist.dev/e/CACsJy8BaPfiHL86uh8QOKXzBXb3eKiRnN1MV0e8WegsFzodWHQ%40mail.gmail.com In-Reply-To: <87ehhmr28g.fsf@pctrast.inf.ethz.ch> ``` On Tue, Jan 15, 2013 at 8:43 PM, Thomas Rast wrote: > Nguyễn Thái Ngọc Duy writes: > >> These variables are user parameters to control how to run the perf >> tests. Allow users to do so. > [...] >> @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e ' >> PROVE >> VALGRIND >> PERF_AGGREGATING_LATER >> + PERF_LARGE_REPO >> + PERF_REPEAT_COUNT >> + PERF_REPO >> )); > > Wouldn't it be more futureproof to put simply PERF as an entry, and rely > on the leading-match logic > >> my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env); > > to allow all GIT_PERF variables? Yeah. > Other than that, Ack. I never noticed because I set mine through > config.mak, which goes to GIT-BUILD-OPTIONS. Those options are not > exported, which means perl does not pick them up. (That just took me > far too long to realize.) By the way is there an option to skip the first few runs (too lazy to check out the source code, apparently)? I tried linux-2.6 as the large repo and I think the first (cold cache) run ruins the numbers. -- Duy ``` ## Nguyễn Thái Ngọc Duy, 2013-01-15 13:50 Subject: [PATCH v2] test-lib.sh: unfilter GIT_PERF_* Message-ID: <1358257856-3274-1-git-send-email-pclouds@gmail.com> URL: https://gitlist.dev/e/1358257856-3274-1-git-send-email-pclouds%40gmail.com In-Reply-To: <1358254409-15187-1-git-send-email-pclouds@gmail.com> ``` These variables are user parameters to control how to run the perf tests. Allow users to do so. Signed-off-by: Nguyễn Thái Ngọc Duy --- t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index f50f834..e1c8c85 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -85,7 +85,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e ' .*_TEST PROVE VALGRIND - PERF_AGGREGATING_LATER + PERF )); my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env); print join("\n", @vars); -- 1.8.0.rc2.23.g1fb49df ``` ## Junio C Hamano, 2013-01-15 19:31 Subject: Re: [PATCH v2] test-lib.sh: unfilter GIT_PERF_* Message-ID: <7vsj622qft.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vsj622qft.fsf%40alter.siamese.dyndns.org In-Reply-To: <1358257856-3274-1-git-send-email-pclouds@gmail.com> ``` Nguyễn Thái Ngọc Duy writes: > These variables are user parameters to control how to run the perf > tests. Allow users to do so. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- I think the Subject makes more sense, so I'd suggest replacing the current one with "PERF_", not with "PERF". > t/test-lib.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/test-lib.sh b/t/test-lib.sh > index f50f834..e1c8c85 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -85,7 +85,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e ' > .*_TEST > PROVE > VALGRIND > - PERF_AGGREGATING_LATER > + PERF > )); > my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env); > print join("\n", @vars); ``` ## Nguyễn Thái Ngọc Duy, 2013-01-16 10:23 Subject: [PATCH v3] test-lib.sh: unfilter GIT_PERF_* Message-ID: <1358331833-8289-1-git-send-email-pclouds@gmail.com> URL: https://gitlist.dev/e/1358331833-8289-1-git-send-email-pclouds%40gmail.com In-Reply-To: <1358257856-3274-1-git-send-email-pclouds@gmail.com> ``` These variables are user parameters to control how to run the perf tests. Allow users to do so. Signed-off-by: Nguyễn Thái Ngọc Duy --- PERF -> PERF_ t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index f50f834..bf4cf71 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -85,7 +85,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e ' .*_TEST PROVE VALGRIND - PERF_AGGREGATING_LATER + PERF_ )); my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env); print join("\n", @vars); -- 1.8.0.rc2.23.g1fb49df ``` ## Jonathan Nieder, 2013-01-16 18:54 Subject: Re: [PATCH v3] test-lib.sh: unfilter GIT_PERF_* Message-ID: <20130116185416.GA28866@google.com> URL: https://gitlist.dev/e/20130116185416.GA28866%40google.com In-Reply-To: <1358331833-8289-1-git-send-email-pclouds@gmail.com> ``` Nguyễn Thái Ngọc Duy wrote: > These variables are user parameters to control how to run the perf > tests. Allow users to do so. > > Signed-off-by: Nguyễn Thái Ngọc Duy FWIW, of the three versions proposed, this one makes the most sense to me. Looks good. ```