[PATCH] builtin/reset.c: Fix a sparse warning

Ramsay Jones· Jan 14, 2013, 19:28 UTC · lore

In particular, sparse issues an "symbol not declared. Should it be static?" warning for the 'parse_args' function. Since this function does not require greater than file visibility, we suppress this warning by simply adding the static modifier to it's decalaration.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Martin,

When you re-roll your "reset" patches (branch 'mz/reset-misc'), could you please squash this into commit b24b3654 ("reset.c: extract function for parsing arguments", 09-01-2013). Note that this patch is on top of the pu branch (@75ea4ed3), which includes Junio's style fix patch (commit 9f45c39f, "[SQUASH???] style fix", 10-01-2013).

Thanks!

ATB, Ramsay Jones

 builtin/reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to builtin/reset.c +1 −1

diff --git a/builtin/reset.c b/builtin/reset.c
index a37044e..c69f9da 100644
--- a/builtin/reset.c
+++ b/builtin/reset.c
@@ -171,7 +171,7 @@ static void die_if_unmerged_cache(int reset_type)
 
 }
 
-const char **parse_args(int argc, const char **argv, const char *prefix, const char **rev_ret)
+static const char **parse_args(int argc, const char **argv, const char *prefix, const char **rev_ret)
 {
 	const char *rev = "HEAD";
 	unsigned char unused[20];

-- 
1.8.1

Martin von Zweigbergk· Jan 14, 2013, 19:35 UTC · re: Ramsay Jones · lore

Re: [PATCH] builtin/reset.c: Fix a sparse warning

On Mon, Jan 14, 2013 at 11:28 AM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

Show 5 quoted lines

>
> In particular, sparse issues an "symbol not declared. Should it be
> static?" warning for the 'parse_args' function. Since this function
> does not require greater than file visibility, we suppress this
> warning by simply adding the static modifier to it's decalaration.

Oops, how did I miss that? Will fix in re-roll. Thanks.

Martin

patchbuiltin/reset.c: Fix a sparse warning