# [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named "f*" 3 messages from 2013-01-06 to 2013-01-06. Participants: Johannes Sixt, Jeff King, Junio C Hamano. Thread: https://gitlist.dev/t/32541 ## Johannes Sixt, 2013-01-06 14:07 Subject: [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named "f*" Message-ID: <50E9852F.2060005@kdbg.org> URL: https://gitlist.dev/e/50E9852F.2060005%40kdbg.org ``` Windows disallows file names that contain a star. Arrange the test setup to insert the file name "f*" in the repository without the corresponding file in the worktree. Signed-off-by: Johannes Sixt --- t/t6130-pathspec-noglob.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/t/t6130-pathspec-noglob.sh b/t/t6130-pathspec-noglob.sh index bb5e710..39ef619 100755 --- a/t/t6130-pathspec-noglob.sh +++ b/t/t6130-pathspec-noglob.sh @@ -6,7 +6,13 @@ test_description='test globbing (and noglob) of pathspec limiting' test_expect_success 'create commits with glob characters' ' test_commit unrelated bar && test_commit vanilla foo && - test_commit star "f*" && + # insert file "f*" in the commit, but in a way that avoids + # the name "f*" in the worktree, because it is not allowed + # on Windows (the tests below do not depend on the presence + # of the file in the worktree) + git update-index --add --cacheinfo 100644 "$(git rev-parse HEAD:foo)" "f*" && + test_tick && + git commit -m star && test_commit bracket "f[o][o]" ' -- 1.8.1.1672.g5e2a3d4.dirty -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en ``` ## Jeff King, 2013-01-06 14:33 Subject: Re: [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named "f*" Message-ID: <20130106143319.GA10690@sigill.intra.peff.net> URL: https://gitlist.dev/e/20130106143319.GA10690%40sigill.intra.peff.net In-Reply-To: <50E9852F.2060005@kdbg.org> ``` On Sun, Jan 06, 2013 at 03:07:43PM +0100, Johannes Sixt wrote: > Windows disallows file names that contain a star. Arrange the test setup > to insert the file name "f*" in the repository without the corresponding > file in the worktree. > [...] > - test_commit star "f*" && > + # insert file "f*" in the commit, but in a way that avoids > + # the name "f*" in the worktree, because it is not allowed > + # on Windows (the tests below do not depend on the presence > + # of the file in the worktree) > + git update-index --add --cacheinfo 100644 "$(git rev-parse HEAD:foo)" "f*" && > + test_tick && > + git commit -m star && Thanks, looks obviously correct to me. Sorry to break Windows again. It seems I learn about a new gotcha with every patch series. :) -Peff ``` ## Junio C Hamano, 2013-01-06 20:00 Subject: Re: [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named "f*" Message-ID: <7vbod2nkss.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vbod2nkss.fsf%40alter.siamese.dyndns.org In-Reply-To: <20130106143319.GA10690@sigill.intra.peff.net> ``` Jeff King writes: > On Sun, Jan 06, 2013 at 03:07:43PM +0100, Johannes Sixt wrote: > >> Windows disallows file names that contain a star. Arrange the test setup >> to insert the file name "f*" in the repository without the corresponding >> file in the worktree. >> [...] >> - test_commit star "f*" && >> + # insert file "f*" in the commit, but in a way that avoids >> + # the name "f*" in the worktree, because it is not allowed >> + # on Windows (the tests below do not depend on the presence >> + # of the file in the worktree) >> + git update-index --add --cacheinfo 100644 "$(git rev-parse HEAD:foo)" "f*" && >> + test_tick && >> + git commit -m star && > > Thanks, looks obviously correct to me. > > Sorry to break Windows again. It seems I learn about a new gotcha with > every patch series. :) Thanks, both. It appears that pushing things earlier to 'next' (and unfortunately even to 'master') rather than later seems to be the only way to help catching little gotchas like this ;-). -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en ```