# [PATCH] Avoid using non-POSIX cp options 2 messages from 2013-01-01 to 2013-01-01. Participants: Ben Walton, Junio C Hamano. Thread: https://gitlist.dev/t/32499 ## Ben Walton, 2013-01-01 20:13 Subject: [PATCH] Avoid using non-POSIX cp options Message-ID: <1357071197-7927-1-git-send-email-bdwalton@gmail.com> URL: https://gitlist.dev/e/1357071197-7927-1-git-send-email-bdwalton%40gmail.com ``` t/3600-rm was using the -a option to cp. This option is a GNU extention and is not portable. Instead, use just -R (no -p necessary). Signed-off-by: Ben Walton --- t/t3600-rm.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t3600-rm.sh b/t/t3600-rm.sh index 06f6384..37bf5f1 100755 --- a/t/t3600-rm.sh +++ b/t/t3600-rm.sh @@ -474,7 +474,7 @@ test_expect_success 'rm of a conflicted populated submodule with a .git director git submodule update && (cd submod && rm .git && - cp -a ../.git/modules/sub .git && + cp -R ../.git/modules/sub .git && GIT_WORK_TREE=. git config --unset core.worktree ) && test_must_fail git merge conflict2 && @@ -508,7 +508,7 @@ test_expect_success 'rm of a populated submodule with a .git directory fails eve git submodule update && (cd submod && rm .git && - cp -a ../.git/modules/sub .git && + cp -R ../.git/modules/sub .git && GIT_WORK_TREE=. git config --unset core.worktree ) && test_must_fail git rm submod && @@ -606,7 +606,7 @@ test_expect_success 'rm of a populated nested submodule with a nested .git direc git submodule update --recursive && (cd submod/subsubmod && rm .git && - cp -a ../../.git/modules/sub/modules/sub .git && + cp -R ../../.git/modules/sub/modules/sub .git && GIT_WORK_TREE=. git config --unset core.worktree ) && test_must_fail git rm submod && -- 1.7.10.4 ``` ## Junio C Hamano, 2013-01-01 21:57 Subject: Re: [PATCH] Avoid using non-POSIX cp options Message-ID: <7vbod88t2l.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vbod88t2l.fsf%40alter.siamese.dyndns.org In-Reply-To: <1357071197-7927-1-git-send-email-bdwalton@gmail.com> ``` Thanks; I think I already have 2d3ac9a (t3600: Avoid "cp -a", which is a GNUism, 2012-12-18) ```