# generating format-patch options from an e-mail 5 messages from 2012-12-26 to 2012-12-26. Participants: Simon Oosthoek, Junio C Hamano, Pyeron, Jason J CTR (US), Jeff King. Thread: https://gitlist.dev/t/32459 ## Simon Oosthoek, 2012-12-26 20:06 Subject: generating format-patch options from an e-mail Message-ID: <20121226200623.GA29446@simaj.xs4all.nl> URL: https://gitlist.dev/e/20121226200623.GA29446%40simaj.xs4all.nl ``` Hi all I've been very frustrated by the process to setup a commandline for git format-patch, to include everyone in the cc list and reply to the right message-id. In my frustration I created a perl script to generate the options from a saved e-mail, I realise that it may be non-general and perhaps it could be written better using a module which understands e-mails, but well, it worked for me ;-) Anyway, I could imagine this as optional flag of git format-patch, so you could say: $ git format-patch -s --in-reply-to-email a7fe7de8 But I'll save that as an exercise for the reader (or the future) Cheers Simon ``` ## Junio C Hamano, 2012-12-26 20:35 Subject: Re: generating format-patch options from an e-mail Message-ID: <7vbodgo8kv.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vbodgo8kv.fsf%40alter.siamese.dyndns.org In-Reply-To: <20121226200623.GA29446@simaj.xs4all.nl> ``` Simon Oosthoek writes: > Hi all > > I've been very frustrated by the process to setup a commandline for git format-patch, to include everyone in the cc list and reply to the right message-id. > > In my frustration I created a perl script to generate the options from a saved e-mail, I realise that it may be non-general and perhaps it could be written better using a module which understands e-mails, but well, it worked for me ;-) > > Anyway, I could imagine this as optional flag of git format-patch, so you could say: > $ git format-patch -s --in-reply-to-email a7fe7de8 > > But I'll save that as an exercise for the reader (or the future) I think a much more general approach would be to turn your script into "get-msg-id" script and use it like so: $ git format-patch --in-reply-to $(get-msg-id ) a7fe7de8 Then you can reuse that script in a context outside format-patch, whereever you need the message-id in a single message in the mailbox. ``` ## Simon Oosthoek, 2012-12-26 21:07 Subject: Re: generating format-patch options from an e-mail Message-ID: <20121226210737.GB20704@xs4all.nl> URL: https://gitlist.dev/e/20121226210737.GB20704%40xs4all.nl In-Reply-To: <7vbodgo8kv.fsf@alter.siamese.dyndns.org> ``` * Junio C Hamano [2012-12-26 12:35:28 -0800]: > > > > Anyway, I could imagine this as optional flag of git format-patch, so you could say: > > $ git format-patch -s --in-reply-to-email a7fe7de8 > > > > But I'll save that as an exercise for the reader (or the future) > > I think a much more general approach would be to turn your script > into "get-msg-id" script and use it like so: > > $ git format-patch --in-reply-to $(get-msg-id ) a7fe7de8 > > Then you can reuse that script in a context outside format-patch, > whereever you need the message-id in a single message in the > mailbox. > That would work for the message-ID, but not for the various To: and Cc: addresses. The hacky script that I sent afterwards produces a string with the various options to git format-patch (--to --cc --in-reply-to) based on the headers To:/Cc:/From:/Message-ID: Cheers Simon ``` ## Pyeron, Jason J CTR (US), 2012-12-26 21:31 Subject: RE: generating format-patch options from an e-mail Message-ID: <871B6C10EBEFE342A772D1159D1320853A00DD2E@umechphj.easf.csd.disa.mil> URL: https://gitlist.dev/e/871B6C10EBEFE342A772D1159D1320853A00DD2E%40umechphj.easf.csd.disa.mil In-Reply-To: <20121226210737.GB20704@xs4all.nl> ``` > -----Original Message----- > From: Simon Oosthoek > Sent: Wednesday, December 26, 2012 4:08 PM > > * Junio C Hamano [2012-12-26 12:35:28 -0800]: > > > > > > Anyway, I could imagine this as optional flag of git format-patch, > so you could say: > > > $ git format-patch -s --in-reply-to-email a7fe7de8 Anyway you would need a --in-reply-to-email and a --in-reply-to-all-email, both should support stdin. Then you can feel free to --[no-]to and --[no-]cc (where is the --bcc?) to your heart's content. It would be a nice addition. > > > > > > But I'll save that as an exercise for the reader (or the future) > > > > I think a much more general approach would be to turn your script > > into "get-msg-id" script and use it like so: > > > > $ git format-patch --in-reply-to $(get-msg-id ) a7fe7de8 > > > > Then you can reuse that script in a context outside format-patch, > > whereever you need the message-id in a single message in the > > mailbox. > > > > That would work for the message-ID, but not for the various To: and Cc: > addresses. > > The hacky script that I sent afterwards produces a string with the Nit, it does not make use of the reply-to header if present. > various options to git format-patch (--to --cc --in-reply-to) based on > the headers To:/Cc:/From:/Message-ID: > > Cheers > > Simon > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ``` ## Jeff King, 2012-12-26 21:57 Subject: Re: generating format-patch options from an e-mail Message-ID: <20121226215712.GA11491@sigill.intra.peff.net> URL: https://gitlist.dev/e/20121226215712.GA11491%40sigill.intra.peff.net In-Reply-To: <871B6C10EBEFE342A772D1159D1320853A00DD2E@umechphj.easf.csd.disa.mil> ``` On Wed, Dec 26, 2012 at 09:31:46PM +0000, Pyeron, Jason J CTR (US) wrote: > > That would work for the message-ID, but not for the various To: and Cc: > > addresses. > > > > The hacky script that I sent afterwards produces a string with the > > Nit, it does not make use of the reply-to header if present. I do something very similar to Simon, except that rather than generating a reply with my script, I generate the cover letter in my MUA, and then use that response as a template. So the MUA does the heavy lifting, understanding reply-to, culling my own address from cc, etc. The format-patch replies then have the exact same to/cc headers as the template, and use the template's message-id as the in-reply-to (for proper threading). My perl looks like this (feed the template via stdin): perl -ne ' if (defined $opt && /^\s+(.*)/) { $val .= " $1"; next; } if (defined $opt) { print "--$opt=", quotemeta($val), " "; $opt = $val = undef; } if (/^(cc|to):\s*(.*)/i) { $opt = lc($1); $val = $2; } elsif (/^message-id:\s*(.*)/i) { $opt = "in-reply-to"; $val = $1; } ' That, of course, presupposes a cover letter. If I am sending a single patch, then I just do "format-patch --stdout" right into my MUA's editor), and let it handle the headers. -Peff ```