# [PATCH] Sort howto documents in howto-index.txt 3 messages from 2012-12-22 to 2012-12-22. Participants: Thomas Ackermann, Junio C Hamano. Thread: https://gitlist.dev/t/32446 ## Thomas Ackermann, 2012-12-22 18:34 Subject: [PATCH] Sort howto documents in howto-index.txt Message-ID: <1870890640.302608.1356201267202.JavaMail.ngmail@webmail13.arcor-online.net> URL: https://gitlist.dev/e/1870890640.302608.1356201267202.JavaMail.ngmail%40webmail13.arcor-online.net ``` Howto documents in howto-index.txt were listed in a rather random order. So better sort them. Signed-off-by: Thomas Ackermann --- Documentation/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/Makefile b/Documentation/Makefile index d7417b8..ff8ad9a 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -348,7 +348,7 @@ $(patsubst %.txt,%.texi,$(MAN_TXT)): %.texi : %.xml howto-index.txt: howto-index.sh $(wildcard howto/*.txt) $(QUIET_GEN)$(RM) $@+ $@ && \ - '$(SHELL_PATH_SQ)' ./howto-index.sh $(wildcard howto/*.txt) >$@+ && \ + '$(SHELL_PATH_SQ)' ./howto-index.sh $(sort $(wildcard howto/*.txt)) >$@+ && \ mv $@+ $@ $(patsubst %,%.html,$(ARTICLES)) : %.html : %.txt -- 1.8.0.msysgit.0 --- Thomas ``` ## Junio C Hamano, 2012-12-22 19:40 Subject: Re: [PATCH] Sort howto documents in howto-index.txt Message-ID: <7v8v8pri3w.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v8v8pri3w.fsf%40alter.siamese.dyndns.org In-Reply-To: <1870890640.302608.1356201267202.JavaMail.ngmail@webmail13.arcor-online.net> ``` Thomas Ackermann writes: > Howto documents in howto-index.txt were listed in a rather > random order. So better sort them. > > Signed-off-by: Thomas Ackermann > --- I think $(wildcard) used to sort but in recent GNU make it no longer does, so this is probably a good change. Do we need to explicitly sort the api-index as well? $(API_DOCS) is fed to the script that reads filenames one at a time in the given order, but I do not see anybody asking for a sorted list while producing that list. The result looks to be sorted in my build farm with GNU make 3.82, but that could be by accident. > Documentation/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/Makefile b/Documentation/Makefile > index d7417b8..ff8ad9a 100644 > --- a/Documentation/Makefile > +++ b/Documentation/Makefile > @@ -348,7 +348,7 @@ $(patsubst %.txt,%.texi,$(MAN_TXT)): %.texi : %.xml > > howto-index.txt: howto-index.sh $(wildcard howto/*.txt) > $(QUIET_GEN)$(RM) $@+ $@ && \ > - '$(SHELL_PATH_SQ)' ./howto-index.sh $(wildcard howto/*.txt) >$@+ && \ > + '$(SHELL_PATH_SQ)' ./howto-index.sh $(sort $(wildcard howto/*.txt)) >$@+ && \ > mv $@+ $@ > > $(patsubst %,%.html,$(ARTICLES)) : %.html : %.txt ``` ## Thomas Ackermann, 2012-12-22 19:54 Subject: Aw: Re: [PATCH] Sort howto documents in howto-index.txt Message-ID: <1937031575.96914.1356206057592.JavaMail.ngmail@webmail06.arcor-online.net> URL: https://gitlist.dev/e/1937031575.96914.1356206057592.JavaMail.ngmail%40webmail06.arcor-online.net In-Reply-To: <7v8v8pri3w.fsf@alter.siamese.dyndns.org> ``` > > I think $(wildcard) used to sort but in recent GNU make it no longer > does, so this is probably a good change. > > Do we need to explicitly sort the api-index as well? $(API_DOCS) is > fed to the script that reads filenames one at a time in the given > order, but I do not see anybody asking for a sorted list while > producing that list. The result looks to be sorted in my build > farm with GNU make 3.82, but that could be by accident. > $(API_DOCS) is not fed to api-index.sh; it's only in the dependencies. api-index.sh uses "ls api-*.txt" internally which produces a correct sorting. Unifying api-index.sh and howto-index.sh is on my todo list ... --- Thomas ```