threads / patch / 32417

patcht9902: Be more specific when completing git-checkout

Subject: [PATCH] t9902: Be more specific when completing git-checkout

## tl;dr

One message between Dec 20, 2012 and Dec 20, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Torsten Bögershausen· Dec 20, 2012, 17:31 UTC · lore

t9902 is trying to complete e.g. "git --version check" into "git --version checkout"

If there are other binaries like "git-check-email" or "git-check-ignore" in the PATH one test case failes

By using "checkou" instead of "check" the test becomes more future proof.

Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
 t/t9902-completion.sh | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
Show changes to t/t9902-completion.sh +12 −12
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index 3cd53f8..0e0e2d1 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -192,19 +192,19 @@ test_expect_success 'general options' '
 '
 
 test_expect_success 'general options plus command' '
-	test_completion "git --version check" "checkout " &&
-	test_completion "git --paginate check" "checkout " &&
-	test_completion "git --git-dir=foo check" "checkout " &&
-	test_completion "git --bare check" "checkout " &&
+	test_completion "git --version checkou" "checkout " &&
+	test_completion "git --paginate checkou" "checkout " &&
+	test_completion "git --git-dir=foo checkou" "checkout " &&
+	test_completion "git --bare checkou" "checkout " &&
 	test_completion "git --help des" "describe " &&
-	test_completion "git --exec-path=foo check" "checkout " &&
-	test_completion "git --html-path check" "checkout " &&
-	test_completion "git --no-pager check" "checkout " &&
-	test_completion "git --work-tree=foo check" "checkout " &&
-	test_completion "git --namespace=foo check" "checkout " &&
-	test_completion "git --paginate check" "checkout " &&
-	test_completion "git --info-path check" "checkout " &&
-	test_completion "git --no-replace-objects check" "checkout "
+	test_completion "git --exec-path=foo checkou" "checkout " &&
+	test_completion "git --html-path checkou" "checkout " &&
+	test_completion "git --no-pager checkou" "checkout " &&
+	test_completion "git --work-tree=foo checkou" "checkout " &&
+	test_completion "git --namespace=foo checkou" "checkout " &&
+	test_completion "git --paginate checkou" "checkout " &&
+	test_completion "git --info-path checkou" "checkout " &&
+	test_completion "git --no-replace-objects checkou" "checkout "
 '
 
 test_expect_success 'setup for ref completion' '
-- 
1.8.0

← back to recent threads