# Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h

2 messages from 2012-12-14 to 2012-12-15. Participants: Johannes Sixt, Joachim Schmitz.
Thread: https://gitlist.dev/t/32344

## Johannes Sixt, 2012-12-14 23:16

Subject: Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h
Message-ID: <50CBB34E.8090609@kdbg.org>
URL: https://gitlist.dev/e/50CBB34E.8090609%40kdbg.org
In-Reply-To: <00c601cdda4c$eb6be9a0$c243bce0$@schmitz-digital.de>

```
Am 14.12.2012 23:46, schrieb Joachim Schmitz:
> Johannes Sixt wrote:
>> Am 14.12.2012 20:57, schrieb David Michael:
>>> This platform previously included strings.h automatically.  However,
>>> the build system now requires an explicit option to do so.
>>>
>>> Signed-off-by: David Michael <fedora.dm0@gmail.com>
>>> ---
>>>  Makefile | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index fb78f7f..e84b0cb 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>>>      # Added manually, see above.
>>>      NEEDS_SSL_WITH_CURL = YesPlease
>>>      HAVE_LIBCHARSET_H = YesPlease
>>> +    HAVE_STRINGS_H = YesPlease
>>>      NEEDS_LIBICONV = YesPlease
>>>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
>>>      NO_SYS_SELECT_H = UnfortunatelyYes
>>
>> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
>> should be squashed into the previous patch, shouldn't it?
> 
> Patch 4/4 does not work without 3/4, Not for HP-NonStop.

That is clear from the order of the patches in the series.

To put it in a different way: Do all supported platforms still work
after 3/4, but without 4/4?

-- Hannes

```

## Joachim Schmitz, 2012-12-15 08:25

Subject: RE: [PATCH 4/4] Declare that HP NonStop systems require strings.h
Message-ID: <00c701cdda9d$b5ee33e0$21ca9ba0$@schmitz-digital.de>
URL: https://gitlist.dev/e/00c701cdda9d%24b5ee33e0%2421ca9ba0%24%40schmitz-digital.de
In-Reply-To: <50CBB34E.8090609@kdbg.org>

```
> From: Johannes Sixt [mailto:j6t@kdbg.org]
> Sent: Saturday, December 15, 2012 12:17 AM
> To: Joachim Schmitz
> Cc: gitster@pobox.com; fedora.dm0@gmail.com; Git Mailing List
> Subject: Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h
> 
> Am 14.12.2012 23:46, schrieb Joachim Schmitz:
> > Johannes Sixt wrote:
> >> Am 14.12.2012 20:57, schrieb David Michael:
> >>> This platform previously included strings.h automatically.  However,
> >>> the build system now requires an explicit option to do so.
> >>>
> >>> Signed-off-by: David Michael <fedora.dm0@gmail.com>
> >>> ---
> >>>  Makefile | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/Makefile b/Makefile
> >>> index fb78f7f..e84b0cb 100644
> >>> --- a/Makefile
> >>> +++ b/Makefile
> >>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
> >>>      # Added manually, see above.
> >>>      NEEDS_SSL_WITH_CURL = YesPlease
> >>>      HAVE_LIBCHARSET_H = YesPlease
> >>> +    HAVE_STRINGS_H = YesPlease
> >>>      NEEDS_LIBICONV = YesPlease
> >>>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
> >>>      NO_SYS_SELECT_H = UnfortunatelyYes
> >>
> >> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
> >> should be squashed into the previous patch, shouldn't it?
> >
> > Patch 4/4 does not work without 3/4, Not for HP-NonStop.
> 
> That is clear from the order of the patches in the series.
> 
> To put it in a different way: Do all supported platforms still work
> after 3/4, but without 4/4?

Sorry I didn't make myself clear, I left out a "and vice versa"

Bye, Jojo

```