threads / patch / 32335

patchDocumentation/git-clean: Document --force --force

Subject: [PATCH] Documentation/git-clean: Document --force --force

## tl;dr

4 messages between Dec 14, 2012 and Dec 21, 2012. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Soren Brinkmann· Dec 14, 2012, 01:46 UTC · lore

This patch documents the behavior of 'git clean' when encountering nested git repositories. Such repositories are only deleted if '-f' is passed twice to 'git clean'.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
 Documentation/git-clean.txt | 5 +++++
 1 file changed, 5 insertions(+)

Show changes to Documentation/git-clean.txt +5 −0

diff --git a/Documentation/git-clean.txt b/Documentation/git-clean.txt
index 9f42c0d..0b31454 100644
--- a/Documentation/git-clean.txt
+++ b/Documentation/git-clean.txt
@@ -23,6 +23,9 @@ example, be useful to remove all build products.
 If any optional `<path>...` arguments are given, only those paths
 are affected.
 
+Nested git repositories are not removed unless the '-f' option is
+passed to 'git clean' twice.
+
 OPTIONS
 -------
 -d::
@@ -35,6 +38,8 @@ OPTIONS
 --force::
 	If the git configuration variable clean.requireForce is not set
 	to false, 'git clean' will refuse to run unless given -f or -n.
+	Pass this option twice to 'git clean' in order to also remove
+	nested git repositories.
 
 -n::
 --dry-run::

-- 
1.8.0.2

Soren Brinkmann· Dec 20, 2012, 23:37 UTC · re: Soren Brinkmann · lore

Re: [PATCH] Documentation/git-clean: Document --force --force

Ping?

On Thu, Dec 13, 2012 at 05:46:55PM -0800, Soren Brinkmann wrote:

Show 42 quoted lines

> This patch documents the behavior of 'git clean' when
> encountering nested git repositories.
> Such repositories are only deleted if '-f' is passed twice
> to 'git clean'.
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
>  Documentation/git-clean.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/git-clean.txt b/Documentation/git-clean.txt
> index 9f42c0d..0b31454 100644
> --- a/Documentation/git-clean.txt
> +++ b/Documentation/git-clean.txt
> @@ -23,6 +23,9 @@ example, be useful to remove all build products.
>  If any optional `<path>...` arguments are given, only those paths
>  are affected.
>  
> +Nested git repositories are not removed unless the '-f' option is
> +passed to 'git clean' twice.
> +
>  OPTIONS
>  -------
>  -d::
> @@ -35,6 +38,8 @@ OPTIONS
>  --force::
>  	If the git configuration variable clean.requireForce is not set
>  	to false, 'git clean' will refuse to run unless given -f or -n.
> +	Pass this option twice to 'git clean' in order to also remove
> +	nested git repositories.
>  
>  -n::
>  --dry-run::
> -- 
> 1.8.0.2
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Junio C Hamano· Dec 21, 2012, 03:01 UTC · re: Soren Brinkmann · lore

Re: [PATCH] Documentation/git-clean: Document --force --force

Soren Brinkmann <soren.brinkmann@xilinx.com> writes:

> Ping?

I *think* it is a mistake for the command to remove a separate project repository within, with any number of "-f", so I'd rather see a patch to fix it, instead of casting such a misbehaviour as a feature in stone by documenting it.

I dunno.

Show 43 quoted lines

> On Thu, Dec 13, 2012 at 05:46:55PM -0800, Soren Brinkmann wrote:
>> This patch documents the behavior of 'git clean' when
>> encountering nested git repositories.
>> Such repositories are only deleted if '-f' is passed twice
>> to 'git clean'.
>> 
>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>> ---
>>  Documentation/git-clean.txt | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/Documentation/git-clean.txt b/Documentation/git-clean.txt
>> index 9f42c0d..0b31454 100644
>> --- a/Documentation/git-clean.txt
>> +++ b/Documentation/git-clean.txt
>> @@ -23,6 +23,9 @@ example, be useful to remove all build products.
>>  If any optional `<path>...` arguments are given, only those paths
>>  are affected.
>>  
>> +Nested git repositories are not removed unless the '-f' option is
>> +passed to 'git clean' twice.
>> +
>>  OPTIONS
>>  -------
>>  -d::
>> @@ -35,6 +38,8 @@ OPTIONS
>>  --force::
>>  	If the git configuration variable clean.requireForce is not set
>>  	to false, 'git clean' will refuse to run unless given -f or -n.
>> +	Pass this option twice to 'git clean' in order to also remove
>> +	nested git repositories.
>>  
>>  -n::
>>  --dry-run::
>> -- 
>> 1.8.0.2
>> 
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe git" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>

Soren Brinkmann· Dec 21, 2012, 17:09 UTC · re: Junio C Hamano · lore

Re: [PATCH] Documentation/git-clean: Document --force --force

On Thu, Dec 20, 2012 at 07:01:41PM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> Soren Brinkmann <soren.brinkmann@xilinx.com> writes:
> 
> > Ping?
> 
> I *think* it is a mistake for the command to remove a separate
> project repository within, with any number of "-f", so I'd rather
> see a patch to fix it, instead of casting such a misbehaviour as a
> feature in stone by documenting it.
> 
> I dunno.

Since I use this feature, I naturally have to disagree. But fair point. And with the patch rectifying git-clean output it's probably tolerable.

Though, what would be your way of cleaning files/dirs from a repository where git-clean will report to have some left undeleted? Manually calling rm -rf?

	Soren