threads / patch / 32333

patchFor git-subtree, when installing docs (make install-doc), create man1 folder first.

Subject: [PATCH] For git-subtree, when installing docs (make install-doc), create man1 folder first.

## tl;dr

4 messages between Dec 13, 2012 and Jan 1, 2013. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Jesper L. Nielsen· Dec 13, 2012, 20:09 UTC · lore

From: "Jesper L. Nielsen" <lyager@gmail.com>

Hi..

I installed Git subtree and discovered that the if the man1dir doesn't exist the man-page for Git Subtree is just called man1.

So, small patch to create the folder first in the Makefile. Hope everything is right with the patch and submitting of the patch.

Best Regards Jesper

Signed-off-by: Jesper L. Nielsen <lyager@gmail.com>
---
 contrib/subtree/Makefile | 1 +
 1 file changed, 1 insertion(+)

Show changes to contrib/subtree/Makefile +1 −0

diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
index 05cdd5c..a341cf4 100644
--- a/contrib/subtree/Makefile
+++ b/contrib/subtree/Makefile
@@ -35,6 +35,7 @@ install: $(GIT_SUBTREE)
 install-doc: install-man
 
 install-man: $(GIT_SUBTREE_DOC)
+	mkdir -p $(man1dir)
 	$(INSTALL) -m 644 $^ $(man1dir)
 
 $(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)

-- 
1.8.0.2

Junio C Hamano· Dec 15, 2012, 18:07 UTC · re: Jesper L. Nielsen · lore

Re: [PATCH] For git-subtree, when installing docs (make install-doc), create man1 folder first.

"Jesper L. Nielsen" <lyager@gmail.com> writes:

Show 15 quoted lines

> From: "Jesper L. Nielsen" <lyager@gmail.com>
>
> Hi..
>
> I installed Git subtree and discovered that the if the man1dir doesn't exist the man-page for Git Subtree is just called man1.
>
> So, small patch to create the folder first in the Makefile. Hope everything is right with the patch and submitting of the patch.
>
> Best Regards
> Jesper
>
> Signed-off-by: Jesper L. Nielsen <lyager@gmail.com>
> ---
>  contrib/subtree/Makefile | 1 +
>  1 file changed, 1 insertion(+)

This is a good first step in the right direction, I think.

Shouldn't the install targets take DESTDIR into account like the main Makefile does, though?

As to the patch submission, everything below "---" line looks sane, but please check how others write commit log messages by browsing a handful of entries in "git log --no-merges" output and notice the difference (the details are found in Documentation/SubmittingPatches).

Thanks.

Show 12 quoted lines

> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
> index 05cdd5c..a341cf4 100644
> --- a/contrib/subtree/Makefile
> +++ b/contrib/subtree/Makefile
> @@ -35,6 +35,7 @@ install: $(GIT_SUBTREE)
>  install-doc: install-man
>  
>  install-man: $(GIT_SUBTREE_DOC)
> +	mkdir -p $(man1dir)
>  	$(INSTALL) -m 644 $^ $(man1dir)
>  
>  $(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)

greened@obbligato.org· Jan 1, 2013, 03:06 UTC · re: Jesper L. Nielsen · lore

Re: [PATCH] For git-subtree, when installing docs (make install-doc), create man1 folder first.

"Jesper L. Nielsen" <lyager@gmail.com> writes:

> So, small patch to create the folder first in the Makefile. Hope
> everything is right with the patch and submitting of the patch.

I've applied this to my local copy and will send it to the list for integration.

Thanks for fixing this!

                         -David

greened@obbligato.org· Jan 1, 2013, 03:01 UTC · lore

Re: [PATCH] For git-subtree, when installing docs (make install-doc), create man1 folder first.

Junio C Hamano <gitster@pobox.com> writes:

Show 17 quoted lines

> "Jesper L. Nielsen" <lyager@gmail.com> writes:
>
>> From: "Jesper L. Nielsen" <lyager@gmail.com>
>>
>> Hi..
>>
>> I installed Git subtree and discovered that the if the man1dir doesn't exist the man-page for Git Subtree is just called man1.
>>
>> So, small patch to create the folder first in the Makefile. Hope everything is right with the patch and submitting of the patch.
>>
>> Best Regards
>> Jesper
>>
>> Signed-off-by: Jesper L. Nielsen <lyager@gmail.com>
>> ---
>
> Thanks.  David, Ack?

Yep. I can add it to my queue which I'll send to you tomorrow. Otherwise, feel free to apply it to your copy.

                               -David