# What's cooking in git.git (Nov 2012, #06; Mon, 19) 15 messages from 2012-11-19 to 2012-12-01. Participants: Junio C Hamano, Felipe Contreras, Paul Fox, Marc Branchaud, Jeff King, Adam Spiers. Thread: https://gitlist.dev/t/32149 ## Junio C Hamano, 2012-11-19 23:55 Subject: What's cooking in git.git (Nov 2012, #06; Mon, 19) Message-ID: <7vpq39up0m.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vpq39up0m.fsf%40alter.siamese.dyndns.org ``` Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. Bunch of topics have been merged to 'next'. We are at the beginning of the 5th week of this release cycle (cf. http://tinyurl.com/gitcal), and I've moved many topics to the Stalled category, which will be discarded without prejudice soonish unless there are some updates. I am still a bit behind on some topics and already posted rerolls may have to be pulled in. You can find the changes described here in the integration branches of the repositories listed at http://git-blame.blogspot.com/p/git-public-repositories.html -------------------------------------------------- [New Topics] * nd/pathspec-wildcard (2012-11-19) 4 commits - tree_entry_interesting: do basedir compare on wildcard patterns when possible - pathspec: apply "*.c" optimization from exclude - pathspec: do exact comparison on the leading non-wildcard part - pathspec: save the non-wildcard length part -------------------------------------------------- [Stalled] * pf/editor-ignore-sigint (2012-11-11) 5 commits - launch_editor: propagate SIGINT from editor to git - run-command: do not warn about child death by SIGINT - run-command: drop silent_exec_failure arg from wait_or_whine - launch_editor: ignore SIGINT while the editor has control - launch_editor: refactor to use start/finish_command Avoid confusing cases where the user hits Ctrl-C while in the editor session, not realizing git will receive the signal. Since most editors will take over the terminal and will block SIGINT, this is not likely to confuse anyone. Some people raised issues with emacsclient, which are addressed by this re-roll. It should probably also handle SIGQUIT, and there were a handful of other review comments. Expecting a re-roll. * pp/gitweb-config-underscore (2012-11-08) 1 commit - gitweb: make remote_heads config setting work The key "gitweb.remote_heads" is not legal git config; this maps it to "gitweb.remoteheads". Junio raised a good point about the implementation for three-level variables. Expecting a re-roll. * mo/cvs-server-updates (2012-10-16) 10 commits - cvsserver Documentation: new cvs ... -r support - cvsserver: add t9402 to test branch and tag refs - cvsserver: support -r and sticky tags for most operations - cvsserver: Add version awareness to argsfromdir - cvsserver: generalize getmeta() to recognize commit refs - cvsserver: implement req_Sticky and related utilities - cvsserver: add misc commit lookup, file meta data, and file listing functions - cvsserver: define a tag name character escape mechanism - cvsserver: cleanup extra slashes in filename arguments - cvsserver: factor out git-log parsing logic Needs review by folks interested in cvsserver. * jc/apply-trailing-blank-removal (2012-10-12) 1 commit - apply.c:update_pre_post_images(): the preimage can be truncated Fix to update_pre_post_images() that did not take into account the possibility that whitespace fix could shrink the preimage and change the number of lines in it. Extra set of eyeballs appreciated. * jn/warn-on-inaccessible-loosen (2012-10-14) 4 commits - config: exit on error accessing any config file - doc: advertise GIT_CONFIG_NOSYSTEM - config: treat user and xdg config permission problems as errors - config, gitignore: failure to access with ENOTDIR is ok An RFC to deal with a situation where .config/git is a file and we notice .config/git/config is not readable due to ENOTDIR, not ENOENT; I think a bit more refactored approach to consistently address permission errors across config, exclude and attrs is desirable. Don't we also need a check for an opposite situation where we open .config/git/config or .gitattributes for reading but they turn out to be directories? * as/check-ignore (2012-11-08) 14 commits - t0007: fix tests on Windows - Documentation/check-ignore: we show the deciding match, not the first - Add git-check-ignore sub-command - dir.c: provide free_directory() for reclaiming dir_struct memory - pathspec.c: move reusable code from builtin/add.c - dir.c: refactor treat_gitlinks() - dir.c: keep track of where patterns came from - dir.c: refactor is_path_excluded() - dir.c: refactor is_excluded() - dir.c: refactor is_excluded_from_list() - dir.c: rename excluded() to is_excluded() - dir.c: rename excluded_from_list() to is_excluded_from_list() - dir.c: rename path_excluded() to is_path_excluded() - dir.c: rename cryptic 'which' variable to more consistent name Duy helped to reroll this. Expecting a re-roll. * aw/rebase-am-failure-detection (2012-10-11) 1 commit - rebase: Handle cases where format-patch fails I am unhappy a bit about the possible performance implications of having to store the output in a temporary file only for a rare case of format-patch aborting. * jk/lua-hackery (2012-10-07) 6 commits - pretty: fix up one-off format_commit_message calls - Minimum compilation fixup - Makefile: make "lua" a bit more configurable - add a "lua" pretty format - add basic lua infrastructure - pretty: make some commit-parsing helpers more public Interesting exercise. When we do this for real, we probably would want to wrap a commit to make it more like an "object" with methods like "parents", etc. * fc/remote-testgit-feature-done (2012-10-29) 1 commit - remote-testgit: properly check for errors Is this still in "Needs review" state? Are poeple involved in the remote interface happy with this change? * jk/send-email-sender-prompt (2012-11-15) 8 commits - send-email: do not prompt for explicit repo ident - Git.pm: teach "ident" to query explicitness - var: provide explicit/implicit ident information - var: accept multiple variables on the command line - ident: keep separate "explicit" flags for author and committer - ident: make user_ident_explicitly_given static - t7502: factor out autoident prerequisite - test-lib: allow negation of prerequisites Avoid annoying sender prompt in git-send-email, but only when it is safe to do so. Perhaps keep only the first three patches, and replace the rest with the one from Felipe that takes a much simpler approach (the rationale of that patch needs to be cleaned up first, along the lines Jeff outlined, though). Frozen until that happens. * nd/unify-appending-of-s-o-b (2012-11-15) 1 commit - Unify appending signoff in format-patch, commit and sequencer I am not sure if the logic to refrain from adding a sign-off based on the existing run of sign-offs is done correctly in this change. * nd/pretty-placeholder-with-color-option (2012-09-30) 9 commits . pretty: support %>> that steal trailing spaces . pretty: support truncating in %>, %< and %>< . pretty: support padding placeholders, %< %> and %>< . pretty: two phase conversion for non utf-8 commits . utf8.c: add utf8_strnwidth() with the ability to skip ansi sequences . utf8.c: move display_mode_esc_sequence_len() for use by other functions . pretty: support %C(auto[,N]) to turn on coloring on next placeholder(s) . pretty: split parsing %C into a separate function . pretty: share code between format_decoration and show_decorations This causes warnings with -Wuninitialized, so I've ejected it from pu for the time being. * rc/maint-complete-git-p4 (2012-09-24) 1 commit (merged to 'next' on 2012-10-29 at af52cef) + Teach git-completion about git p4 Comment from Pete will need to be addressed in a follow-up patch. * as/test-tweaks (2012-09-20) 7 commits - tests: paint unexpectedly fixed known breakages in bold red - tests: test the test framework more thoroughly - [SQUASH] t/t0000-basic.sh: quoting of TEST_DIRECTORY is screwed up - tests: refactor mechanics of testing in a sub test-lib - tests: paint skipped tests in bold blue - tests: test number comes first in 'not ok $count - $message' - tests: paint known breakages in bold yellow Various minor tweaks to the test framework to paint its output lines in colors that match what they mean better. Has the "is this really blue?" issue Peff raised resolved??? * jc/maint-name-rev (2012-09-17) 7 commits - describe --contains: use "name-rev --algorithm=weight" - name-rev --algorithm=weight: tests and documentation - name-rev --algorithm=weight: cache the computed weight in notes - name-rev --algorithm=weight: trivial optimization - name-rev: --algorithm option - name_rev: clarify the logic to assign a new tip-name to a commit - name-rev: lose unnecessary typedef "git name-rev" names the given revision based on a ref that can be reached in the smallest number of steps from the rev, but that is not useful when the caller wants to know which tag is the oldest one that contains the rev. This teaches a new mode to the command that uses the oldest ref among those which contain the rev. I am not sure if this is worth it; for one thing, even with the help from notes-cache, it seems to make the "describe --contains" even slower. Also the command will be unusably slow for a user who does not have a write access (hence unable to create or update the notes-cache). Stalled mostly due to lack of responses. * jc/xprm-generation (2012-09-14) 1 commit - test-generation: compute generation numbers and clock skews A toy to analyze how bad the clock skews are in histories of real world projects. Stalled mostly due to lack of responses. * jc/blame-no-follow (2012-09-21) 2 commits - blame: pay attention to --no-follow - diff: accept --no-follow option Teaches "--no-follow" option to "git blame" to disable its whole-file rename detection. Stalled mostly due to lack of responses. * jc/doc-default-format (2012-10-07) 2 commits - [SQAUSH] allow "cd Doc* && make DEFAULT_DOC_TARGET=..." - Allow generating a non-default set of documentation Need to address the installation half if this is to be any useful. * mk/maint-graph-infinity-loop (2012-09-25) 1 commit - graph.c: infinite loop in git whatchanged --graph -m The --graph code fell into infinite loop when asked to do what the code did not expect ;-) Anybody who worked on "--graph" wants to comment? Stalled mostly due to lack of responses. * jc/add-delete-default (2012-08-13) 1 commit - git add: notice removal of tracked paths by default "git add dir/" updated modified files and added new files, but does not notice removed files, which may be "Huh?" to some users. They can of course use "git add -A dir/", but why should they? Resurrected from graveyard, as I thought it was a worthwhile thing to do in the longer term. Waiting for comments. * mb/remote-default-nn-origin (2012-07-11) 6 commits - Teach get_default_remote to respect remote.default. - Test that plain "git fetch" uses remote.default when on a detached HEAD. - Teach clone to set remote.default. - Teach "git remote" about remote.default. - Teach remote.c about the remote.default configuration setting. - Rename remote.c's default_remote_name static variables. When the user does not specify what remote to interact with, we often attempt to use 'origin'. This can now be customized via a configuration variable. Expecting a re-roll. "The first remote becomes the default" bit is better done as a separate step. * mh/ceiling (2012-10-29) 8 commits - string_list_longest_prefix(): remove function - setup_git_directory_gently_1(): resolve symlinks in ceiling paths - longest_ancestor_length(): require prefix list entries to be normalized - longest_ancestor_length(): take a string_list argument for prefixes - longest_ancestor_length(): use string_list_split() - Introduce new function real_path_if_valid() - real_path_internal(): add comment explaining use of cwd - Introduce new static function real_path_internal() Elements of GIT_CEILING_DIRECTORIES list may not match the real pathname we obtain from getcwd(), leading the GIT_DIR discovery logic to escape the ceilings the user thought to have specified. -------------------------------------------------- [Cooking] * jl/submodule-rm (2012-11-14) 1 commit (merged to 'next' on 2012-11-18 at bf4525d) + docs: move submodule section Documentation correction for d21240f (Merge branch 'jl/submodule-rm', 2012-10-29) that needs to be fast-tracked. Will merge to 'master' in the sixth batch. * sg/complete-help-undup (2012-11-14) 1 commit (merged to 'next' on 2012-11-18 at eadd0f3) + completion: remove 'help' duplicate from porcelain commands Will merge to 'master' in the seventh batch. * bc/do-not-recurse-in-die (2012-11-15) 1 commit (merged to 'next' on 2012-11-18 at 79d62a8) + usage.c: detect recursion in die routines and bail out immediately Will merge to 'master' in the seventh batch. * cn/config-missing-path (2012-11-15) 1 commit (merged to 'next' on 2012-11-18 at c08b73c) + config: don't segfault when given --path with a missing value Will merge to 'master' in the sixth batch. * jk/checkout-out-of-unborn (2012-11-15) 1 commit (merged to 'next' on 2012-11-18 at 7d2aa24) + checkout: print a message when switching unborn branches Will merge to 'master' in the sixth batch. * mk/complete-tcsh (2012-11-16) 1 commit (merged to 'next' on 2012-11-19 at 8309029) + tcsh-completion re-using git-completion.bash Will merge to 'master' in the seventh batch. * mm/status-push-pull-advise (2012-11-16) 1 commit - status: add advice on how to push/pull to tracking branch Will merge to 'next'. * jk/maint-gitweb-xss (2012-11-12) 1 commit (merged to 'next' on 2012-11-14 at 7a667bc) + gitweb: escape html in rss title Fixes an XSS vulnerability in gitweb. Will merge to 'master' in the sixth batch. * mg/replace-resolve-delete (2012-11-13) 1 commit (merged to 'next' on 2012-11-14 at fa785ae) + replace: parse revision argument for -d Be more user friendly to people using "git replace -d". Will merge to 'master' in the sixth batch. * ml/cygwin-mingw-headers (2012-11-18) 2 commits (merged to 'next' on 2012-11-19 at f9964da) + USE CGYWIN_V15_WIN32API as macro to select api for cygwin (merged to 'next' on 2012-11-15 at 22e11b3) + Update cygwin.c for new mingw-64 win32 api headers Make git work on newer cygwin. Will merge to 'master' in the sixth batch. * ta/doc-cleanup (2012-10-25) 6 commits (merged to 'next' on 2012-11-13 at e11fafd) + Documentation: build html for all files in technical and howto + Documentation/howto: convert plain text files to asciidoc + Documentation/technical: convert plain text files to asciidoc + Change headline of technical/send-pack-pipeline.txt to not confuse its content with content from git-send-pack.txt + Shorten two over-long lines in git-bisect-lk2009.txt by abbreviating some sha1 + Split over-long synopsis in git-fetch-pack.txt into several lines Will merge to 'master' in the sixth batch. * lt/diff-stat-show-0-lines (2012-10-17) 1 commit (merged to 'next' on 2012-11-19 at 0037290) + Fix "git diff --stat" for interesting - but empty - file changes We failed to mention a file without any content change but whose permission bit was modified, or (worse yet) a new file without any content in the "git diff --stat" output. Will merge to 'master' in the seventh batch. * fc/zsh-completion (2012-11-19) 2 commits - completion: start moving to the new zsh completion - completion: add new zsh completion Replaced by shedding large changes to other independent topics. Any comments from zsh users? * so/prompt-command (2012-10-17) 4 commits (merged to 'next' on 2012-10-25 at 79565a1) + coloured git-prompt: paint detached HEAD marker in red + Fix up colored git-prompt + show color hints based on state of the git tree + Allow __git_ps1 to be used in PROMPT_COMMAND Updates __git_ps1 so that it can be used as $PROMPT_COMMAND, instead of being used for command substitution in $PS1, to embed color escape sequences in its output. Will cook in 'next'. * nd/wildmatch (2012-10-15) 13 commits (merged to 'next' on 2012-10-25 at 510e8df) + Support "**" wildcard in .gitignore and .gitattributes + wildmatch: make /**/ match zero or more directories + wildmatch: adjust "**" behavior + wildmatch: fix case-insensitive matching + wildmatch: remove static variable force_lower_case + wildmatch: make wildmatch's return value compatible with fnmatch + t3070: disable unreliable fnmatch tests + Integrate wildmatch to git + wildmatch: follow Git's coding convention + wildmatch: remove unnecessary functions + Import wildmatch from rsync + ctype: support iscntrl, ispunct, isxdigit and isprint + ctype: make sane_ctype[] const array Allows pathname patterns in .gitignore and .gitattributes files with double-asterisks "foo/**/bar" to match any number of directory hierarchies. I suspect that this needs to be plugged to pathspec matching code; otherwise "git log -- 'Docum*/**/*.txt'" would not show the log for commits that touch Documentation/git.txt, which would be confusing to the users. Will cook in 'next'. * jh/update-ref-d-through-symref (2012-10-21) 2 commits (merged to 'next' on 2012-11-19 at 6bcca4c) + Fix failure to delete a packed ref through a symref + t1400-update-ref: Add test verifying bug with symrefs in delete_ref() "update-ref -d --deref SYM" to delete a ref through a symbolic ref that points to it did not remove it correctly. Will merge to 'master' in the seventh batch. * jk/config-ignore-duplicates (2012-10-29) 9 commits (merged to 'next' on 2012-10-29 at 67fa0a2) + builtin/config.c: Fix a sparse warning (merged to 'next' on 2012-10-25 at 233df08) + git-config: use git_config_with_options + git-config: do not complain about duplicate entries + git-config: collect values instead of immediately printing + git-config: fix regexp memory leaks on error conditions + git-config: remove memory leak of key regexp + t1300: test "git config --get-all" more thoroughly + t1300: remove redundant test + t1300: style updates Drop duplicate detection from git-config; this lets it better match the internal config callbacks, which clears up some corner cases with includes. Will merge to 'master' in the sixth batch. * fc/completion-test-simplification (2012-11-16) 6 commits - completion: simplify __gitcomp() test helper - completion: refactor __gitcomp related tests - completion: consolidate test_completion*() tests - completion: simplify tests using test_completion_long() - completion: standardize final space marker in tests - completion: add comment for test_completion() Clean up completion tests. Use of conslidated helper may make instrumenting one particular test during debugging of the test itself, but I think that issue should be addressed in some other way (e.g. making sure individual tests in 9902 can be skipped). * jk/pickaxe-textconv (2012-10-28) 2 commits - pickaxe: use textconv for -S counting - pickaxe: hoist empty needle check Use textconv filters when searching with "log -S". It probably should lose "are the textconv on the two sides the same?" check. * fc/remote-bzr (2012-11-08) 5 commits (merged to 'next' on 2012-11-18 at 86add07) + remote-bzr: update working tree + remote-bzr: add support for remote repositories + remote-bzr: add support for pushing + remote-bzr: add simple tests + Add new remote-bzr transport helper New remote helper for bzr. Will merge to 'master' in the seventh batch. * fc/remote-hg (2012-11-12) 20 commits (merged to 'next' on 2012-11-18 at 4a4f2e4) + remote-hg: avoid bad refs + remote-hg: try the 'tip' if no checkout present + remote-hg: fix compatibility with older versions of hg + remote-hg: add missing config for basic tests + remote-hg: the author email can be null + remote-hg: add option to not track branches + remote-hg: add extra author test + remote-hg: add tests to compare with hg-git + remote-hg: add bidirectional tests + test-lib: avoid full path to store test results + remote-hg: add basic tests + remote-hg: fake bookmark when there's none + remote-hg: add compat for hg-git author fixes + remote-hg: add support for hg-git compat mode + remote-hg: match hg merge behavior + remote-hg: make sure the encoding is correct + remote-hg: add support to push URLs + remote-hg: add support for remote pushing + remote-hg: add support for pushing + Add new remote-hg transport helper New remote helper for hg. Will merge to 'master' in the seventh batch. * jk/maint-http-half-auth-fetch (2012-10-31) 2 commits (merged to 'next' on 2012-11-09 at af69926) + remote-curl: retry failed requests for auth even with gzip + remote-curl: hoist gzip buffer size to top of post_rpc Fixes fetch from servers that ask for auth only during the actual packing phase. This is not really a recommended configuration, but it cleans up the code at the same time. Will merge to 'master' in the sixth batch. * kb/preload-index-more (2012-11-02) 1 commit (merged to 'next' on 2012-11-09 at a750ebd) + update-index/diff-index: use core.preloadindex to improve performance Use preloadindex in more places, which has a nice speedup on systems with slow stat calls (and even on Linux). Will merge to 'master' in the sixth batch. * cr/push-force-tag-update (2012-11-19) 5 commits - push: update remote tags only with force - push: flag updates that require force - push: keep track of "update" state separately - push: add advice for rejected tag reference - push: return reject reasons via a mask Require "-f" for push to update a tag, even if it is a fast-forward. * fc/fast-export-fixes (2012-11-08) 14 commits - fast-export: don't handle uninteresting refs - fast-export: make sure updated refs get updated - fast-export: fix comparison in tests - fast-export: trivial cleanup - remote-testgit: make clear the 'done' feature - remote-testgit: report success after an import - remote-testgit: exercise more features - remote-testgit: cleanup tests - remote-testgit: remove irrelevant test - remote-testgit: get rid of non-local functionality - Add new simplified git-remote-testgit - Rename git-remote-testgit to git-remote-testpy - remote-testgit: fix direction of marks - fast-export: avoid importing blob marks Improvements to fix fast-export bugs, including how refs pointing to already-seen commits are handled. An earlier 4-commit version of this series looked good to me, but this much-expanded version has not seen any comments. Looks like it has been re-rolled, but I haven't checked it out yet. Needs review. * mh/alt-odb-string-list-cleanup (2012-11-08) 2 commits (merged to 'next' on 2012-11-13 at 2bf41d9) + link_alt_odb_entries(): take (char *, len) rather than two pointers + link_alt_odb_entries(): use string_list_split_in_place() Cleanups in the alternates code. Fixes a potential bug and makes the code much cleaner. Will merge to 'master' in the sixth batch. * pw/maint-p4-rcs-expansion-newline (2012-11-08) 1 commit (merged to 'next' on 2012-11-13 at e90cc7c) + git p4: RCS expansion should not span newlines I do not have p4 to play with, but looks obviously correct to me. Will merge to 'master' in the sixth batch. * rh/maint-gitweb-highlight-ext (2012-11-08) 1 commit (merged to 'next' on 2012-11-13 at c57d856) + gitweb.perl: fix %highlight_ext mappings Fixes a clever misuse of perl's list interpretation. Will merge to 'master' in the sixth batch. * rr/submodule-diff-config (2012-11-18) 4 commits (merged to 'next' on 2012-11-19 at 355319e) + submodule: display summary header in bold + diff: rename "set" variable + diff: introduce diff.submodule configuration variable + Documentation: move diff.wordRegex from config.txt to diff-config.txt Lets "git diff --submodule=log" become the default via configuration. Will merge to 'master' in the seventh batch. ``` ## Felipe Contreras, 2012-11-20 01:41 Subject: Re: What's cooking in git.git (Nov 2012, #06; Mon, 19) Message-ID: URL: https://gitlist.dev/e/CAMP44s3xW1qMzNmZm6-c0bXaREut6TDJoRBZ5mu%3DHWndSgYCyg%40mail.gmail.com In-Reply-To: <7vpq39up0m.fsf@alter.siamese.dyndns.org> ``` On Tue, Nov 20, 2012 at 12:55 AM, Junio C Hamano wrote: > * fc/remote-testgit-feature-done (2012-10-29) 1 commit > - remote-testgit: properly check for errors Pinging Sverre again. I now think that we need a better solution with waitpid() to check the status of the process, so that both import and export get proper error checks. I found that out the hard way with a buggy remote helper. I still think this patch is good regardless, but not so big of a priority. I'm not going to purse it more, if it gets in, good, if not, a waitpid() patch would take care of it. Cheers. -- Felipe Contreras ``` ## Paul Fox, 2012-11-20 11:59 Subject: Re: What's cooking in git.git (Nov 2012, #06; Mon, 19) Message-ID: <20121120115923.746252E9301@grass.foxharp.boston.ma.us> URL: https://gitlist.dev/e/20121120115923.746252E9301%40grass.foxharp.boston.ma.us In-Reply-To: <7vpq39up0m.fsf@alter.siamese.dyndns.org> ``` junio c hamano wrote: > [Stalled] > > * pf/editor-ignore-sigint (2012-11-11) 5 commits > - launch_editor: propagate SIGINT from editor to git > - run-command: do not warn about child death by SIGINT > - run-command: drop silent_exec_failure arg from wait_or_whine > - launch_editor: ignore SIGINT while the editor has control > - launch_editor: refactor to use start/finish_command > > Avoid confusing cases where the user hits Ctrl-C while in the editor > session, not realizing git will receive the signal. Since most editors > will take over the terminal and will block SIGINT, this is not likely > to confuse anyone. > > Some people raised issues with emacsclient, which are addressed by this > re-roll. It should probably also handle SIGQUIT, and there were a > handful of other review comments. > > Expecting a re-roll. i don't have strong feelings on any of the later review comments (though i guess the check on finish_command()'s return code needed attention), and wasn't the last submitter, but would certainly like to see this move forward. paul =--------------------- paul fox, pgf@foxharp.boston.ma.us (arlington, ma, where it's 26.1 degrees) ``` ## Junio C Hamano, 2012-11-20 23:50 Subject: Re: What's cooking in git.git (Nov 2012, #06; Mon, 19) Message-ID: <7vy5hvq1ey.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vy5hvq1ey.fsf%40alter.siamese.dyndns.org In-Reply-To: <7vpq39up0m.fsf@alter.siamese.dyndns.org> ``` Junio C Hamano writes: > Here are the topics that have been cooking. Commits prefixed with > '-' are only in 'pu' (proposed updates) while commits prefixed with > '+' are in 'next'. > > Bunch of topics have been merged to 'next'. > > We are at the beginning of the 5th week of this release cycle > (cf. http://tinyurl.com/gitcal), and I've moved many topics to the > Stalled category, which will be discarded without prejudice soonish > unless there are some updates. I am still a bit behind on some > topics and already posted rerolls may have to be pulled in. It feels a bit too busy/loud to issue two "What's cooking" in a row, so here is an informal update. - The following have graduated to 'master'. cn/config-missing-path jk/checkout-out-of-unborn jk/maint-gitweb-xss jk/maint-http-half-auth-fetch jl/submodule-rm kb/preload-index-more mg/replace-resolve-delete mh/alt-odb-string-list-cleanup ml/cygwin-mingw-headers pw/maint-p4-rcs-expansion-newline rh/maint-gitweb-highlight-ext ta/doc-cleanup - Many topics have been merged to 'maint' in preparation for 1.8.0.1. mg/maint-pull-suggest-upstream-to mm/maint-doc-commit-edit as/maint-doc-fix-no-post-rewrite rs/lock-correct-ref-during-delete rf/maint-mailmap-off-by-one jk/maint-diff-grep-textconv js/format-2047 sz/maint-curl-multi-timeout po/maint-refs-replace-docs ph/pull-rebase-detached mm/maint-doc-remote-tracking rs/branch-del-symref nd/grep-true-path jc/grep-pcre-loose-ends (early part) da/mergetools-p4 jc/test-say-color-avoid-echo-escape bw/config-lift-variable-name-length-limit - A few topics have been resurrected from the stalled category to cooking: pp/gitweb-config-underscore jc/apply-trailing-blank-removal ``` ## Junio C Hamano, 2012-11-21 00:05 Subject: Topics currently in the Stalled category Message-ID: <7vobirq0q2.fsf_-_@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vobirq0q2.fsf_-_%40alter.siamese.dyndns.org In-Reply-To: <7vy5hvq1ey.fsf@alter.siamese.dyndns.org> ``` Here is a list of stalled topics I am having trouble deciding what to do (the default is to dismiss them around feature freeze). * fc/fast-export-fixes (2012-11-08) 14 commits Renaming of remote-testgit feels to be a mistake. It probably should keep its source in remote-testgit.bash and generate it, and moreover, if it wants to rename remote-testgit.py to remote-testpy, the new one should be called remote-testbash. There was one reroll after what used to be queued, but nobody seemed to be interested in reviewing the series. This mostly happened while I was away, and judging from the discussion around this topic (and earlier iterations), I do not feel comfortable merging this series (or v5 reroll) as-is. Help? * pf/editor-ignore-sigint (2012-11-11) 5 commits Avoid confusing cases where the user hits Ctrl-C while in the editor session, not realizing git will receive the signal. Since most editors will take over the terminal and will block SIGINT, this is not likely to confuse anyone. Some people raised issues with emacsclient, which are addressed by this re-roll. It should probably also handle SIGQUIT, and there were a handful of other review comments. Anybody interested in moving this forward? * mo/cvs-server-updates (2012-10-16) 10 commits - cvsserver Documentation: new cvs ... -r support - cvsserver: add t9402 to test branch and tag refs - cvsserver: support -r and sticky tags for most operations - cvsserver: Add version awareness to argsfromdir - cvsserver: generalize getmeta() to recognize commit refs - cvsserver: implement req_Sticky and related utilities - cvsserver: add misc commit lookup, file meta data, and file listing functions - cvsserver: define a tag name character escape mechanism - cvsserver: cleanup extra slashes in filename arguments - cvsserver: factor out git-log parsing logic Needs review by folks interested in cvsserver. * jn/warn-on-inaccessible-loosen (2012-10-14) 4 commits - config: exit on error accessing any config file - doc: advertise GIT_CONFIG_NOSYSTEM - config: treat user and xdg config permission problems as errors - config, gitignore: failure to access with ENOTDIR is ok An RFC to deal with a situation where .config/git is a file and we notice .config/git/config is not readable due to ENOTDIR, not ENOENT; I think a bit more refactored approach to consistently address permission errors across config, exclude and attrs may be desirable. Should we merge this as-is and build on top? What are the chances of potential regressions? * as/check-ignore (2012-11-08) 14 commits - t0007: fix tests on Windows - Documentation/check-ignore: we show the deciding match, not the first - Add git-check-ignore sub-command - dir.c: provide free_directory() for reclaiming dir_struct memory - pathspec.c: move reusable code from builtin/add.c - dir.c: refactor treat_gitlinks() - dir.c: keep track of where patterns came from - dir.c: refactor is_path_excluded() - dir.c: refactor is_excluded() - dir.c: refactor is_excluded_from_list() - dir.c: rename excluded() to is_excluded() - dir.c: rename excluded_from_list() to is_excluded_from_list() - dir.c: rename path_excluded() to is_path_excluded() - dir.c: rename cryptic 'which' variable to more consistent name Duy helped to reroll this, but it seems that there weren't any activity since then during my absense. * fc/remote-testgit-feature-done (2012-10-29) 1 commit - remote-testgit: properly check for errors Is this still in "Needs review" state? Are people involved in the remote interface happy with this change? * jk/send-email-sender-prompt (2012-11-15) 8 commits - send-email: do not prompt for explicit repo ident - Git.pm: teach "ident" to query explicitness - var: provide explicit/implicit ident information - var: accept multiple variables on the command line - ident: keep separate "explicit" flags for author and committer - ident: make user_ident_explicitly_given static - t7502: factor out autoident prerequisite - test-lib: allow negation of prerequisites Avoid annoying sender prompt in git-send-email, but only when it is safe to do so. Perhaps keep only the first three patches, and replace the rest with the one from Felipe that takes a much simpler approach (the rationale of that patch needs to be cleaned up first, along the lines Jeff outlined, though). Frozen until that happens. * nd/unify-appending-of-s-o-b (2012-11-15) 1 commit - Unify appending signoff in format-patch, commit and sequencer I am not sure if the logic to refrain from adding a sign-off based on the existing run of sign-offs is done correctly in this change. * rc/maint-complete-git-p4 (2012-09-24) 1 commit (merged to 'next' on 2012-10-29 at af52cef) + Teach git-completion about git p4 Comment from Pete will need to be addressed in a follow-up patch. * as/test-tweaks (2012-09-20) 7 commits - tests: paint unexpectedly fixed known breakages in bold red - tests: test the test framework more thoroughly - [SQUASH] t/t0000-basic.sh: quoting of TEST_DIRECTORY is screwed up - tests: refactor mechanics of testing in a sub test-lib - tests: paint skipped tests in bold blue - tests: test number comes first in 'not ok $count - $message' - tests: paint known breakages in bold yellow Various minor tweaks to the test framework to paint its output lines in colors that match what they mean better. Has the "is this really blue?" issue Peff raised resolved??? * mk/maint-graph-infinity-loop (2012-09-25) 1 commit - graph.c: infinite loop in git whatchanged --graph -m The --graph code fell into infinite loop when asked to do what the code did not expect ;-) Anybody who worked on "--graph" wants to comment? Stalled mostly due to lack of responses. * mb/remote-default-nn-origin (2012-07-11) 6 commits - Teach get_default_remote to respect remote.default. - Test that plain "git fetch" uses remote.default when on a detached HEAD. - Teach clone to set remote.default. - Teach "git remote" about remote.default. - Teach remote.c about the remote.default configuration setting. - Rename remote.c's default_remote_name static variables. When the user does not specify what remote to interact with, we often attempt to use 'origin'. This can now be customized via a configuration variable. Expecting a re-roll. "The first remote becomes the default" bit is better done as a separate step. * mh/ceiling (2012-10-29) 8 commits - string_list_longest_prefix(): remove function - setup_git_directory_gently_1(): resolve symlinks in ceiling paths - longest_ancestor_length(): require prefix list entries to be normalized - longest_ancestor_length(): take a string_list argument for prefixes - longest_ancestor_length(): use string_list_split() - Introduce new function real_path_if_valid() - real_path_internal(): add comment explaining use of cwd - Introduce new static function real_path_internal() Elements of GIT_CEILING_DIRECTORIES list may not match the real pathname we obtain from getcwd(), leading the GIT_DIR discovery logic to escape the ceilings the user thought to have specified. I think the fear that this would regress the intended use case of the environment variable turned out to be unfounded during the discussion. Should we merge this as-is to 'next', cook for a while to make sure nobody screams? Thanks. ``` ## Felipe Contreras, 2012-11-21 03:31 Subject: Re: Topics currently in the Stalled category Message-ID: URL: https://gitlist.dev/e/CAMP44s30cbH5%2BHUxRBByk5sZGq%3Dj_MdqLSnNzREozEk40_zbOw%40mail.gmail.com In-Reply-To: <7vobirq0q2.fsf_-_@alter.siamese.dyndns.org> ``` On Wed, Nov 21, 2012 at 1:05 AM, Junio C Hamano wrote: > Here is a list of stalled topics I am having trouble deciding what > to do (the default is to dismiss them around feature freeze). > > * fc/fast-export-fixes (2012-11-08) 14 commits > > Renaming of remote-testgit feels to be a mistake. It probably > should keep its source in remote-testgit.bash and generate it, Why generate it? There's nothing to generate. python's source code needs regeneration, bash's code doesn't. > and > moreover, if it wants to rename remote-testgit.py to remote-testpy, > the new one should be called remote-testbash. No, remote-testbash is not testing anything that is specific to bash, it's testing the remote helper framework itself. It could be written in Ruby, or Python, or C, or anything. remote-testgit.py is *not* testing the remote helper framework, it's testing the Python-specific remote helper framework. IOW. remote-testgit tests this: transport-helper.c remote-testpy tests this: git_remote_helpers/Makefile git_remote_helpers/__init__.py git_remote_helpers/git/__init__.py git_remote_helpers/git/exporter.py git_remote_helpers/git/git.py git_remote_helpers/git/importer.py git_remote_helpers/git/non_local.py git_remote_helpers/git/repo.py git_remote_helpers/setup.cfg git_remote_helpers/setup.py git_remote_helpers/util.py Cheers. -- Felipe Contreras ``` ## Marc Branchaud, 2012-11-21 14:55 Subject: Re: Topics currently in the Stalled category Message-ID: <50ACEB50.2060107@xiplink.com> URL: https://gitlist.dev/e/50ACEB50.2060107%40xiplink.com In-Reply-To: <7vobirq0q2.fsf_-_@alter.siamese.dyndns.org> ``` On 12-11-20 07:05 PM, Junio C Hamano wrote: > Here is a list of stalled topics I am having trouble deciding what > to do (the default is to dismiss them around feature freeze). > [ snip ] > > * mb/remote-default-nn-origin (2012-07-11) 6 commits > - Teach get_default_remote to respect remote.default. > - Test that plain "git fetch" uses remote.default when on a detached HEAD. > - Teach clone to set remote.default. > - Teach "git remote" about remote.default. > - Teach remote.c about the remote.default configuration setting. > - Rename remote.c's default_remote_name static variables. > > When the user does not specify what remote to interact with, we > often attempt to use 'origin'. This can now be customized via a > configuration variable. > > Expecting a re-roll. > > "The first remote becomes the default" bit is better done as a > separate step. This is still on my list of things to do soon. Unfortunately "soon" seems to be rather perpetual these days. If you're tired of carrying the branch feel free to dismiss it and I'll resurrect the topic when "soon" finally comes around. M. ``` ## Jeff King, 2012-11-28 02:59 Subject: Re: Topics currently in the Stalled category Message-ID: <20121128025928.GA27772@sigill.intra.peff.net> URL: https://gitlist.dev/e/20121128025928.GA27772%40sigill.intra.peff.net In-Reply-To: ``` On Wed, Nov 21, 2012 at 04:31:11AM +0100, Felipe Contreras wrote: > On Wed, Nov 21, 2012 at 1:05 AM, Junio C Hamano wrote: > > Here is a list of stalled topics I am having trouble deciding what > > to do (the default is to dismiss them around feature freeze). > > > > * fc/fast-export-fixes (2012-11-08) 14 commits > > > > Renaming of remote-testgit feels to be a mistake. It probably > > should keep its source in remote-testgit.bash and generate it, > > Why generate it? There's nothing to generate. python's source code > needs regeneration, bash's code doesn't. We fix up the #!-lines on all of the existing shell scripts (as well as python and perl). Wouldn't we want to do the same for people who have bash in an alternate location? As the series is now, people with bash in their PATH, but not in /bin/bash, will fail t5801 (the prereq to skip the test uses "type", but git-remote-testgit hardcodes /bin/bash). -Peff ``` ## Felipe Contreras, 2012-11-28 03:10 Subject: Re: Topics currently in the Stalled category Message-ID: URL: https://gitlist.dev/e/CAMP44s3F4MPm-kLAW67rZG8oZg76CGS32h44LnK05UT11TOnSA%40mail.gmail.com In-Reply-To: <20121128025928.GA27772@sigill.intra.peff.net> ``` On Wed, Nov 28, 2012 at 3:59 AM, Jeff King wrote: > On Wed, Nov 21, 2012 at 04:31:11AM +0100, Felipe Contreras wrote: > >> On Wed, Nov 21, 2012 at 1:05 AM, Junio C Hamano wrote: >> > Here is a list of stalled topics I am having trouble deciding what >> > to do (the default is to dismiss them around feature freeze). >> > >> > * fc/fast-export-fixes (2012-11-08) 14 commits >> > >> > Renaming of remote-testgit feels to be a mistake. It probably >> > should keep its source in remote-testgit.bash and generate it, >> >> Why generate it? There's nothing to generate. python's source code >> needs regeneration, bash's code doesn't. > > We fix up the #!-lines on all of the existing shell scripts (as well as > python and perl). Wouldn't we want to do the same for people who have > bash in an alternate location? '#!/usr/bin/env bash' should take care of people who have bash in an alternate location, no? -- Felipe Contreras ``` ## Jeff King, 2012-11-28 03:11 Subject: Re: Topics currently in the Stalled category Message-ID: <20121128031118.GB27772@sigill.intra.peff.net> URL: https://gitlist.dev/e/20121128031118.GB27772%40sigill.intra.peff.net In-Reply-To: <20121128025928.GA27772@sigill.intra.peff.net> ``` On Tue, Nov 27, 2012 at 09:59:28PM -0500, Jeff King wrote: > > > Renaming of remote-testgit feels to be a mistake. It probably > > > should keep its source in remote-testgit.bash and generate it, > > > > Why generate it? There's nothing to generate. python's source code > > needs regeneration, bash's code doesn't. > > We fix up the #!-lines on all of the existing shell scripts (as well as > python and perl). Wouldn't we want to do the same for people who have > bash in an alternate location? > > As the series is now, people with bash in their PATH, but not in > /bin/bash, will fail t5801 (the prereq to skip the test uses "type", but > git-remote-testgit hardcodes /bin/bash). We could improve the test in t5801, but it is nice to let people on such systems test it, as well. And the infrastructure might be useful if we ever acquire more bash scripts. There's a fair bit of boilerplate, but I think this squashable patch would do it: diff --git a/.gitignore b/.gitignore index 46595db..3b636bd 100644 --- a/.gitignore +++ b/.gitignore @@ -124,6 +124,7 @@ /git-remote-ftps /git-remote-fd /git-remote-ext +/git-remote-testgit /git-remote-testsvn /git-remote-testpy /git-repack diff --git a/Makefile b/Makefile index 68f1ac2..19f6fd2 100644 --- a/Makefile +++ b/Makefile @@ -424,6 +424,7 @@ PROGRAM_OBJS = PROGRAMS = SCRIPT_PERL = SCRIPT_PYTHON = +SCRIPT_BASH = SCRIPT_SH = SCRIPT_LIB = TEST_PROGRAMS_NEED_X = @@ -473,9 +474,12 @@ SCRIPT_PERL += git-svn.perl SCRIPT_PYTHON += git-remote-testpy.py SCRIPT_PYTHON += git-p4.py +SCRIPT_BASH += git-remote-testgit.bash + SCRIPTS = $(patsubst %.sh,%,$(SCRIPT_SH)) \ $(patsubst %.perl,%,$(SCRIPT_PERL)) \ $(patsubst %.py,%,$(SCRIPT_PYTHON)) \ + $(patsubst %.bash,%,$(SCRIPT_BASH)) \ git-instaweb ETAGS_TARGET = TAGS @@ -571,9 +575,13 @@ endif ifndef PYTHON_PATH PYTHON_PATH = /usr/bin/python endif +ifndef BASH_PATH + BASH_PATH = /bin/bash +endif export PERL_PATH export PYTHON_PATH +export BASH_PATH LIB_FILE=libgit.a XDIFF_LIB=xdiff/lib.a @@ -1931,6 +1939,10 @@ ifeq ($(PYTHON_PATH),) NO_PYTHON=NoThanks endif +ifeq ($(BASH_PATH),) +NO_BASH=NoThanks +endif + QUIET_SUBDIR0 = +$(MAKE) -C # space to separate -C and subdir QUIET_SUBDIR1 = @@ -2006,6 +2018,7 @@ gitwebdir_SQ = $(subst ','\'',$(gitwebdir)) SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH)) PERL_PATH_SQ = $(subst ','\'',$(PERL_PATH)) PYTHON_PATH_SQ = $(subst ','\'',$(PYTHON_PATH)) +BASH_PATH_SQ = $(subst ','\'',$(BASH_PATH)) TCLTK_PATH_SQ = $(subst ','\'',$(TCLTK_PATH)) DIFF_SQ = $(subst ','\'',$(DIFF)) @@ -2267,6 +2280,15 @@ $(patsubst %.py,%,$(SCRIPT_PYTHON)): % : unimplemented.sh mv $@+ $@ endif # NO_PYTHON +ifndef NO_BASH +$(patsubst %.bash,%,$(SCRIPT_BASH)): + $(QUIET_GEN)$(RM) $@ $@+ && \ + sed -e '1s|#!.*/bash|#!$(BASH_PATH_SQ)|' \ + $@.bash >$@+ && \ + chmod +x $@+ && \ + mv $@+ $@ +endif + configure: configure.ac GIT-VERSION-FILE $(QUIET_GEN)$(RM) $@ $<+ && \ sed -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \ @@ -2599,6 +2621,7 @@ GIT-BUILD-OPTIONS: FORCE @echo USE_LIBPCRE=\''$(subst ','\'',$(subst ','\'',$(USE_LIBPCRE)))'\' >>$@ @echo NO_PERL=\''$(subst ','\'',$(subst ','\'',$(NO_PERL)))'\' >>$@ @echo NO_PYTHON=\''$(subst ','\'',$(subst ','\'',$(NO_PYTHON)))'\' >>$@ + @echo NO_BASH=\''$(subst ','\'',$(subst ','\'',$(NO_BASH)))'\' >>$@ @echo NO_UNIX_SOCKETS=\''$(subst ','\'',$(subst ','\'',$(NO_UNIX_SOCKETS)))'\' >>$@ ifdef GIT_TEST_OPTS @echo GIT_TEST_OPTS=\''$(subst ','\'',$(subst ','\'',$(GIT_TEST_OPTS)))'\' >>$@ diff --git a/git-remote-testgit b/git-remote-testgit.bash similarity index 100% rename from git-remote-testgit rename to git-remote-testgit.bash diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh index 456303b..d6ebc5e 100755 --- a/t/t5801-remote-helpers.sh +++ b/t/t5801-remote-helpers.sh @@ -7,7 +7,7 @@ test_description='Test remote-helper import and export commands' . ./test-lib.sh -if ! type "${BASH-bash}" >/dev/null 2>&1; then +if ! test_have_prereq BASH; then skip_all='skipping remote-testgit tests, bash not available' test_done fi diff --git a/t/test-lib.sh b/t/test-lib.sh index 489bc80..5300fa9 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -675,6 +675,7 @@ esac ( COLUMNS=1 && test $COLUMNS = 1 ) && test_set_prereq COLUMNS_CAN_BE_1 test -z "$NO_PERL" && test_set_prereq PERL test -z "$NO_PYTHON" && test_set_prereq PYTHON +test -z "$NO_BASH" && test_set_prereq BASH test -n "$USE_LIBPCRE" && test_set_prereq LIBPCRE test -z "$NO_GETTEXT" && test_set_prereq GETTEXT ``` ## Jeff King, 2012-11-28 03:12 Subject: Re: Topics currently in the Stalled category Message-ID: <20121128031238.GC27772@sigill.intra.peff.net> URL: https://gitlist.dev/e/20121128031238.GC27772%40sigill.intra.peff.net In-Reply-To: ``` On Wed, Nov 28, 2012 at 04:10:07AM +0100, Felipe Contreras wrote: > >> Why generate it? There's nothing to generate. python's source code > >> needs regeneration, bash's code doesn't. > > > > We fix up the #!-lines on all of the existing shell scripts (as well as > > python and perl). Wouldn't we want to do the same for people who have > > bash in an alternate location? > > '#!/usr/bin/env bash' should take care of people who have bash in an > alternate location, no? If that is where there env is. I do not recall offhand if that is a problem for anyone. Still, I don't think it is that big a deal to treat it like we do other scripts, and provide the usual boilerplate (which also gets us NO_BASH if you have an old or broken bash and want to skip the tests). I just sent a patch. -Peff ``` ## Felipe Contreras, 2012-11-28 03:15 Subject: Re: Topics currently in the Stalled category Message-ID: URL: https://gitlist.dev/e/CAMP44s3ZtCNsedJtsHDJx5d4Myjbbp%2BD6yT-rO-CmKOTtt91VQ%40mail.gmail.com In-Reply-To: <20121128031118.GB27772@sigill.intra.peff.net> ``` On Wed, Nov 28, 2012 at 4:11 AM, Jeff King wrote: > On Tue, Nov 27, 2012 at 09:59:28PM -0500, Jeff King wrote: > >> > > Renaming of remote-testgit feels to be a mistake. It probably >> > > should keep its source in remote-testgit.bash and generate it, >> > >> > Why generate it? There's nothing to generate. python's source code >> > needs regeneration, bash's code doesn't. >> >> We fix up the #!-lines on all of the existing shell scripts (as well as >> python and perl). Wouldn't we want to do the same for people who have >> bash in an alternate location? >> >> As the series is now, people with bash in their PATH, but not in >> /bin/bash, will fail t5801 (the prereq to skip the test uses "type", but >> git-remote-testgit hardcodes /bin/bash). > > We could improve the test in t5801, but it is nice to let people on such > systems test it, as well. And the infrastructure might be useful if we > ever acquire more bash scripts. > > There's a fair bit of boilerplate, but I think this squashable patch > would do it: Yeah, but I wonder what's the point of installing this script, it's mostly for testing and reference, and to add a whole category for that seems like overkill. Cheers. -- Felipe Contreras ``` ## Jeff King, 2012-11-28 03:22 Subject: Re: Topics currently in the Stalled category Message-ID: <20121128032245.GD27772@sigill.intra.peff.net> URL: https://gitlist.dev/e/20121128032245.GD27772%40sigill.intra.peff.net In-Reply-To: ``` On Wed, Nov 28, 2012 at 04:15:12AM +0100, Felipe Contreras wrote: > > We could improve the test in t5801, but it is nice to let people on such > > systems test it, as well. And the infrastructure might be useful if we > > ever acquire more bash scripts. > > > > There's a fair bit of boilerplate, but I think this squashable patch > > would do it: > > Yeah, but I wonder what's the point of installing this script, it's > mostly for testing and reference, and to add a whole category for that > seems like overkill. There's no point in installing it; I just didn't make the effort to avoid doing so (note that testpy and testsvn are also installed, which are in the same boat; it might make sense to split them all out like we do for $TEST_PROGRAMS). I agree it's an annoying amount of boilerplate, but it seems simpler cognitively to me for it to behave as the other SCRIPT_* builds than to do something simple but inconsistent. I do not care enough to argue about it. We need to do something to fix the impending test breakage on systems like Solaris. I have posted the patch to handle BASH_PATH, so do what you want. -Peff ``` ## Felipe Contreras, 2012-11-28 03:33 Subject: Re: Topics currently in the Stalled category Message-ID: URL: https://gitlist.dev/e/CAMP44s2Cw-Vr0pEi7vOYx3aPxrKWZNpRxx%2BDjjtejndsC0P7Bw%40mail.gmail.com In-Reply-To: <20121128032245.GD27772@sigill.intra.peff.net> ``` On Wed, Nov 28, 2012 at 4:22 AM, Jeff King wrote: > On Wed, Nov 28, 2012 at 04:15:12AM +0100, Felipe Contreras wrote: > >> > We could improve the test in t5801, but it is nice to let people on such >> > systems test it, as well. And the infrastructure might be useful if we >> > ever acquire more bash scripts. >> > >> > There's a fair bit of boilerplate, but I think this squashable patch >> > would do it: >> >> Yeah, but I wonder what's the point of installing this script, it's >> mostly for testing and reference, and to add a whole category for that >> seems like overkill. > > There's no point in installing it; I just didn't make the effort to > avoid doing so (note that testpy and testsvn are also installed, which > are in the same boat; it might make sense to split them all out like we > do for $TEST_PROGRAMS). > > I agree it's an annoying amount of boilerplate, but it seems simpler > cognitively to me for it to behave as the other SCRIPT_* builds than to > do something simple but inconsistent. > > I do not care enough to argue about it. We need to do something to fix > the impending test breakage on systems like Solaris. I have posted the > patch to handle BASH_PATH, so do what you want. I'm not objecting to the change, I'm simply wondering. Personally I think switching to '/usr/bin/env bash' should be enough for now. Doing a grep on my git installation throws this: % grep '/usr/bin/env' -r /opt/git /opt/git/lib/python2.7/site-packages/git_remote_helpers/git/git.py:#!/usr/bin/env python /opt/git/lib/python2.7/site-packages/git_remote_helpers/__init__.py:#!/usr/bin/env python /opt/git/lib/python2.7/site-packages/git_remote_helpers/util.py:#!/usr/bin/env python /opt/git/libexec/git-core/git-instaweb:#!/usr/bin/env ruby So it's doubtful a lack of /usr/bin/env would cause any more breakages than it already does for test-git. And this just landed on 'pu', I don't think there's anything big impending. If the /usr/bin/env solution turned out to be not enough for some reason, we can deal with it then. That's my opinion. Cheers. -- Felipe Contreras ``` ## Adam Spiers, 2012-12-01 00:36 Subject: Re: Topics currently in the Stalled category Message-ID: URL: https://gitlist.dev/e/CAOkDyE-dq%2BL0Gd4T%3D8oUeQ4OHE0hgmK4AfUhYgBo0uzq9TrrYw%40mail.gmail.com In-Reply-To: <7vobirq0q2.fsf_-_@alter.siamese.dyndns.org> ``` On Wed, Nov 21, 2012 at 12:05 AM, Junio C Hamano wrote: > Here is a list of stalled topics I am having trouble deciding what > to do (the default is to dismiss them around feature freeze). [snipped] > * as/check-ignore (2012-11-08) 14 commits > - t0007: fix tests on Windows > - Documentation/check-ignore: we show the deciding match, not the first > - Add git-check-ignore sub-command > - dir.c: provide free_directory() for reclaiming dir_struct memory > - pathspec.c: move reusable code from builtin/add.c > - dir.c: refactor treat_gitlinks() > - dir.c: keep track of where patterns came from > - dir.c: refactor is_path_excluded() > - dir.c: refactor is_excluded() > - dir.c: refactor is_excluded_from_list() > - dir.c: rename excluded() to is_excluded() > - dir.c: rename excluded_from_list() to is_excluded_from_list() > - dir.c: rename path_excluded() to is_path_excluded() > - dir.c: rename cryptic 'which' variable to more consistent name > > Duy helped to reroll this, but it seems that there weren't any > activity since then during my absense. I have been delayed several times, but I finally resumed work on another re-roll. I don't think there is any major reworking required; just a number of small tweaks. > * as/test-tweaks (2012-09-20) 7 commits > - tests: paint unexpectedly fixed known breakages in bold red > - tests: test the test framework more thoroughly > - [SQUASH] t/t0000-basic.sh: quoting of TEST_DIRECTORY is screwed up > - tests: refactor mechanics of testing in a sub test-lib > - tests: paint skipped tests in bold blue > - tests: test number comes first in 'not ok $count - $message' > - tests: paint known breakages in bold yellow > > Various minor tweaks to the test framework to paint its output > lines in colors that match what they mean better. > > Has the "is this really blue?" issue Peff raised resolved??? I have a re-roll of this ready - just need to rebase to latest master, do a final sanity check, and then send. Sorry again for the delays. ```