# [PATCH 0/5] win32: support echo for terminal-prompt 2 messages from 2012-11-13 to 2012-11-13. Participants: Erik Faye-Lund. Thread: https://gitlist.dev/t/32096 ## Erik Faye-Lund, 2012-11-13 14:01 Subject: [PATCH 0/5] win32: support echo for terminal-prompt Message-ID: <1352815288-3996-1-git-send-email-kusmabite@gmail.com> URL: https://gitlist.dev/e/1352815288-3996-1-git-send-email-kusmabite%40gmail.com ``` We currently only support getpass, which does not echo at all, for git_terminal_prompt on Windows. The Windows console is perfectly capable of doing this, so let's make it so. This implementation tries to reuse the /dev/tty-code as much as possible. The big reason that this becomes a bit hairy is that Ctrl+C needs to be handled correctly, so we don't leak the console state to a non-echoing setting when a user aborts. Windows makes this bit a little bit tricky, in that we need to implement SIGINT for fgetc. However, I suspect that this is a good thing to do in the first place. An earlier iteration was also breifly discussed here: http://mid.gmane.org/CABPQNSaUCEDU4+2N63n0k_XwSXOP_iFZG3GEYSPSBPcSVV8wRQ@mail.gmail.com The series can also be found here, only with an extra patch that makes the (interactive) testing a bit easier: https://github.com/kusma/git/tree/work/terminal-cleanup Erik Faye-Lund (5): mingw: make fgetc raise SIGINT if apropriate compat/terminal: factor out echo-disabling compat/terminal: separate input and output handles mingw: reuse tty-version of git_terminal_prompt mingw: get rid of getpass implementation compat/mingw.c | 91 +++++++++++++++++++++++++++----------- compat/mingw.h | 8 +++- compat/terminal.c | 129 ++++++++++++++++++++++++++++++++++++++++-------------- 3 files changed, 169 insertions(+), 59 deletions(-) -- 1.8.0.7.gbeffeda -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en ``` ## Erik Faye-Lund, 2012-11-13 14:04 Subject: Re: [PATCH 0/5] win32: support echo for terminal-prompt Message-ID: URL: https://gitlist.dev/e/CABPQNSZe%3DoWEb-_orsGx1XFJh%3DsT3JpFVbOOwc%3D4%3DAgy9LreWg%40mail.gmail.com In-Reply-To: <1352815288-3996-1-git-send-email-kusmabite@gmail.com> ``` Sorry, I messed up the subject (lacking RFC-prefix), so I aborted after sending the cover-letter. I'll resend with a proper prefix right away. On Tue, Nov 13, 2012 at 3:01 PM, Erik Faye-Lund wrote: > We currently only support getpass, which does not echo at all, for > git_terminal_prompt on Windows. The Windows console is perfectly > capable of doing this, so let's make it so. > > This implementation tries to reuse the /dev/tty-code as much as > possible. > > The big reason that this becomes a bit hairy is that Ctrl+C needs > to be handled correctly, so we don't leak the console state to a > non-echoing setting when a user aborts. > > Windows makes this bit a little bit tricky, in that we need to > implement SIGINT for fgetc. However, I suspect that this is a good > thing to do in the first place. > > An earlier iteration was also breifly discussed here: > http://mid.gmane.org/CABPQNSaUCEDU4+2N63n0k_XwSXOP_iFZG3GEYSPSBPcSVV8wRQ@mail.gmail.com > > The series can also be found here, only with an extra patch that > makes the (interactive) testing a bit easier: > > https://github.com/kusma/git/tree/work/terminal-cleanup > > Erik Faye-Lund (5): > mingw: make fgetc raise SIGINT if apropriate > compat/terminal: factor out echo-disabling > compat/terminal: separate input and output handles > mingw: reuse tty-version of git_terminal_prompt > mingw: get rid of getpass implementation > > compat/mingw.c | 91 +++++++++++++++++++++++++++----------- > compat/mingw.h | 8 +++- > compat/terminal.c | 129 ++++++++++++++++++++++++++++++++++++++++-------------- > 3 files changed, 169 insertions(+), 59 deletions(-) > > -- > 1.8.0.7.gbeffeda > -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en ```