threads / patch / 32070

patchcompletion: use more proper emulation for zsh

Subject: [PATCH try3] completion: use more proper emulation for zsh

## tl;dr

One message between Nov 11, 2012 and Nov 11, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Felipe Contreras· Nov 11, 2012, 13:51 UTC · lore

It turns out there's no 'bash' emulation in zsh. Anything that starts with a 'b' is mapped to the 'sh' emulation, presumably because of _b_ourne shell.

kzh emulation seems closer to bash, and at least I haven't had problems with this.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
This is the third time I send this patch.
 contrib/completion/git-completion.bash | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Show changes to contrib/completion/git-completion.bash +1 −2
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index be800e0..d7439a5 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2432,8 +2432,7 @@ __gitk_main ()
 __git_func_wrap ()
 {
 	if [[ -n ${ZSH_VERSION-} ]]; then
-		emulate -L bash
-		setopt KSH_TYPESET
+		emulate -L ksh
 
 		# workaround zsh's bug that leaves 'words' as a special
 		# variable in versions < 4.3.12
-- 
1.8.0

← back to recent threads