threads / discuss / 32057

overriding/removing inherited credential.helper

Subject: overriding/removing inherited credential.helper

## tl;dr

4 messages between Nov 10, 2012 and Feb 7, 2013.

replies: 3people: 3as markdown or json

乙酸鋰· Nov 10, 2012, 15:12 UTC · lore
In credential.c, line 67:
    if (!strcmp(key, "helper"))
        string_list_append(&c->helpers, value);

In global config, I add one credential helper. But I do not want to use any credential helper in a specific repository. Currently there is no way in local config to override and remove inherited credential helper. Of course, I do not want to change global config.

Could you suggest a patch?
Ted Zlatanov· Feb 7, 2013, 14:36 UTC · re: 乙酸鋰 · lore

Re: overriding/removing inherited credential.helper, Do not add an empty value from config credential.helper

On Sat, 10 Nov 2012 23:12:50 +0800 乙酸鋰 <ch3cooli@gmail.com> wrote: 
> In credential.c, line 67:
>     if (!strcmp(key, "helper"))
>	  string_list_append(&c->helpers, value);
Show 5 quoted lines
> In global config, I add one credential helper.
> But I do not want to use any credential helper in a specific repository.
> Currently there is no way in local config to override and remove
> inherited credential helper.
> Of course, I do not want to change global config.
> Could you suggest a patch?
On Sat, 10 Nov 2012 23:08:04 +0800 乙酸鋰 <ch3cooli@gmail.com> wrote: 
> Below is current git message when a local config credential.helper has
> an empty value. Please skip an empty value.
> $ git push --force origin master
> git: 'credential-' is not a git command. See 'git --help'.
Show 5 quoted lines
> Did you mean this?
>	  credential
> Total 0 (delta 0), reused 0 (delta 0)
> To https://user@github.com/user/myrepo.git
>  + d23aa6a...3405990 master -> master (forced update)

I would like that too (needed it today). Maybe the empty string (as suggested) or "none" could be acceptable.

"none" seems friendlier and is very unlikely to collide with an actual credential helper.

Ted
Junio C Hamano· Feb 7, 2013, 18:23 UTC · re: Ted Zlatanov · lore

Re: overriding/removing inherited credential.helper, Do not add an empty value from config credential.helper

Ted Zlatanov <tzz@lifelogs.com> writes:
Show 7 quoted lines
>> Below is current git message when a local config credential.helper has
>> an empty value. Please skip an empty value.
>
>> $ git push --force origin master
>> git: 'credential-' is not a git command. See 'git --help'.
>> Did you mean this?
>>	  credential

Why isn't "do not add empty string, or any random string that ends up referring to a helper that you do not have" a solution?

Show 6 quoted lines
>> Total 0 (delta 0), reused 0 (delta 0)
>> To https://user@github.com/user/myrepo.git
>>  + d23aa6a...3405990 master -> master (forced update)
>
> I would like that too (needed it today).  Maybe the empty string (as
> suggested) or "none" could be acceptable.
Whatever you do, I do not think introducing a per-variable hack
	[credential]
        	helper = none ;# or "helper = clear"
                helper = mine ;# this is the only thing I use

like that is a sane way to go. "Clear everything you saw so far" would be useful for variables other than "credential.helper"; shouldn't it be done by adding a general syntax to the configuration file format and teach the configuration parser to clear the cumulative definitions so far?

Ted Zlatanov· Feb 7, 2013, 18:38 UTC · re: Junio C Hamano · lore

Re: overriding/removing inherited credential.helper, Do not add an empty value from config credential.helper

On Thu, 07 Feb 2013 10:23:20 -0800 Junio C Hamano <gitster@pobox.com> wrote:

JCH> "Clear everything you saw so far" would be useful for variables JCH> other than "credential.helper"; shouldn't it be done by adding a JCH> general syntax to the configuration file format and teach the JCH> configuration parser to clear the cumulative definitions so far?

That's a question for the configuration parser, right? I don't have an informed opinion on how it should be implemented, and am OK with any syntax to clear a variable.

Ted

← back to recent threads