# [PATCH] Use local structs for HTTP slot callback data 1 messages from 2006-02-01 to 2006-02-01. Participants: Nick Hengeveld. Thread: https://gitlist.dev/t/3204 ## Nick Hengeveld, 2006-02-01 02:00 Subject: [PATCH] Use local structs for HTTP slot callback data Message-ID: <20060201020037.GG3873@reactrix.com> URL: https://gitlist.dev/e/20060201020037.GG3873%40reactrix.com ``` There's no need for these structures to be static, and it could potentially cause problems down the road. Signed-off-by: Nick Hengeveld --- http-fetch.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) 6146f9e8be9d4bb49b7008af5b99853ee7c0afc1 diff --git a/http-fetch.c b/http-fetch.c index 92326f9..97ce13c 100644 --- a/http-fetch.c +++ b/http-fetch.c @@ -375,7 +375,7 @@ static int fetch_index(struct alt_base * FILE *indexfile; struct active_request_slot *slot; - static struct slot_results results; + struct slot_results results; if (has_pack_index(sha1)) return 0; @@ -555,7 +555,7 @@ static void fetch_alternates(char *base) char *url; char *data; struct active_request_slot *slot; - static struct alternates_request alt_req; + struct alternates_request alt_req; /* If another request has already started fetching alternates, wait for them to arrive and return to processing this request's @@ -618,7 +618,7 @@ static int fetch_indices(struct alt_base int i = 0; struct active_request_slot *slot; - static struct slot_results results; + struct slot_results results; if (repo->got_indices) return 0; @@ -699,7 +699,7 @@ static int fetch_pack(struct alt_base *r struct curl_slist *range_header = NULL; struct active_request_slot *slot; - static struct slot_results results; + struct slot_results results; if (fetch_indices(repo)) return -1; @@ -900,7 +900,7 @@ int fetch_ref(char *ref, unsigned char * struct buffer buffer; char *base = alt->base; struct active_request_slot *slot; - static struct slot_results results; + struct slot_results results; buffer.size = 41; buffer.posn = 0; buffer.buffer = hex; -- 1.1.6.g1417-dirty ```