# [PATCH] Fix t9200 on case insensitive file systems 4 messages from 2012-10-26 to 2012-10-28. Participants: Torsten Bögershausen, Ben Walton, Jeff King. Thread: https://gitlist.dev/t/31952 ## Torsten Bögershausen, 2012-10-26 16:18 Subject: [PATCH] Fix t9200 on case insensitive file systems Message-ID: <201210261818.25620.tboegi@web.de> URL: https://gitlist.dev/e/201210261818.25620.tboegi%40web.de ``` t9200 defines $CVSROOT where cvs should init its repository $CVSROOT is set to $PWD/cvsroot. cvs init is supposed to create the repository inside $PWD/cvsroot/CVSROOT "cvs init" (e.g. version 1.11.23) checks if the last element of the path is "CVSROOT", and if a directory with e.g. $PWD/cvsroot/CVSROOT already exists. For such a $CVSROOT cvs refuses to init a repository here: "Cannot initialize repository under existing CVSROOT: On a case insenstive file system cvsroot and CVSROOT are the same directories and t9200 fails. Solution: use $PWD/tmp/cvsroot instead of cvsroot $PWD/cvsroot Signed-off-by: Torsten Bögershausen --- t/t9200-git-cvsexportcommit.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh index b59be9a..69934b2 100755 --- a/t/t9200-git-cvsexportcommit.sh +++ b/t/t9200-git-cvsexportcommit.sh @@ -19,7 +19,7 @@ then test_done fi -CVSROOT=$PWD/cvsroot +CVSROOT=$PWD/tmpcvsroot CVSWORK=$PWD/cvswork GIT_DIR=$PWD/.git export CVSROOT CVSWORK GIT_DIR -- 1.7.12 ``` ## Ben Walton, 2012-10-27 21:36 Subject: Re: [PATCH] Fix t9200 on case insensitive file systems Message-ID: URL: https://gitlist.dev/e/CAP30j160xHL%2BN%3Dv_%3Dc%3D6gvLTYynB9oPSNuTHu_NCYz71%3DYNyfQ%40mail.gmail.com In-Reply-To: <201210261818.25620.tboegi@web.de> ``` On Fri, Oct 26, 2012 at 5:18 PM, Torsten Bögershausen wrote: > t/t9200-git-cvsexportcommit.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh > index b59be9a..69934b2 100755 > --- a/t/t9200-git-cvsexportcommit.sh > +++ b/t/t9200-git-cvsexportcommit.sh > @@ -19,7 +19,7 @@ then > test_done > fi > > -CVSROOT=$PWD/cvsroot > +CVSROOT=$PWD/tmpcvsroot FWIW, this looks obviously correct given the code snippet from the cvs version you shared the other day. Thanks -Ben -- --------------------------------------------------------------------------------------------------------------------------- Take the risk of thinking for yourself. Much more happiness, truth, beauty and wisdom will come to you that way. -Christopher Hitchens --------------------------------------------------------------------------------------------------------------------------- ``` ## Jeff King, 2012-10-28 11:10 Subject: Re: [PATCH] Fix t9200 on case insensitive file systems Message-ID: <20121028111053.GC11434@sigill.intra.peff.net> URL: https://gitlist.dev/e/20121028111053.GC11434%40sigill.intra.peff.net In-Reply-To: <201210261818.25620.tboegi@web.de> ``` On Fri, Oct 26, 2012 at 06:18:24PM +0200, Torsten Bögershausen wrote: > t9200 defines $CVSROOT where cvs should init its repository > $CVSROOT is set to $PWD/cvsroot. > cvs init is supposed to create the repository inside $PWD/cvsroot/CVSROOT > > "cvs init" (e.g. version 1.11.23) checks if the last element of the path is > "CVSROOT", and if a directory with e.g. $PWD/cvsroot/CVSROOT already exists. > > For such a $CVSROOT cvs refuses to init a repository here: > "Cannot initialize repository under existing CVSROOT: > > On a case insenstive file system cvsroot and CVSROOT are the same directories > and t9200 fails. > > Solution: use $PWD/tmp/cvsroot instead of cvsroot $PWD/cvsroot Wouldn't tmp/cvsroot have the same problem, since the basename is still cvsroot? > diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh > index b59be9a..69934b2 100755 > --- a/t/t9200-git-cvsexportcommit.sh > +++ b/t/t9200-git-cvsexportcommit.sh > @@ -19,7 +19,7 @@ then > test_done > fi > > -CVSROOT=$PWD/cvsroot > +CVSROOT=$PWD/tmpcvsroot Ah, but here you do something different, which makes sense. Should I tweak the commit message? -Peff ``` ## Torsten Bögershausen, 2012-10-28 15:28 Subject: Re: [PATCH] Fix t9200 on case insensitive file systems Message-ID: <508D4F13.1090209@web.de> URL: https://gitlist.dev/e/508D4F13.1090209%40web.de In-Reply-To: <20121028111053.GC11434@sigill.intra.peff.net> ``` On 28.10.12 12:10, Jeff King wrote: > On Fri, Oct 26, 2012 at 06:18:24PM +0200, Torsten Bögershausen wrote: > >> t9200 defines $CVSROOT where cvs should init its repository >> $CVSROOT is set to $PWD/cvsroot. >> cvs init is supposed to create the repository inside $PWD/cvsroot/CVSROOT >> >> "cvs init" (e.g. version 1.11.23) checks if the last element of the path is >> "CVSROOT", and if a directory with e.g. $PWD/cvsroot/CVSROOT already exists. >> >> For such a $CVSROOT cvs refuses to init a repository here: >> "Cannot initialize repository under existing CVSROOT: >> >> On a case insenstive file system cvsroot and CVSROOT are the same directories >> and t9200 fails. >> >> Solution: use $PWD/tmp/cvsroot instead of cvsroot $PWD/cvsroot > > Wouldn't tmp/cvsroot have the same problem, since the basename is still > cvsroot? > >> diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh >> index b59be9a..69934b2 100755 >> --- a/t/t9200-git-cvsexportcommit.sh >> +++ b/t/t9200-git-cvsexportcommit.sh >> @@ -19,7 +19,7 @@ then >> test_done >> fi >> >> -CVSROOT=$PWD/cvsroot >> +CVSROOT=$PWD/tmpcvsroot > > Ah, but here you do something different, which makes sense. Should I > tweak the commit message? > Yes, please do so. Thanks for spotting, /torsten ```