# diff support for the Eiffel language? 4 messages from 2012-10-22 to 2012-11-27. Participants: Ulrich Windl, Ævar Arnfjörð Bjarmason, Johannes Sixt. Thread: https://gitlist.dev/t/31895 ## Ulrich Windl, 2012-10-22 11:58 Subject: diff support for the Eiffel language? Message-ID: <508550E8020000A10000CF36@gwsmtp1.uni-regensburg.de> URL: https://gitlist.dev/e/508550E8020000A10000CF36%40gwsmtp1.uni-regensburg.de ``` Hi! After a longer pause, I did some programming in Eiffel again, and while doing so, why not use Git? It works! However there's one little thing I noticed with "git diff": The conte4xt lines (staring with "@@") show the current function (in Perl and C), but they show the current "feature clause" in Eiffel (as opposed to the expected current feature). I wonder how hard it is to fix it (Observed in git 1.7.7 of openSUSE 12.1). For the non-Eiffelists: Eiffel has a class structure like this: class FOO feature {BAR} -- This is a "feature clause", grouping related features (attributes/routines) baz (x,y : INTEGER) : STRING is -- blabla... do ... end -- baz end -- class FOO --- Now if I change something inside "baz", it would be nice if the @@-contect line would show "baz" (or more) instead of "feature {BAR}...". Regards, Ulrich P.S. Apologies if the feature requested had been added already. ``` ## Ævar Arnfjörð Bjarmason, 2012-10-22 13:06 Subject: Re: diff support for the Eiffel language? Message-ID: URL: https://gitlist.dev/e/CACBZZX4wF8C_9ok%2BzeTfO70BgZXufvQaJ%2B8B5EiOAmxvVwr54g%40mail.gmail.com In-Reply-To: <508550E8020000A10000CF36@gwsmtp1.uni-regensburg.de> ``` On Mon, Oct 22, 2012 at 1:58 PM, Ulrich Windl wrote: > However there's one little thing I noticed with "git diff": > The conte4xt lines (staring with "@@") show the current function (in Perl and C), but they show the current "feature clause" in Eiffel (as opposed to the expected current feature). I wonder how hard it is to fix it (Observed in git 1.7.7 of openSUSE 12.1). See git.git's e90d065 for an example of adding a new diff pattern. You could easily come up with a patch and send it to the list, however it would probably be good to CC some Eiffel language list in case there's some syntax oddities you've missed. ``` ## Johannes Sixt, 2012-10-22 13:35 Subject: Re: diff support for the Eiffel language? Message-ID: <50854B90.50807@viscovery.net> URL: https://gitlist.dev/e/50854B90.50807%40viscovery.net In-Reply-To: ``` Am 10/22/2012 15:06, schrieb Ævar Arnfjörð Bjarmason: > On Mon, Oct 22, 2012 at 1:58 PM, Ulrich Windl > wrote: >> However there's one little thing I noticed with "git diff": The >> conte4xt lines (staring with "@@") show the current function (in Perl >> and C), but they show the current "feature clause" in Eiffel (as >> opposed to the expected current feature). I wonder how hard it is to >> fix it (Observed in git 1.7.7 of openSUSE 12.1). > > See git.git's e90d065 for an example of adding a new diff pattern. It's not necessary to wait until there is built-in support for a new language. For example, for Windows resource files, I have *.rc diff=winres in .gitattributes or .git/info/attributes and [diff "winres"] xfuncname = "!^(BEGIN|END|FONT|CAPTION|STYLE)\n^[a-zA-Z_][a-zA-Z_0-9]*.*\n^[[:space:]]*([[:alnum:]_]+, *DIALOG.*)" in .git/config (the xfuncname is all on a single line). The first part beginning at ! up to \n tells to ignore the specified matches. The other parts separated by \n tell the things to put in the hunk header. You can have "ignore" parts (with exlamation mark) and "take this" parts (without) in any order that is convenient, as long as the last one is "take this". -- Hannes ``` ## Ulrich Windl, 2012-11-27 11:16 Subject: Antw: Re: diff support for the Eiffel language? Message-ID: <50B4AF12020000A10000DA1F@gwsmtp1.uni-regensburg.de> URL: https://gitlist.dev/e/50B4AF12020000A10000DA1F%40gwsmtp1.uni-regensburg.de In-Reply-To: <50854B90.50807@viscovery.net> ``` Hi! I managed to have some success, although it's not perfect. Unfortunately the Eiffel grammar does not allow a 100% solution. Example: --- local x : BOOLEAN --- declares a local variable named `x', while --- x : BOOLEAN do ... end --- Declares a function named `x'. Formal generic parameters like `x : ARRAY[ARRAY[STRING]]' make things more complicate. Anyway, here's my solution (probably incomplete): --- % git config --local -e [diff "Eiffel"] xfuncname = "!^[[:space:]]*(check|class|[Cc]reate|else|elseif|end|ensure|do|!|feature|from|indexing|inherit|is|local|loop|note|require|then|until)[[:space:]]*\n\ ^[[:space:]]*(class[[:space:]]*[[:alpha:]_][[:alnum:]_]*)\n\ ^[[:space:]]*([[:alpha:]_][[:alnum:]_]*[[:space:]]*\\([^(\")]+:[^(\")]+\\)[[:space:]]*:[[:space:]*[[:alpha:]_][[:alnum:]_]*[[:space:]]*[^[:space:]\"]?[^\"=]*)[[:space:]]*$\n\ ^[[:space:]]*([[:alpha:]_][[:alnum:]_]*[[:space:]]*\\([^(\")]+:[^(\")]+\\))[[:space:]]*$\n\ ^[[:space:]]*([[:alpha:]_][[:alnum:]_]*[[:space:]]*:[[:space:]*[[:alpha:]_][[:alnum:]_]*[[:space:]]*[^[:space:]\"]?[^\"=]*)[[:space:]]*$\n\ ^[[:space:]]*([[:alpha:]_][[:alnum:]_]*)[[:space:]]*$" % cat .git/info/attributes *.e diff=Eiffel --- Regards, Ulrich >>> Johannes Sixt schrieb am 22.10.2012 um 15:35 in Nachricht <50854B90.50807@viscovery.net>: > Am 10/22/2012 15:06, schrieb Ævar Arnfjörð Bjarmason: > > On Mon, Oct 22, 2012 at 1:58 PM, Ulrich Windl > > wrote: > >> However there's one little thing I noticed with "git diff": The > >> conte4xt lines (staring with "@@") show the current function (in Perl > >> and C), but they show the current "feature clause" in Eiffel (as > >> opposed to the expected current feature). I wonder how hard it is to > >> fix it (Observed in git 1.7.7 of openSUSE 12.1). > > > > See git.git's e90d065 for an example of adding a new diff pattern. > > It's not necessary to wait until there is built-in support for a new > language. > > For example, for Windows resource files, I have > > *.rc diff=winres > > in .gitattributes or .git/info/attributes and > > [diff "winres"] > xfuncname = > "!^(BEGIN|END|FONT|CAPTION|STYLE)\n^[a-zA-Z_][a-zA-Z_0-9]*.*\n^[[:space:]]*( > [[:alnum:]_]+, > *DIALOG.*)" > > in .git/config (the xfuncname is all on a single line). The first part > beginning at ! up to \n tells to ignore the specified matches. The other > parts separated by \n tell the things to put in the hunk header. You can > have "ignore" parts (with exlamation mark) and "take this" parts (without) > in any order that is convenient, as long as the last one is "take this". > > -- Hannes > ```