# [PATCH] t0003-attributes.sh: Don't overwrite t/.gitattributes 2 messages from 2012-10-13 to 2012-10-14. Participants: Ramsay Jones, Nguyen Thai Ngoc Duy. Thread: https://gitlist.dev/t/31802 ## Ramsay Jones, 2012-10-13 17:44 Subject: [PATCH] t0003-attributes.sh: Don't overwrite t/.gitattributes Message-ID: <5079A881.7010802@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/5079A881.7010802%40ramsay1.demon.co.uk ``` Signed-off-by: Ramsay Jones --- Hi Junio, This test in the current pu branch (commit bb0e6bf "Merge branch 'aw/rebase-am-failure-detection' into pu", 11-10-2012) overwrites the contents of t/.gitattributes. Note that the merge of the two branches 'nd/wildmatch' and 'nd/attr-match-optim-more' both add new tests at the end, and *both* sets initially 'cd ..' ... ATB, Ramsay Jones t/t0003-attributes.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh index 7ed288f..fe80af7 100755 --- a/t/t0003-attributes.sh +++ b/t/t0003-attributes.sh @@ -247,7 +247,6 @@ test_expect_success 'patterns starting with exclamation' ' ' test_expect_success '"**" test' ' - cd .. && echo "**/f foo=bar" >.gitattributes && cat <<\EOF >expect && f: foo: bar -- 1.7.12 ``` ## Nguyen Thai Ngoc Duy, 2012-10-14 02:37 Subject: Re: [PATCH] t0003-attributes.sh: Don't overwrite t/.gitattributes Message-ID: URL: https://gitlist.dev/e/CACsJy8B0n8O74pXMqbzEjSuoJSuWd%3DMW%2BzZJakTZ5z6WhVMWng%40mail.gmail.com In-Reply-To: <5079A881.7010802@ramsay1.demon.co.uk> ``` On Sun, Oct 14, 2012 at 12:44 AM, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > Hi Junio, > > This test in the current pu branch (commit bb0e6bf "Merge branch > 'aw/rebase-am-failure-detection' into pu", 11-10-2012) overwrites > the contents of t/.gitattributes. Note that the merge of the two > branches 'nd/wildmatch' and 'nd/attr-match-optim-more' both add > new tests at the end, and *both* sets initially 'cd ..' ... I'm resending nd/wildmatch to move the tests before bare repo tests so "cd .." is no longer necessary. nd/attr-match-optim-more has the same fix. > t/t0003-attributes.sh | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh > index 7ed288f..fe80af7 100755 > --- a/t/t0003-attributes.sh > +++ b/t/t0003-attributes.sh > @@ -247,7 +247,6 @@ test_expect_success 'patterns starting with exclamation' ' > ' > > test_expect_success '"**" test' ' > - cd .. && > echo "**/f foo=bar" >.gitattributes && > cat <<\EOF >expect && > f: foo: bar > -- > 1.7.12 > -- Duy ```