# [PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH 4 messages from 2012-10-09 to 2012-10-09. Participants: Øyvind A. Holm, Stefano Lattarini. Thread: https://gitlist.dev/t/31768 ## Øyvind A. Holm, 2012-10-09 16:36 Subject: [PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH Message-ID: <1349800572-2963-1-git-send-email-sunny@sunbase.org> URL: https://gitlist.dev/e/1349800572-2963-1-git-send-email-sunny%40sunbase.org In-Reply-To: <1349800026-10717-1-git-send-email-sunny@sunbase.org> ``` From: "Øyvind A. Holm" 40bfbde ("build: don't duplicate substitution of make variables", 2012-09-11) breaks make by removing a necessary comma at the end of "CC_LD_DYNPATH=-rpath" in line 414 and 423. When executing "./configure --with-zlib=PATH", this resulted in [...] CC xdiff/xhistogram.o AR xdiff/lib.a LINK git-credential-store /usr/bin/ld: bad -rpath option collect2: ld returned 1 exit status make: *** [git-credential-store] Error 1 $ during make. Signed-off-by: Øyvind A. Holm --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index da1f41f..ea79ea2 100644 --- a/configure.ac +++ b/configure.ac @@ -411,7 +411,7 @@ else LDFLAGS="${SAVE_LDFLAGS}" ]) if test "$git_cv_ld_wl_rpath" = "yes"; then - CC_LD_DYNPATH=-Wl,-rpath + CC_LD_DYNPATH=-Wl,-rpath, else AC_CACHE_CHECK([if linker supports -rpath], git_cv_ld_rpath, [ SAVE_LDFLAGS="${LDFLAGS}" @@ -420,7 +420,7 @@ else LDFLAGS="${SAVE_LDFLAGS}" ]) if test "$git_cv_ld_rpath" = "yes"; then - CC_LD_DYNPATH=-rpath + CC_LD_DYNPATH=-rpath, else CC_LD_DYNPATH= AC_MSG_WARN([linker does not support runtime path to dynamic libraries]) -- 1.8.0.rc1 ``` ## Øyvind A. Holm, 2012-10-09 16:40 Subject: Re: [PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH Message-ID: URL: https://gitlist.dev/e/CAA787rmpTe1L4TY41X9Szt8FS9T7bYRA2sgb%3DK_st4Ck2N9M1Q%40mail.gmail.com In-Reply-To: <1349800572-2963-1-git-send-email-sunny@sunbase.org> ``` Please discard the first patch, I reckon line 423 also should be changed. Sorry about the noise, Øyvind ``` ## Øyvind A. Holm, 2012-10-09 17:23 Subject: Re: [PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH Message-ID: URL: https://gitlist.dev/e/CAA787rnXw2fR5DG5bhz9uF4ub8%3DjZgUvpJLVGJ5sGXGSF8VMEQ%40mail.gmail.com In-Reply-To: <7v4nm3h8yr.fsf@alter.siamese.dyndns.org> ``` On 9 October 2012 19:05, Junio C Hamano wrote: > Øyvind A. Holm writes: > > 40bfbde ("build: don't duplicate substitution of make variables", > > 2012-09-11) breaks make by removing a necessary comma at the end of > > "CC_LD_DYNPATH=-rpath" in line 414 and 423. > > The earlier one is a cut-and-paste-error regression. > > Isn't the one at line 423 from before 40bfbde, though? If that is the > case, I'm a bit hesitant to take that part of this patch without a > second opinion. It looks like it is, yes. More accurately, from 798a945 way back in 2008. If it hasn't caused any trouble since then, it probably won't. :) The line was changed in 40bfbde, though, but AC_SUBST doesn't contain a comma, so to be on the safe side, the first patch should be used. But I made a minor copy+paste error in the commit message of that patch: "CC_LD_DYNPATH=-rpath" in line 414. should be "CC_LD_DYNPATH=-Wl,-rpath" in line 414. Just a minor, but slightly annoying detail. Regards, Øyvind ``` ## Stefano Lattarini, 2012-10-09 21:10 Subject: Re: [PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH Message-ID: <507492D6.3090207@gmail.com> URL: https://gitlist.dev/e/507492D6.3090207%40gmail.com In-Reply-To: <1349800572-2963-1-git-send-email-sunny@sunbase.org> ``` [Re-sending because I forgot to CC: the list, sorry] On 10/09/2012 06:36 PM, Øyvind A. Holm wrote: > From: "Øyvind A. Holm" > > 40bfbde ("build: don't duplicate substitution of make variables", > 2012-09-11) > Oops, stupid copy and paste error on my part. Sorry. > breaks make by removing a necessary comma at the end of > "CC_LD_DYNPATH=-rpath" in line 414 and 423. > Here, s/-rpath/-Wl,-rpath/, as you've noted yourself in a follow-up message. And the reference to "line 423" should be removed. Also, as a very minor nit, I'd write "might break make" rather then "breaks make", because the breakage depends on which code path is taken at configure time (and that's why I hadn't noticed the error until now -- I never ran configure with the '--with-zlib' option). > When executing "./configure --with-zlib=PATH", this resulted in > > [...] > CC xdiff/xhistogram.o > AR xdiff/lib.a > LINK git-credential-store > /usr/bin/ld: bad -rpath option > collect2: ld returned 1 exit status > make: *** [git-credential-store] Error 1 > $ > > during make. > Indeed, I can reproduce and confirm this error :-( > Signed-off-by: Øyvind A. Holm > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index da1f41f..ea79ea2 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -411,7 +411,7 @@ else > LDFLAGS="${SAVE_LDFLAGS}" > ]) > if test "$git_cv_ld_wl_rpath" = "yes"; then > - CC_LD_DYNPATH=-Wl,-rpath > + CC_LD_DYNPATH=-Wl,-rpath, > else > AC_CACHE_CHECK([if linker supports -rpath], git_cv_ld_rpath, [ > SAVE_LDFLAGS="${LDFLAGS}" > @@ -420,7 +420,7 @@ else > LDFLAGS="${SAVE_LDFLAGS}" > ]) > if test "$git_cv_ld_rpath" = "yes"; then > - CC_LD_DYNPATH=-rpath > + CC_LD_DYNPATH=-rpath, > And as Junio noted, this second hunk is unneeded, and in fact wrong. Just remove it please. With that done, Acked-by: Stefano Lattarini > else > CC_LD_DYNPATH= > AC_MSG_WARN([linker does not support runtime path to dynamic libraries]) Thanks, Stefano ```