# Test failure: Test #3 in t1304-default-acl 17 messages from 2012-09-17 to 2012-10-01. Participants: Ramkumar Ramachandra, Matthieu Moy, Andreas Schwab, Junio C Hamano, Joachim Schmitz. Thread: https://gitlist.dev/t/31565 ## Ramkumar Ramachandra, 2012-09-17 14:18 Subject: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/CALkWK0n0bH3xPLarv35Th_agnhKCkRjgcKTJR7Xy%3DB_NkBHkOg%40mail.gmail.com ``` Hi, The following test in t1304-default-acl.sh fails for me on the latest master: test_expect_success SETFACL 'Objects creation does not break ACLs with restrictive umask' ' # SHA1 for empty blob check_perms_and_acl .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391 ' It fails in the `grep -q "user:${LOGNAME}:rwx" actual` step, because "actual" contains: # file: .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391 # owner: ramkum # group: domain^users user::r-- user:root:rwx #effective:r-- user:kseygold:rwx #effective:r-- group::--- mask::r-- other::--- I'm not sure who or what kseygold is. I haven't dug any deeper. Thanks. Ram ``` ## Matthieu Moy, 2012-09-17 14:26 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/vpqy5k8raig.fsf%40grenoble-inp.fr In-Reply-To: ``` Ramkumar Ramachandra writes: > # file: .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391 > # owner: ramkum > # group: domain^users > user::r-- > user:root:rwx #effective:r-- > user:kseygold:rwx #effective:r-- > group::--- > mask::r-- > other::--- > > I'm not sure who or what kseygold is. Do you have any user with this login (finger kseygold)? I suspect you have two usernames with the same user ID. Which filesystem are you using in this directory? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ ``` ## Ramkumar Ramachandra, 2012-09-17 15:01 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/CALkWK0%3Dh6iU_J%3DX6MFgLXPfo0rh236cTuVaU3nNSnAaikjKH5w%40mail.gmail.com In-Reply-To: ``` Hi Matthieu, Matthieu Moy wrote: > Do you have any user with this login (finger kseygold)? I suspect you > have two usernames with the same user ID. Login: kseygold Name: Seybold Directory: /home/likewise-open/ANT/kseygold Shell: /bin/zsh Office: Kelly Last login Tue Aug 28 12:16 (IST) on tty2 No mail. No Plan. > Which filesystem are you using in this directory? / is ext4. What does that have to do with anything? Ram ``` ## Matthieu Moy, 2012-09-17 15:23 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/vpqd31kr7v4.fsf%40grenoble-inp.fr In-Reply-To: ``` Ramkumar Ramachandra writes: > Hi Matthieu, > > Matthieu Moy wrote: >> Do you have any user with this login (finger kseygold)? I suspect you >> have two usernames with the same user ID. > > Login: kseygold Name: Seybold > Directory: /home/likewise-open/ANT/kseygold Shell: /bin/zsh > Office: Kelly > Last login Tue Aug 28 12:16 (IST) on tty2 > No mail. > No Plan. Does this user have the same UID as your usual user (id kseygold; id $LOGNAME)? >> Which filesystem are you using in this directory? > > / is ext4. What does that have to do with anything? Last time we had a failure in this test, it was a filesystem bug ... -- Matthieu Moy http://www-verimag.imag.fr/~moy/ ``` ## Ramkumar Ramachandra, 2012-09-17 15:25 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/CALkWK0%3DROz8fxXgnqt-%2BAthU-hgq_mzFg0GhBQCrAshH_mRBPQ%40mail.gmail.com In-Reply-To: ``` Hi again, Matthieu Moy wrote: > Does this user have the same UID as your usual user > (id kseygold; id $LOGNAME)? Yes. What do you propose we do about the test? Ram ``` ## Andreas Schwab, 2012-09-17 15:29 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/m2txuw1xcj.fsf%40igel.home In-Reply-To: ``` Ramkumar Ramachandra writes: > Hi Matthieu, > > Matthieu Moy wrote: >> Do you have any user with this login (finger kseygold)? I suspect you >> have two usernames with the same user ID. > > Login: kseygold Name: Seybold What about "id kseygold; id ramkum"? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ``` ## Ramkumar Ramachandra, 2012-09-17 15:32 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/CALkWK0%3DcDW7BU6QofaeLbtETwzrnWBuuKcpgYNaM1x5tutisfA%40mail.gmail.com In-Reply-To: ``` Hi Andreas, Andreas Schwab wrote: > Ramkumar Ramachandra writes: > >> Hi Matthieu, >> >> Matthieu Moy wrote: >>> Do you have any user with this login (finger kseygold)? I suspect you >>> have two usernames with the same user ID. >> >> Login: kseygold Name: Seybold > > What about "id kseygold; id ramkum"? Apart from the UIDs matching, what do you find interesting about the output? uid=1420023794(kseygold) gid=1419772417(domain^users) groups=1419772417(domain^users),1419841836(sw-xchat-irc-client),1419932703(gref-sp-visitors),1419997311(fs-dus2-training-public),1420238821(sw-amazon-cloud-uploader),1419880095(dfs-pcsoft),1419980124(cs-psc-users),1419988839(scmdmauthorizedusers^(amzn-mdm)),1420131555(fs-lej1-oe-extern),1420053059(wireless-corporatewifi-allow),1419965136(sw-ms-ie7),1419812553(opr-pcsoft),1419806474(mac-caspershare-access),1419852490(dcolnl-accessrequestor),1419852491(dcolnl-visitorpre-registrationrequestor) uid=1420023794(ramkum) gid=1419772417(domain^users) groups=1419772417(domain^users),4(adm),20(dialout),24(cdrom),46(plugdev),116(lpadmin),118(admin),125(sambashare),1419841836(sw-xchat-irc-client),1419932703(gref-sp-visitors),1419997311(fs-dus2-training-public),1420238821(sw-amazon-cloud-uploader),1419992049(fhrix-employees),1419880095(dfs-pcsoft),1419988839(scmdmauthorizedusers^(amzn-mdm)),1420131555(fs-lej1-oe-extern),1420053059(wireless-corporatewifi-allow),1419812553(opr-pcsoft),1419806474(mac-caspershare-access),1419852490(dcolnl-accessrequestor),1419852491(dcolnl-visitorpre-registrationrequestor) Ram ``` ## Matthieu Moy, 2012-09-17 15:49 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/vpqvcfcps2z.fsf%40grenoble-inp.fr In-Reply-To: ``` Ramkumar Ramachandra writes: > Hi again, > > Matthieu Moy wrote: >> Does this user have the same UID as your usual user >> (id kseygold; id $LOGNAME)? > > Yes. What do you propose we do about the test? On a GNU system, something like this should do the trick: --- a/t/t1304-default-acl.sh +++ b/t/t1304-default-acl.sh @@ -31,9 +31,9 @@ fi check_perms_and_acl () { test -r "$1" && - getfacl "$1" > actual && + getfacl --numeric "$1" > actual && grep -q "user:root:rwx" actual && - grep -q "user:${LOGNAME}:rwx" actual && + grep -q "user:$(id -u):rwx" actual && egrep "mask::?r--" actual > /dev/null 2>&1 && grep -q "group::---" actual || false } but it seems FreeBSD's getfacl doesn't have --numeric (http://www.unix.com/man-page/FreeBSD/1/getfacl/), so to be portable, we need some more surgery, like this: --- a/t/t1304-default-acl.sh +++ b/t/t1304-default-acl.sh @@ -33,7 +33,10 @@ check_perms_and_acl () { test -r "$1" && getfacl "$1" > actual && grep -q "user:root:rwx" actual && - grep -q "user:${LOGNAME}:rwx" actual && + grep "user:.*:rwx" actual | grep -v 'user:root:' | \ + cut -d : -f 2 | xargs id -u > acl-uid && + id -u > actual-uid && + test_cmp acl-uid actual-uid && egrep "mask::?r--" actual > /dev/null 2>&1 && grep -q "group::---" actual || false } Can you check that this second patch fixes your problem? I'm a bit hesitant to submit it to git.git, as I find it a bit too hacky. What do other people think? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ ``` ## Junio C Hamano, 2012-09-17 16:37 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: <7v4nmwwqox.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v4nmwwqox.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Matthieu Moy writes: > Ramkumar Ramachandra writes: > >> Hi again, >> >> Matthieu Moy wrote: >>> Does this user have the same UID as your usual user >>> (id kseygold; id $LOGNAME)? >> >> Yes. What do you propose we do about the test? > > On a GNU system, something like this should do the trick: > ... > but it seems FreeBSD's getfacl doesn't have --numeric > (http://www.unix.com/man-page/FreeBSD/1/getfacl/), so to be portable, we > need some more surgery, like this: > > --- a/t/t1304-default-acl.sh > +++ b/t/t1304-default-acl.sh > @@ -33,7 +33,10 @@ check_perms_and_acl () { > test -r "$1" && > getfacl "$1" > actual && > grep -q "user:root:rwx" actual && > - grep -q "user:${LOGNAME}:rwx" actual && > + grep "user:.*:rwx" actual | grep -v 'user:root:' | \ > + cut -d : -f 2 | xargs id -u > acl-uid && > + id -u > actual-uid && > + test_cmp acl-uid actual-uid && > egrep "mask::?r--" actual > /dev/null 2>&1 && > grep -q "group::---" actual || false > } > > Can you check that this second patch fixes your problem? > > I'm a bit hesitant to submit it to git.git, as I find it a bit too > hacky. What do other people think? I haven't been paying attention, but does that mean on that system, a total stranger kseygold can write, modify, and remove whatever Ram owns? I am hoping that is not the case. ``` ## Matthieu Moy, 2012-09-17 16:52 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/vpqipbcpp69.fsf%40grenoble-inp.fr In-Reply-To: <7v4nmwwqox.fsf@alter.siamese.dyndns.org> ``` Junio C Hamano writes: > I haven't been paying attention, but does that mean on that system, > a total stranger kseygold can write, modify, and remove whatever Ram > owns? I am hoping that is not the case. I can see two reasons for having the same UID for two login names: 1) the sysadmin really messed up, and as you say, a total stranger has complete ownership of your files. Ramkumar, you should check that this is not your case. 2) the sysadmin explicitely gave two login names to the same physical person, as kinds of aliases for the same UID (e.g. the person got married, changed her name and login, but expects ~oldlogin to continue working). I'm not sure how common this is, and to which extend we want to support this in our test scripts. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ ``` ## Andreas Schwab, 2012-09-17 17:08 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/m2mx0o1srg.fsf%40igel.home In-Reply-To: ``` Ramkumar Ramachandra writes: > Hi Andreas, > > Andreas Schwab wrote: >> Ramkumar Ramachandra writes: >> >>> Hi Matthieu, >>> >>> Matthieu Moy wrote: >>>> Do you have any user with this login (finger kseygold)? I suspect you >>>> have two usernames with the same user ID. >>> >>> Login: kseygold Name: Seybold >> >> What about "id kseygold; id ramkum"? > > Apart from the UIDs matching, what do you find interesting about the output? That the UIDs are the same. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ``` ## Joachim Schmitz, 2012-09-17 17:59 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/k37oet%24gj9%241%40ger.gmane.org In-Reply-To: ``` Matthieu Moy wrote: > Junio C Hamano writes: > >> I haven't been paying attention, but does that mean on that system, >> a total stranger kseygold can write, modify, and remove whatever Ram >> owns? I am hoping that is not the case. > > I can see two reasons for having the same UID for two login names: > > 1) the sysadmin really messed up, and as you say, a total stranger has > complete ownership of your files. Ramkumar, you should check that this > is not your case. > > 2) the sysadmin explicitely gave two login names to the same physical > person, as kinds of aliases for the same UID (e.g. the person got > married, changed her name and login, but expects ~oldlogin to continue > working). I'm not sure how common this is, and to which extend we want > to support this in our test scripts. On HP NonStop it is very common to have a user (form: "GROUP.USER", case insensitiv) and one or more aliases to them (form: "user", case sensitiv) the latter are very commonly used in the POSIX part of HP NonStop (call OSS), the one git runs in, the other are more commonly used in the proprietary part of the OS (called Guardian), althoug this is not a strict requirement. The only thing they share is the UID. Bye, Jojo ``` ## Junio C Hamano, 2012-09-17 20:35 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: <7vvcfctmka.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vvcfctmka.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Matthieu Moy writes: > Junio C Hamano writes: > >> I haven't been paying attention, but does that mean on that system, >> a total stranger kseygold can write, modify, and remove whatever Ram >> owns? I am hoping that is not the case. > > I can see two reasons for having the same UID for two login names: > > 1) the sysadmin really messed up, and as you say, a total stranger has > complete ownership of your files. Ramkumar, you should check that this > is not your case. > > 2) the sysadmin explicitely gave two login names to the same physical > person, as kinds of aliases for the same UID (e.g. the person got > married, changed her name and login, but expects ~oldlogin to continue > working). I'm not sure how common this is, and to which extend we want > to support this in our test scripts. I've only been assuming (1), but (2) feels like a legitimate (if confusing) way to configure your system. It is a separate issue if it is worth bending backwards to support it in the test, though. ``` ## Ramkumar Ramachandra, 2012-09-18 06:19 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/CALkWK0nndTDxoGXjFcp5PC1JUbuifbEJdcE2N8XCcOmOkj4OKg%40mail.gmail.com In-Reply-To: ``` Hi, Matthieu Moy wrote: > I can see two reasons for having the same UID for two login names: > > 1) the sysadmin really messed up, and as you say, a total stranger has > complete ownership of your files. Ramkumar, you should check that this > is not your case. Looks like my sysadmin really screwed up :| Ram ``` ## Ramkumar Ramachandra, 2012-10-01 07:38 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/CALkWK0m9tkRXFZw-d_XADR9LXqxa0j_82bhhrd0FoEoHsO6yPg%40mail.gmail.com In-Reply-To: <7vvcfctmka.fsf@alter.siamese.dyndns.org> ``` Hi Junio, Junio C Hamano wrote: > Matthieu Moy writes: > >> Junio C Hamano writes: >> >>> I haven't been paying attention, but does that mean on that system, >>> a total stranger kseygold can write, modify, and remove whatever Ram >>> owns? I am hoping that is not the case. >> >> I can see two reasons for having the same UID for two login names: >> >> 1) the sysadmin really messed up, and as you say, a total stranger has >> complete ownership of your files. Ramkumar, you should check that this >> is not your case. >> >> 2) the sysadmin explicitely gave two login names to the same physical >> person, as kinds of aliases for the same UID (e.g. the person got >> married, changed her name and login, but expects ~oldlogin to continue >> working). I'm not sure how common this is, and to which extend we want >> to support this in our test scripts. > > I've only been assuming (1), but (2) feels like a legitimate (if > confusing) way to configure your system. > > It is a separate issue if it is worth bending backwards to support > it in the test, though. For what it's worth, `sudo` is "broken" on my system. Ram ``` ## Joachim Schmitz, 2012-10-01 08:08 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: URL: https://gitlist.dev/e/k4bj1v%24pav%241%40ger.gmane.org In-Reply-To: ``` Ramkumar Ramachandra wrote: > Hi Junio, > > Junio C Hamano wrote: >> Matthieu Moy writes: >> >>> Junio C Hamano writes: >>> >>>> I haven't been paying attention, but does that mean on that system, >>>> a total stranger kseygold can write, modify, and remove whatever >>>> Ram owns? I am hoping that is not the case. >>> >>> I can see two reasons for having the same UID for two login names: >>> >>> 1) the sysadmin really messed up, and as you say, a total stranger >>> has complete ownership of your files. Ramkumar, you should check >>> that this is not your case. >>> >>> 2) the sysadmin explicitely gave two login names to the same >>> physical person, as kinds of aliases for the same UID (e.g. the >>> person got married, changed her name and login, but expects >>> ~oldlogin to continue working). I'm not sure how common this is, >>> and to which extend we want to support this in our test scripts. >> >> I've only been assuming (1), but (2) feels like a legitimate (if >> confusing) way to configure your system. >> >> It is a separate issue if it is worth bending backwards to support >> it in the test, though. > > For what it's worth, `sudo` is "broken" on my system. sudo can't deal properly with multiple users sharing a UID, as it uses getpwuid(getuid()) in places. On my system I've replaced that with getgwnam(getlogin()). which seems to work fine here. Bye, Jojo ``` ## Junio C Hamano, 2012-10-01 16:07 Subject: Re: Test failure: Test #3 in t1304-default-acl Message-ID: <7vehlidvlq.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vehlidvlq.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Ramkumar Ramachandra writes: > Hi Junio, > > Junio C Hamano wrote: >> Matthieu Moy writes: >> >>> Junio C Hamano writes: >>> >>>> I haven't been paying attention, but does that mean on that system, >>>> a total stranger kseygold can write, modify, and remove whatever Ram >>>> owns? I am hoping that is not the case. >>> >>> I can see two reasons for having the same UID for two login names: >>> >>> 1) the sysadmin really messed up, and as you say, a total stranger has >>> complete ownership of your files. Ramkumar, you should check that this >>> is not your case. >>> >>> 2) the sysadmin explicitely gave two login names to the same physical >>> person, as kinds of aliases for the same UID (e.g. the person got >>> married, changed her name and login, but expects ~oldlogin to continue >>> working). I'm not sure how common this is, and to which extend we want >>> to support this in our test scripts. >> >> I've only been assuming (1), but (2) feels like a legitimate (if >> confusing) way to configure your system. >> >> It is a separate issue if it is worth bending backwards to support >> it in the test, though. > > For what it's worth, `sudo` is "broken" on my system. Not very surprised ;-) ```