# [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile 5 messages from 2012-09-07 to 2012-09-08. Participants: Joachim Schmitz, Junio C Hamano. Thread: https://gitlist.dev/t/31465 ## Joachim Schmitz, 2012-09-07 12:10 Subject: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile Message-ID: <003301cd8cf1$d26258c0$77270a40$@schmitz-digital.de> URL: https://gitlist.dev/e/003301cd8cf1%24d26258c0%2477270a40%24%40schmitz-digital.de ``` Signed-off-by: Joachim Schmitz --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index ac49320..03e245a 100644 --- a/Makefile +++ b/Makefile @@ -90,6 +90,8 @@ all:: # # Define NO_MKDTEMP if you don't have mkdtemp in the C library. # +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash. +# # Define NO_MKSTEMPS if you don't have mkstemps in the C library. # # Define NO_STRTOK_R if you don't have strtok_r in the C library. -- 1.7.12 ``` ## Junio C Hamano, 2012-09-07 17:27 Subject: Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile Message-ID: <7vsjatyc9e.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vsjatyc9e.fsf%40alter.siamese.dyndns.org In-Reply-To: <003301cd8cf1$d26258c0$77270a40$@schmitz-digital.de> ``` Thanks. ``` ## Junio C Hamano, 2012-09-07 17:29 Subject: Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile Message-ID: <7vliglyc5g.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vliglyc5g.fsf%40alter.siamese.dyndns.org In-Reply-To: <003301cd8cf1$d26258c0$77270a40$@schmitz-digital.de> ``` "Joachim Schmitz" writes: > Signed-off-by: Joachim Schmitz > --- > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index ac49320..03e245a 100644 > --- a/Makefile > +++ b/Makefile > @@ -90,6 +90,8 @@ all:: > # > # Define NO_MKDTEMP if you don't have mkdtemp in the C library. > # > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash. > +# > # Define NO_MKSTEMPS if you don't have mkstemps in the C library. > # > # Define NO_STRTOK_R if you don't have strtok_r in the C library. Not really. "make MKDIR_WO_TRAILING_SLASH=YesPlease" won't do anything. You would need at least something like this, no? Makefile | 5 +++++ 1 file changed, 5 insertions(+) diff --git c/Makefile w/Makefile index 66e8216..21b4816 100644 --- c/Makefile +++ w/Makefile @@ -90,6 +90,8 @@ all:: # # Define NO_MKDTEMP if you don't have mkdtemp in the C library. # +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash. +# # Define NO_MKSTEMPS if you don't have mkstemps in the C library. # # Define NO_STRTOK_R if you don't have strtok_r in the C library. @@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP COMPAT_CFLAGS += -DNO_MKDTEMP COMPAT_OBJS += compat/mkdtemp.o endif +ifdef MKDIR_WO_TRAILING_SLASH + COMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH +endif ifdef NO_MKSTEMPS COMPAT_CFLAGS += -DNO_MKSTEMPS endif ``` ## Joachim Schmitz, 2012-09-07 18:28 Subject: RE: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile Message-ID: <004601cd8d26$8475f8d0$8d61ea70$@schmitz-digital.de> URL: https://gitlist.dev/e/004601cd8d26%248475f8d0%248d61ea70%24%40schmitz-digital.de In-Reply-To: <7vliglyc5g.fsf@alter.siamese.dyndns.org> ``` > -----Original Message----- > From: Junio C Hamano [mailto:gitster@pobox.com] > Sent: Friday, September 07, 2012 7:30 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile > > "Joachim Schmitz" writes: > > > Signed-off-by: Joachim Schmitz > > --- > > Makefile | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Makefile b/Makefile > > index ac49320..03e245a 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -90,6 +90,8 @@ all:: > > # > > # Define NO_MKDTEMP if you don't have mkdtemp in the C library. > > # > > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash. > > +# > > # Define NO_MKSTEMPS if you don't have mkstemps in the C library. > > # > > # Define NO_STRTOK_R if you don't have strtok_r in the C library. > > Not really. "make MKDIR_WO_TRAILING_SLASH=YesPlease" won't do > anything. > > You would need at least something like this, no? > Yes, that is better, thanks > Makefile | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git c/Makefile w/Makefile > index 66e8216..21b4816 100644 > --- c/Makefile > +++ w/Makefile > @@ -90,6 +90,8 @@ all:: > # > # Define NO_MKDTEMP if you don't have mkdtemp in the C library. > # > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash. > +# > # Define NO_MKSTEMPS if you don't have mkstemps in the C library. > # > # Define NO_STRTOK_R if you don't have strtok_r in the C library. > @@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP > COMPAT_CFLAGS += -DNO_MKDTEMP > COMPAT_OBJS += compat/mkdtemp.o > endif > +ifdef MKDIR_WO_TRAILING_SLASH > + COMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH > +endif > ifdef NO_MKSTEMPS > COMPAT_CFLAGS += -DNO_MKSTEMPS > endif ``` ## Joachim Schmitz, 2012-09-08 15:23 Subject: RE: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile Message-ID: <001c01cd8dd5$d58eabe0$80ac03a0$@schmitz-digital.de> URL: https://gitlist.dev/e/001c01cd8dd5%24d58eabe0%2480ac03a0%24%40schmitz-digital.de In-Reply-To: <7vliglyc5g.fsf@alter.siamese.dyndns.org> ``` > From: Joachim Schmitz [mailto:jojo@schmitz-digital.de] > Sent: Friday, September 07, 2012 8:28 PM > To: 'Junio C Hamano' > Cc: 'git@vger.kernel.org' > Subject: RE: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile > > > > > -----Original Message----- > > From: Junio C Hamano [mailto:gitster@pobox.com] > > Sent: Friday, September 07, 2012 7:30 PM > > To: Joachim Schmitz > > Cc: git@vger.kernel.org > > Subject: Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile > > > > "Joachim Schmitz" writes: > > > > > Signed-off-by: Joachim Schmitz > > > --- > > > Makefile | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Makefile b/Makefile > > > index ac49320..03e245a 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -90,6 +90,8 @@ all:: > > > # > > > # Define NO_MKDTEMP if you don't have mkdtemp in the C library. > > > # > > > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash. > > > +# > > > # Define NO_MKSTEMPS if you don't have mkstemps in the C library. > > > # > > > # Define NO_STRTOK_R if you don't have strtok_r in the C library. > > > > Not really. "make MKDIR_WO_TRAILING_SLASH=YesPlease" won't do > > anything. > > > > You would need at least something like this, no? > > > > Yes, that is better, thanks There's something missing though, to make it fully usable, see below > > > Makefile | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git c/Makefile w/Makefile > > index 66e8216..21b4816 100644 > > --- c/Makefile > > +++ w/Makefile > > @@ -90,6 +90,8 @@ all:: > > # > > # Define NO_MKDTEMP if you don't have mkdtemp in the C library. > > # > > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash. > > +# > > # Define NO_MKSTEMPS if you don't have mkstemps in the C library. > > # > > # Define NO_STRTOK_R if you don't have strtok_r in the C library. > > @@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP > > COMPAT_CFLAGS += -DNO_MKDTEMP > > COMPAT_OBJS += compat/mkdtemp.o > > endif > > +ifdef MKDIR_WO_TRAILING_SLASH > > + COMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH + COMPAT_OBJS += compat/mkdir.o > > +endif > > ifdef NO_MKSTEMPS > > COMPAT_CFLAGS += -DNO_MKSTEMPS > > endif Bye, Jojo ```