# [PATCH] Document the --done option.

5 messages from 2012-08-22 to 2012-09-12. Participants: Eric S. Raymond, Junio C Hamano, Sverre Rabbelier.
Thread: https://gitlist.dev/t/31313

## Eric S. Raymond, 2012-08-22 10:57

Subject: [PATCH] Document the --done option.
Message-ID: <20120822105705.GA30472@thyrsus.com>
URL: https://gitlist.dev/e/20120822105705.GA30472%40thyrsus.com

```
---
 Documentation/git-fast-import.txt |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
index 2620d28..9291ea0 100644
--- a/Documentation/git-fast-import.txt
+++ b/Documentation/git-fast-import.txt
@@ -39,6 +39,10 @@ OPTIONS
 	See ``Date Formats'' below for details about which formats
 	are supported, and their syntax.
 
+-- done::
+	Terminate with error if there is no 'done' command at the 
+	end of the stream.
+
 --force::
 	Force updating modified existing branches, even if doing
 	so would cause commits to be lost (as the new commit does
@@ -1047,7 +1051,9 @@ done::
 	Error out if the stream ends without a 'done' command.
 	Without this feature, errors causing the frontend to end
 	abruptly at a convenient point in the stream can go
-	undetected.
+	undetected.  This may occur, for example, if an import
+	front end dies in mid-operation without emitting SIGTERM
+	or SIGKILL at its subordinate git fast-import instance.
 
 `option`
 ~~~~~~~~
-- 
1.7.9.5


-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

```

## Junio C Hamano, 2012-08-22 17:38

Subject: Re: [PATCH] Document the --done option.
Message-ID: <7vobm2968x.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vobm2968x.fsf%40alter.siamese.dyndns.org
In-Reply-To: <20120822105705.GA30472@thyrsus.com>

```
"Eric S. Raymond" <esr@thyrsus.com> writes:

> ---

A forgotten Sign-off?

Sverre, the text matches my understanding as well as what be56862
(fast-import: introduce 'done' command, 2011-07-16) says it did.
Ack?

>  Documentation/git-fast-import.txt |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
> index 2620d28..9291ea0 100644
> --- a/Documentation/git-fast-import.txt
> +++ b/Documentation/git-fast-import.txt
> @@ -39,6 +39,10 @@ OPTIONS
>  	See ``Date Formats'' below for details about which formats
>  	are supported, and their syntax.
>  
> +-- done::
> +	Terminate with error if there is no 'done' command at the 
> +	end of the stream.
> +
>  --force::
>  	Force updating modified existing branches, even if doing
>  	so would cause commits to be lost (as the new commit does
> @@ -1047,7 +1051,9 @@ done::
>  	Error out if the stream ends without a 'done' command.
>  	Without this feature, errors causing the frontend to end
>  	abruptly at a convenient point in the stream can go
> -	undetected.
> +	undetected.  This may occur, for example, if an import
> +	front end dies in mid-operation without emitting SIGTERM
> +	or SIGKILL at its subordinate git fast-import instance.
>  
>  `option`
>  ~~~~~~~~
> -- 
> 1.7.9.5

```

## Sverre Rabbelier, 2012-08-22 17:47

Subject: Re: [PATCH] Document the --done option.
Message-ID: <CAGdFq_jTOY=+DJfuFdx8w8U-hQe9kFBLQDMaESpbeQKDafko2A@mail.gmail.com>
URL: https://gitlist.dev/e/CAGdFq_jTOY%3D%2BDJfuFdx8w8U-hQe9kFBLQDMaESpbeQKDafko2A%40mail.gmail.com
In-Reply-To: <7vobm2968x.fsf@alter.siamese.dyndns.org>

```
On Wed, Aug 22, 2012 at 10:38 AM, Junio C Hamano <gitster@pobox.com> wrote:
> "Eric S. Raymond" <esr@thyrsus.com> writes:
>
>> ---
>
> A forgotten Sign-off?
>
> Sverre, the text matches my understanding as well as what be56862
> (fast-import: introduce 'done' command, 2011-07-16) says it did.
> Ack?

Acked-by: Sverre Rabbelier <srabbelier@gmail.com>

-- 
Cheers,

Sverre Rabbelier

```

## Junio C Hamano, 2012-08-24 23:19

Subject: Re: [PATCH] Document the --done option.
Message-ID: <7voblzyj2q.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7voblzyj2q.fsf%40alter.siamese.dyndns.org
In-Reply-To: <7vobm2968x.fsf@alter.siamese.dyndns.org>

```
Junio C Hamano <gitster@pobox.com> writes:

> "Eric S. Raymond" <esr@thyrsus.com> writes:
>
>> ---
>
> A forgotten Sign-off?

Ping?  Just telling us that this is Signed-off is fine.

Thanks.

>
> Sverre, the text matches my understanding as well as what be56862
> (fast-import: introduce 'done' command, 2011-07-16) says it did.
> Ack?
>
>>  Documentation/git-fast-import.txt |    8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
>> index 2620d28..9291ea0 100644
>> --- a/Documentation/git-fast-import.txt
>> +++ b/Documentation/git-fast-import.txt
>> @@ -39,6 +39,10 @@ OPTIONS
>>  	See ``Date Formats'' below for details about which formats
>>  	are supported, and their syntax.
>>  
>> +-- done::
>> +	Terminate with error if there is no 'done' command at the 
>> +	end of the stream.
>> +
>>  --force::
>>  	Force updating modified existing branches, even if doing
>>  	so would cause commits to be lost (as the new commit does
>> @@ -1047,7 +1051,9 @@ done::
>>  	Error out if the stream ends without a 'done' command.
>>  	Without this feature, errors causing the frontend to end
>>  	abruptly at a convenient point in the stream can go
>> -	undetected.
>> +	undetected.  This may occur, for example, if an import
>> +	front end dies in mid-operation without emitting SIGTERM
>> +	or SIGKILL at its subordinate git fast-import instance.
>>  
>>  `option`
>>  ~~~~~~~~
>> -- 
>> 1.7.9.5

```

## Junio C Hamano, 2012-09-12 09:11

Subject: Re: [PATCH] Document the --done option.
Message-ID: <7vfw6nfvw2.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vfw6nfvw2.fsf%40alter.siamese.dyndns.org
In-Reply-To: <7voblzyj2q.fsf@alter.siamese.dyndns.org>

```
Junio C Hamano <gitster@pobox.com> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> "Eric S. Raymond" <esr@thyrsus.com> writes:
>>
>>> ---
>>
>> A forgotten Sign-off?
>
> Ping?  Just telling us that this is Signed-off is fine.

Ping again.

```