# GNU patch close to next stable release (2) 5 messages from 2012-08-01 to 2012-08-02. Participants: Andreas Grünbacher, Junio C Hamano, Paul Eggert, Jim Meyering. Thread: https://gitlist.dev/t/31161 ## Andreas Grünbacher, 2012-08-01 11:50 Subject: GNU patch close to next stable release (2) Message-ID: URL: https://gitlist.dev/e/CAHpGcM%2BDkL_CCisCjF9m0j3NRJUNAdfL05T0cfLjLfVORQHrpw%40mail.gmail.com ``` After another improvement in git-style diff support to better handle concatenated diffs, here is a last call for testing to ensure that the code works well enough to become the next stable release. Please find the latest development snapshots here: ftp://alpha.gnu.org/gnu/patch/ The following significant changes have happened since the last stable release in December 2009: * Support for most features of the "diff --git" format, including renames and copies, permission changes, and symlink diffs. Binary diffs are not supported yet; patch will complain and skip them. * Support for double-quoted filenames in the "diff --git" format: when a filename starts with a double quote, it is interpreted as a C string literal. The escape sequences \\, \", \a, \b, \f, \n, \r, \t, \v, and \ooo (a three-digit octal number between 0 and 255) are recognized. * Patch now ignores destination file names that are absolute or that contain a component of "..". This addresses CVE-2010-4651. * Refuse to apply a normal patch to a symlink. (Previous versions of patch were replacing the symlink with a regular file.) * When trying to modify a read-only file, warn about the potential problem by default. The --read-only command line option allows to change this behavior. * Files that should be deleted are now deleted once the entire patch file has been read. This fixes a bug with numbered backup files. * When a timestamp specifies a time zone, honor that instead of assuming the local time zone (--set-date) or Universal Coordinated Time (--set-utc). * Support for nanosecond precision timestamps. * Many portability and bug fixes. Please report bugs or suggestions on the mailing list, or in the project's bug tracker on Savannah: http://savannah.gnu.org/projects/patch Thanks, Andreas ``` ## Junio C Hamano, 2012-08-01 17:58 Subject: Re: GNU patch close to next stable release (2) Message-ID: <7v8vdyfqa9.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v8vdyfqa9.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Andreas Grünbacher writes: > * Support for double-quoted filenames in the "diff --git" format: when a > filename starts with a double quote, it is interpreted as a C string > literal. The escape sequences \\, \", \a, \b, \f, \n, \r, \t, \v, and \ooo > (a three-digit octal number between 0 and 255) are recognized. Is this also available in non-git diffs? IIRC, this extension to allow funny characters in pathnames was proposed by and discussed with Paul Eggert (listed as one of GNU diffutils maintainers at www.gnu.org/software/diffutils/) and git happened to adopt it earlier than "GNU diff" itself did. I found it a bit odd to see this listed as one of the items needed to support "diff --git" oddity. ``` ## Andreas Grünbacher, 2012-08-02 20:02 Subject: Re: GNU patch close to next stable release (2) Message-ID: URL: https://gitlist.dev/e/CAHpGcML5PVAgd9x75%3D5k1-ev%2BPx4V%2B26KJhhyZk-O54p0WxfxQ%40mail.gmail.com In-Reply-To: <7v8vdyfqa9.fsf@alter.siamese.dyndns.org> ``` Junio, 2012/8/1 Junio C Hamano : > Andreas Grünbacher writes: > >> * Support for double-quoted filenames in the "diff --git" format: when a >> filename starts with a double quote, it is interpreted as a C string >> literal. The escape sequences \\, \", \a, \b, \f, \n, \r, \t, \v, and \ooo >> (a three-digit octal number between 0 and 255) are recognized. > > Is this also available in non-git diffs? I have only enabled this for git-style diffs for now. GNU diff doesn't do filename quoting so far and if it eventually implements a slightly different form of quoting (which I wouldn't recommend), we might be in trouble. > IIRC, this extension to allow funny characters in pathnames was > proposed by and discussed with Paul Eggert (listed as one of GNU > diffutils maintainers at www.gnu.org/software/diffutils/) and git happened > to adopt it earlier than "GNU diff" itself did. Paul and Jim, any thoughts about adding filename quoting to GNU diff anytime soon, or about the format? Thanks, Andreas ``` ## Paul Eggert, 2012-08-02 21:08 Subject: Re: GNU patch close to next stable release (2) Message-ID: <501AEC59.7010907@cs.ucla.edu> URL: https://gitlist.dev/e/501AEC59.7010907%40cs.ucla.edu In-Reply-To: ``` On 08/02/2012 01:02 PM, Andreas Grünbacher wrote: > Paul and Jim, any thoughts about adding filename quoting to GNU diff anytime > soon, or about the format? The git format looks OK. I don't have time right now to add it to GNU diff, tho. ``` ## Jim Meyering, 2012-08-02 21:13 Subject: Re: GNU patch close to next stable release (2) Message-ID: <877gtht2sy.fsf@rho.meyering.net> URL: https://gitlist.dev/e/877gtht2sy.fsf%40rho.meyering.net In-Reply-To: <501AEC59.7010907-764C0pRuGfqVc3sceRu5cw@public.gmane.org> ``` Paul Eggert wrote: > On 08/02/2012 01:02 PM, Andreas Grünbacher wrote: >> Paul and Jim, any thoughts about adding filename quoting to GNU diff anytime >> soon, or about the format? > > The git format looks OK. I don't have time right now to add it to GNU diff, tho. I agree, and have no more free time for the task than Paul does. Would someone care to contribute a complete patch? ```