threads / patch / 31125

patch, 2 partst1100-*.sh: Fix an intermittent test failure

Subject: [PATCH 1/2] t1100-*.sh: Fix an intermittent test failure

## tl;dr

One message between Jul 28, 2012 and Jul 28, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ramsay Jones· Jul 28, 2012, 18:48 UTC · lore

In particular, the final test ('flags and then non flags') fails intermittently, depending on how much time elapsed between the invocations of "git commit-tree" when creating the commits which later have their commit id's compared. For example, if the commits for childid-3 and childid-4 are created 1 or more seconds apart, then the commits, which would otherwise be identical, will have different commit id's.

In order to make the test reproducible, we remove the variability by setting the author and committer times to a well defined state. We accomplish this with a single call to 'test_tick' at the start of the test.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 t/t1100-commit-tree-options.sh | 1 +
 1 file changed, 1 insertion(+)
Show changes to t/t1100-commit-tree-options.sh +1 −0
diff --git a/t/t1100-commit-tree-options.sh b/t/t1100-commit-tree-options.sh
index a3b7723..f8457f9 100755
--- a/t/t1100-commit-tree-options.sh
+++ b/t/t1100-commit-tree-options.sh
@@ -47,6 +47,7 @@ test_expect_success \
 
 
 test_expect_success 'flags and then non flags' '
+	test_tick &&
 	echo comment text |
 	git commit-tree $(cat treeid) >commitid &&
 	echo comment text |
-- 
1.7.11.2

← back to recent threads