# [PATCH] i18n: leave \n out of translated diffstat 2 messages from 2012-07-26 to 2012-07-26. Participants: Nguyễn Thái Ngọc Duy, Junio C Hamano. Thread: https://gitlist.dev/t/31106 ## Nguyễn Thái Ngọc Duy, 2012-07-26 12:52 Subject: [PATCH] i18n: leave \n out of translated diffstat Message-ID: <1343307156-16528-1-git-send-email-pclouds@gmail.com> URL: https://gitlist.dev/e/1343307156-16528-1-git-send-email-pclouds%40gmail.com ``` GETTEXT_POISON scrapes everything in translated strings, including \n. t4205.12 however needs this \n in matching the end result. Keep this \n out of translation to make t4205.12 happy. Signed-off-by: Nguyễn Thái Ngọc Duy --- I haven't followed recent i18n patches closely. Jiang may have already fixed this in one of his patches. Anyway just in case everybody does miss this.. Should I resend parseopt i18n marking series now or wait until rc period is over? diff.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/diff.c b/diff.c index 62cbe14..95706a5 100644 --- a/diff.c +++ b/diff.c @@ -1397,7 +1397,7 @@ int print_stat_summary(FILE *fp, int files, int insertions, int deletions) if (!files) { assert(insertions == 0 && deletions == 0); - return fputs(_(" 0 files changed\n"), fp); + return fprintf(fp, "%s\n", _(" 0 files changed")); } strbuf_addf(&sb, -- 1.7.8 ``` ## Junio C Hamano, 2012-07-26 17:46 Subject: Re: [PATCH] i18n: leave \n out of translated diffstat Message-ID: <7va9ym8lf1.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7va9ym8lf1.fsf%40alter.siamese.dyndns.org In-Reply-To: <1343307156-16528-1-git-send-email-pclouds@gmail.com> ``` Nguyễn Thái Ngọc Duy writes: > diff --git a/diff.c b/diff.c > index 62cbe14..95706a5 100644 > --- a/diff.c > +++ b/diff.c > @@ -1397,7 +1397,7 @@ int print_stat_summary(FILE *fp, int files, int insertions, int deletions) > > if (!files) { > assert(insertions == 0 && deletions == 0); > - return fputs(_(" 0 files changed\n"), fp); > + return fprintf(fp, "%s\n", _(" 0 files changed")); > } Good. ```