threads / patch / 31011

patchdate.c: Fix off by one error in object-header date parsing

Subject: [PATCH] date.c: Fix off by one error in object-header date parsing

## tl;dr

One message between Jul 12, 2012 and Jul 12, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Junio C Hamano· Jul 12, 2012, 20:50 UTC · lore

It is perfectly OK for a valid decimal integer to begin with '9' but 116eb3a (parse_date(): allow ancient git-timestamp, 2012-02-02) did not express the range correctly.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 date.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to date.c +1 −1
diff --git a/date.c b/date.c
index bf8e088..67b3d66 100644
--- a/date.c
+++ b/date.c
@@ -595,7 +595,7 @@ static int match_object_header_date(const char *date, unsigned long *timestamp,
 	unsigned long stamp;
 	int ofs;
 
-	if (*date < '0' || '9' <= *date)
+	if (*date < '0' || '9' < *date)
 		return -1;
 	stamp = strtoul(date, &end, 10);
 	if (*end != ' ' || stamp == ULONG_MAX || (end[1] != '+' && end[1] != '-'))
-- 
1.7.11.2

← back to recent threads