threads / bug / 30996

Mini bug report origin/pu: t1512 failed on Mac OS X (commit 957d74062c1f0e ?)

Subject: Mini bug report origin/pu: t1512 failed on Mac OS X (commit 957d74062c1f0e ?)

## tl;dr

7 messages between Jul 11, 2012 and Jul 13, 2012.

replies: 6people: 4as markdown or json

Torsten Bögershausen· Jul 11, 2012, 20:09 UTC · lore
The following tweak will make t1512 work on my Mac OS box:
--- a/t/t1512-rev-parse-disambiguation.sh
+++ b/t/t1512-rev-parse-disambiguation.sh
@@ -257,7 +257,7 @@ test_expect_success 'rev-parse --disambiguate' '
        # commits created by commit-tree in earlier tests do not share
        # the prefix.
        git rev-parse --disambiguate=000000000 >actual &&
-       test "$(wc -l <actual)" = 16 &&
+       test "$(wc -l <actual)" -eq  16 &&
        test "$(sed -e "s/^\(.........\).*/\1/" actual | sort -u)" = 000000000



/Torsten
Junio C Hamano· Jul 11, 2012, 23:05 UTC · re: Torsten Bögershausen · lore

Re: Mini bug report origin/pu: t1512 failed on Mac OS X (commit 957d74062c1f0e ?)

Torsten Bögershausen <tboegi@web.de> writes:
Show 11 quoted lines
> The following tweak will make t1512 work on my Mac OS box:
>
>
> --- a/t/t1512-rev-parse-disambiguation.sh
> +++ b/t/t1512-rev-parse-disambiguation.sh
> @@ -257,7 +257,7 @@ test_expect_success 'rev-parse --disambiguate' '
>         # commits created by commit-tree in earlier tests do not share
>         # the prefix.
>         git rev-parse --disambiguate=000000000 >actual &&
> -       test "$(wc -l <actual)" = 16 &&
> +       test "$(wc -l <actual)" -eq  16 &&

I think the other tests in t/ prefer to unquote it so that we would ignore spaces around "wc -l" output, i.e.

	test $(wc -l <actual) = 16
Thanks for a report.
Junio C Hamano· Jul 11, 2012, 23:30 UTC · re: Junio C Hamano · lore

Re: Mini bug report origin/pu: t1512 failed on Mac OS X (commit 957d74062c1f0e ?)

Junio C Hamano <gitster@pobox.com> writes:
Show 6 quoted lines
> I think the other tests in t/ prefer to unquote it so that we would
> ignore spaces around "wc -l" output, i.e.
>
> 	test $(wc -l <actual) = 16
>
> Thanks for a report.
-- >8 --
Subject: [PATCH] t1512: ignore whitespaces in wc -l output

Some implementations of sed (e.g. MacOS X) have whitespaces in the output of "wc -l" that reads from the standard input. Ignore these whitespaces by not quoting the command substitution to be compared with the constant "16".

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t1512-rev-parse-disambiguation.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1512-rev-parse-disambiguation.sh b/t/t1512-rev-parse-disambiguation.sh
index 3ed7558..1eb3514 100755
--- a/t/t1512-rev-parse-disambiguation.sh
+++ b/t/t1512-rev-parse-disambiguation.sh
@@ -257,7 +257,7 @@ test_expect_success 'rev-parse --disambiguate' '
 	# commits created by commit-tree in earlier tests do not share
 	# the prefix.
 	git rev-parse --disambiguate=000000000 >actual &&
-	test "$(wc -l <actual)" = 16 &&
+	test $(wc -l <actual) = 16 &&
 	test "$(sed -e "s/^\(.........\).*/\1/" actual | sort -u)" = 000000000
 '
 

-- 
1.7.11.2.270.gc2d3e4b
Johannes Sixt· Jul 12, 2012, 07:21 UTC · re: Junio C Hamano · lore

Re: Mini bug report origin/pu: t1512 failed on Mac OS X (commit 957d74062c1f0e ?)

Am 7/12/2012 1:30, schrieb Junio C Hamano:
> -	test "$(wc -l <actual)" = 16 &&
> +	test $(wc -l <actual) = 16 &&
We have a helper function for this:
	test_line_count = 16 actual &&
-- Hannes
Junio C Hamano· Jul 12, 2012, 16:58 UTC · re: Johannes Sixt · lore

Re: Mini bug report origin/pu: t1512 failed on Mac OS X (commit 957d74062c1f0e ?)

Johannes Sixt <j.sixt@viscovery.net> writes:
Show 7 quoted lines
> Am 7/12/2012 1:30, schrieb Junio C Hamano:
>> -	test "$(wc -l <actual)" = 16 &&
>> +	test $(wc -l <actual) = 16 &&
>
> We have a helper function for this:
>
> 	test_line_count = 16 actual &&
OK.
Stefano Lattarini· Jul 13, 2012, 22:43 UTC · re: Junio C Hamano · lore

Re: Mini bug report origin/pu: t1512 failed on Mac OS X (commit 957d74062c1f0e ?)

On 07/12/2012 01:30 AM, Junio C Hamano wrote:
Show 14 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
>> I think the other tests in t/ prefer to unquote it so that we would
>> ignore spaces around "wc -l" output, i.e.
>>
>> 	test $(wc -l <actual) = 16
>>
>> Thanks for a report.
> 
> -- >8 --
> Subject: [PATCH] t1512: ignore whitespaces in wc -l output
> 
> Some implementations of sed (e.g. MacOS X)
>
'sed'?  Shouldn't this read 'wc'?
> have whitespaces in the output of "wc -l" that reads from the standard
> input.
>
FYI, the extra space is present with Solaris wc as well:
$ wc -l </dev/null
       0
Regards,
  Stefano
Junio C Hamano· Jul 13, 2012, 23:31 UTC · re: Stefano Lattarini · lore

Re: Mini bug report origin/pu: t1512 failed on Mac OS X (commit 957d74062c1f0e ?)

Stefano Lattarini <stefano.lattarini@gmail.com> writes:
Show 16 quoted lines
> On 07/12/2012 01:30 AM, Junio C Hamano wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> 
>>> I think the other tests in t/ prefer to unquote it so that we would
>>> ignore spaces around "wc -l" output, i.e.
>>>
>>> 	test $(wc -l <actual) = 16
>>>
>>> Thanks for a report.
>> 
>> -- >8 --
>> Subject: [PATCH] t1512: ignore whitespaces in wc -l output
>> 
>> Some implementations of sed (e.g. MacOS X)
>>
> 'sed'?  Shouldn't this read 'wc'?
Heh, funny typo.  I don't know what I was thinking.

← back to recent threads