# [PATCH] git-remote-mediawiki: update comments to reflect credential support

2 messages from 2012-07-08 to 2012-07-09. Participants: Matthieu Moy, Junio C Hamano.
Thread: https://gitlist.dev/t/30978

## Matthieu Moy, 2012-07-08 16:18

Subject: [PATCH] git-remote-mediawiki: update comments to reflect credential support
Message-ID: <1341764308-9508-1-git-send-email-Matthieu.Moy@imag.fr>
URL: https://gitlist.dev/e/1341764308-9508-1-git-send-email-Matthieu.Moy%40imag.fr

```

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---

Junio, can you add this to mm/credential-plumbing in pu, or better,
squash it into the last patch of the serie (i.e. a7271ad1dccaf1,
git-remote-mediawiki: add credential support)?

Thanks,

 contrib/mw-to-git/git-remote-mediawiki | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki
index 539718e..c07b4f0 100755
--- a/contrib/mw-to-git/git-remote-mediawiki
+++ b/contrib/mw-to-git/git-remote-mediawiki
@@ -26,9 +26,6 @@
 # - Git renames could be turned into MediaWiki renames (see TODO
 #   below)
 #
-# - login/password support requires the user to write the password
-#   cleartext in a file (see TODO below).
-#
 # - No way to import "one page, and all pages included in it"
 #
 # - Multiple remote MediaWikis have not been very well tested.
@@ -74,9 +71,7 @@ my @tracked_categories = split(/[ \n]/, run_git("config --get-all remote.". $rem
 chomp(@tracked_categories);
 
 my $wiki_login = run_git("config --get remote.". $remotename .".mwLogin");
-# TODO: ideally, this should be able to read from keyboard, but we're
-# inside a remote helper, so our stdin is connect to git, not to a
-# terminal.
+# Note: mwPassword is discourraged. Use the credential system instead.
 my $wiki_passwd = run_git("config --get remote.". $remotename .".mwPassword");
 my $wiki_domain = run_git("config --get remote.". $remotename .".mwDomain");
 chomp($wiki_login);
-- 
1.7.11.1.147.g47a574d

```

## Junio C Hamano, 2012-07-09 02:17

Subject: Re: [PATCH] git-remote-mediawiki: update comments to reflect credential support
Message-ID: <7vd345n0er.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vd345n0er.fsf%40alter.siamese.dyndns.org
In-Reply-To: <1341764308-9508-1-git-send-email-Matthieu.Moy@imag.fr>

```
thanks; done.

```