# [PATCH] dir.c: Fix a sparse warning

1 messages from 2012-06-02 to 2012-06-02. Participants: Ramsay Jones.
Thread: https://gitlist.dev/t/30687

## Ramsay Jones, 2012-06-02 17:05

Subject: [PATCH] dir.c: Fix a sparse warning
Message-ID: <4FCA47E0.7020700@ramsay1.demon.co.uk>
URL: https://gitlist.dev/e/4FCA47E0.7020700%40ramsay1.demon.co.uk

```

In particular, sparse complains as follows:

        SP dir.c
    dir.c:291:12: warning: symbol 'wildcards' was not declared. \
        Should it be static?

In order to suppress the warning, since 'wildcards' does not need
to be an external symbol, we simply add the static modifier to the
declaration.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Nguyen,

If you need to re-roll the 'nd/exclude-workaround-top-heavy' branch,
could you please squash this into commit dedbd80c ("exclude: do strcmp
as much as possible before fnmatch", 26-05-2012).

Thanks!

ATB,
Ramsay Jones

 dir.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dir.c b/dir.c
index 1b1a325..571eb0d 100644
--- a/dir.c
+++ b/dir.c
@@ -288,7 +288,7 @@ int match_pathspec_depth(const struct pathspec *ps,
 	return retval;
 }
 
-const char *wildcards = "*?[{\\";
+static const char *wildcards = "*?[{\\";
 
 static int no_wildcard(const char *string)
 {
-- 
1.7.10

```