# [PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency

2 messages from 2012-05-31 to 2012-05-31. Participants: Erik Faye-Lund, Junio C Hamano.
Thread: https://gitlist.dev/t/30671

## Erik Faye-Lund, 2012-05-31 14:10

Subject: [PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency
Message-ID: <1338473444-8960-1-git-send-email-kusmabite@gmail.com>
URL: https://gitlist.dev/e/1338473444-8960-1-git-send-email-kusmabite%40gmail.com

```
In 20fc9bc (Set HTTP user agent to git/GIT_VERSION, 2006-04-04),
http.o started recording GIT_VERSION, but http.o wasn't added
to the list of files that depends on GIT-VERSION-FILE.

Fix this, so mofications to GIT-VERSION-FILE will result in an
updated user-agent string.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---

I stumbled over this while debugging something related. Perhaps this
fix is worth applying?

There's a similar issue with generation of assembly-listings, but I
figured that was intended for inspection of the generated code; the
version string probably doesn't matter in such cases.

Dunno...

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index c09a679..59e2b25 100644
--- a/Makefile
+++ b/Makefile
@@ -2104,7 +2104,7 @@ configure: configure.ac
 	$(RM) $<+
 
 # These can record GIT_VERSION
-git.o git.spec \
+git.o git.spec http.o \
 	$(patsubst %.sh,%,$(SCRIPT_SH)) \
 	$(patsubst %.perl,%,$(SCRIPT_PERL)) \
 	: GIT-VERSION-FILE
-- 
1.7.11.rc0.6836.gdf573d9

```

## Junio C Hamano, 2012-05-31 19:42

Subject: Re: [PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency
Message-ID: <7vy5o85e98.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vy5o85e98.fsf%40alter.siamese.dyndns.org
In-Reply-To: <1338473444-8960-1-git-send-email-kusmabite@gmail.com>

```
Erik Faye-Lund <kusmabite@gmail.com> writes:

> In 20fc9bc (Set HTTP user agent to git/GIT_VERSION, 2006-04-04),
> http.o started recording GIT_VERSION, but http.o wasn't added
> to the list of files that depends on GIT-VERSION-FILE.
> ...
> diff --git a/Makefile b/Makefile
> index c09a679..59e2b25 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2104,7 +2104,7 @@ configure: configure.ac
>  	$(RM) $<+
>  
>  # These can record GIT_VERSION
> -git.o git.spec \
> +git.o git.spec http.o \
>  	$(patsubst %.sh,%,$(SCRIPT_SH)) \
>  	$(patsubst %.perl,%,$(SCRIPT_PERL)) \
>  	: GIT-VERSION-FILE

Makes sense to me.  Thanks.

```