threads / patch / 30551

patcharchive-tar: keep const in checksum calculation

Subject: [PATCH] archive-tar: keep const in checksum calculation

## tl;dr

One message between May 18, 2012 and May 18, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

René Scharfe· May 18, 2012, 05:18 UTC · lore
For correctness, don't needlessly drop the const qualifier when casting.
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 archive-tar.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to archive-tar.c +2 −2
diff --git a/archive-tar.c b/archive-tar.c
index 93387ea..dc91c6b 100644
--- a/archive-tar.c
+++ b/archive-tar.c
@@ -139,13 +139,13 @@ static void strbuf_append_ext_header(struct strbuf *sb, const char *keyword,
 
 static unsigned int ustar_header_chksum(const struct ustar_header *header)
 {
-	char *p = (char *)header;
+	const char *p = (const char *)header;
 	unsigned int chksum = 0;
 	while (p < header->chksum)
 		chksum += *p++;
 	chksum += sizeof(header->chksum) * ' ';
 	p += sizeof(header->chksum);
-	while (p < (char *)header + sizeof(struct ustar_header))
+	while (p < (const char *)header + sizeof(struct ustar_header))
 		chksum += *p++;
 	return chksum;
 }
-- 
1.7.10.2

← back to recent threads