# Are author names ending with a dot invalid?

2 messages from 2012-05-18 to 2012-05-19. Participants: Felipe Contreras, Jeff King.
Thread: https://gitlist.dev/t/30549

## Felipe Contreras, 2012-05-18 00:14

Subject: Are author names ending with a dot invalid?
Message-ID: <CAMP44s2OoxUVFE57e8C2Km7rcGn88KkLXxdaA3s5RE6nZ7TU=A@mail.gmail.com>
URL: https://gitlist.dev/e/CAMP44s2OoxUVFE57e8C2Km7rcGn88KkLXxdaA3s5RE6nZ7TU%3DA%40mail.gmail.com

```
Hi,

It looks like authors ending with a dot ('Foo Jr. <foo@bar.com>') are
converted without a dot ('Foo Jr <foo@bar.com>') is that intentional?

Cheers.

-- 
Felipe Contreras

```

## Jeff King, 2012-05-19 00:23

Subject: Re: Are author names ending with a dot invalid?
Message-ID: <20120519002335.GD765@sigill.intra.peff.net>
URL: https://gitlist.dev/e/20120519002335.GD765%40sigill.intra.peff.net
In-Reply-To: <CAMP44s2OoxUVFE57e8C2Km7rcGn88KkLXxdaA3s5RE6nZ7TU=A@mail.gmail.com>

```
On Fri, May 18, 2012 at 02:14:57AM +0200, Felipe Contreras wrote:

> It looks like authors ending with a dot ('Foo Jr. <foo@bar.com>') are
> converted without a dot ('Foo Jr <foo@bar.com>') is that intentional?

I was just digging in this code today, and I noticed the same thing. The
culprit is ident.c:copy, which strips magic characters from the
beginning, end, and middle. Except that the set of magic characters is
different at the edges (see ident.c:crud), and in the middle ("<", ">",
"\n").

This dates all the way back to 6aa33f4 (Abstract out the "name <email>
date" handling of commit-tree.c, 2005-07-12), which in turn was adapting
code from earlier (though it also has the issue).

So I think it's intentional, but I also think it's wrong, and it's
simply that nobody has complained about it, because it's not that
common.

-Peff

```