# [PATCH] diff --no-index: don't leak buffers in queue_diff 1 messages from 2012-05-16 to 2012-05-16. Participants: Bobby Powers. Thread: https://gitlist.dev/t/30537 ## Bobby Powers, 2012-05-16 14:50 Subject: [PATCH] diff --no-index: don't leak buffers in queue_diff Message-ID: <1337179831-23461-1-git-send-email-bobbypowers@gmail.com> URL: https://gitlist.dev/e/1337179831-23461-1-git-send-email-bobbypowers%40gmail.com ``` queue_diff uses two strbufs, and at the end of the function strbuf_reset was called. This only reset the length of the buffer - any allocated memory was leaked. Using strbuf_release fixes this. Signed-off-by: Bobby Powers --- diff-no-index.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/diff-no-index.c b/diff-no-index.c index 3080b66..f0b0010 100644 --- a/diff-no-index.c +++ b/diff-no-index.c @@ -123,8 +123,8 @@ static int queue_diff(struct diff_options *o, } string_list_clear(&p1, 0); string_list_clear(&p2, 0); - strbuf_reset(&buffer1); - strbuf_reset(&buffer2); + strbuf_release(&buffer1); + strbuf_release(&buffer2); return ret; } else { -- 1.7.10.2.521.g8ddb639 ```