threads / discuss / 30453

A small change to the gitweb documentation

Subject: A small change to the gitweb documentation

## tl;dr

One message between May 6, 2012 and May 6, 2012.

replies: 0people: 1as markdown or json

Roy Liu· May 6, 2012, 23:59 UTC · lore
Hi,

When reading the Apache server mod_rewrite documentation, I noticed that it had this to say about the "PT" (passthrough) option:

The PT flag implies the L flag: rewriting will be stopped in order to pass the request to the next phase of processing.

Current, the gitweb documentation has a mod_rewrite example that uses the option "[L,PT]". Since the "L" is probably redundant, I propose the following patch:

Regards, Roy

diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt
index 168e8bf..eb16bbd 100644
--- a/Documentation/gitweb.txt
+++ b/Documentation/gitweb.txt
@@ -633,7 +633,7 @@ complementary static files (stylesheet, favicon,
JavaScript):
        RewriteEngine On
        RewriteCond %{REQUEST_FILENAME} !-f
        RewriteCond %{REQUEST_FILENAME} !-d
-       RewriteRule ^.* /gitweb.cgi/$0 [L,PT]
+       RewriteRule ^.* /gitweb.cgi/$0 [PT]
    </Directory>
 </VirtualHost>
 ----------------------------------------------------------------------------
@@ -664,7 +664,7 @@ named *without* a .git extension (e.g.
'/pub/git/project' instead of
        RewriteEngine On
        RewriteCond %{REQUEST_FILENAME} !-f
        RewriteCond %{REQUEST_FILENAME} !-d
-       RewriteRule ^.* /gitweb.cgi/$0 [L,PT]
+       RewriteRule ^.* /gitweb.cgi/$0 [PT]
    </Directory>
 </VirtualHost>
 ----------------------------------------------------------------------------

← back to recent threads