# git-p4: planned view wildcard support 4 messages from 2012-05-06 to 2012-05-07. Participants: Matthew Mendell, Pete Wyckoff. Thread: https://gitlist.dev/t/30452 ## Matthew Mendell, 2012-05-06 23:46 Subject: git-p4: planned view wildcard support Message-ID: URL: https://gitlist.dev/e/CAF0RQx-0M4iUHgGdH%3DRE_UFmLLZH8uy4kkMW%3DXspNzGm-vsyEg%40mail.gmail.com ``` Hello, Is there any plan for the git-p4.py script to support the "*" wildcard in a p4 client? The specific test that exposes this unsupported feature: ./t9809-git-p4-client-view.sh ... ok 4 - unsupported view wildcard * Thanks, -Matt ``` ## Pete Wyckoff, 2012-05-07 10:44 Subject: Re: git-p4: planned view wildcard support Message-ID: <20120507104443.GA20372@padd.com> URL: https://gitlist.dev/e/20120507104443.GA20372%40padd.com In-Reply-To: ``` matthew.mendell@gmail.com wrote on Sun, 06 May 2012 16:46 -0700: > Is there any plan for the git-p4.py script to support the "*" wildcard > in a p4 client? > > The specific test that exposes this unsupported feature: > ./t9809-git-p4-client-view.sh > ... > ok 4 - unsupported view wildcard * It hasn't been on anybody's priority list so far that I know, but this would be not too hard to implement in theory. The code changes would need to alter just one class. In View.Path, functions Path.find_wildcards, match_wildcards and fill_in_wildcards, if you're interested in giving it a try. Can you constrain your use of "*" a bit? What makes these wildcards difficult is all the edge cases. For instance, is there ever more than one "*"? Is it combined with "..."? Are there multiple lines in the client spec with wildcards? Some abstracted examples would be interesting. -- Pete ``` ## Matthew Mendell, 2012-05-07 15:19 Subject: Re: git-p4: planned view wildcard support Message-ID: URL: https://gitlist.dev/e/CAF0RQx_0EYGiTd36WMtjeBwJL1cxsGTe44%3DP%2BbtEfWn%2B5Hq5yg%40mail.gmail.com In-Reply-To: <20120507104443.GA20372@padd.com> ``` On Mon, May 7, 2012 at 3:44 AM, Pete Wyckoff wrote: > matthew.mendell@gmail.com wrote on Sun, 06 May 2012 16:46 -0700: >> Is there any plan for the git-p4.py script to support the "*" wildcard >> in a p4 client? >> >> The specific test that exposes this unsupported feature: >> ./t9809-git-p4-client-view.sh >> ... >> ok 4 - unsupported view wildcard * > > It hasn't been on anybody's priority list so far that I know, but > this would be not too hard to implement in theory. > > The code changes would need to alter just one class.  In > View.Path, functions Path.find_wildcards, match_wildcards and > fill_in_wildcards, if you're interested in giving it a try. > > Can you constrain your use of "*" a bit?  What makes these > wildcards difficult is all the edge cases.  For instance, is > there ever more than one "*"?  Is it combined with "..."?  Are > there multiple lines in the client spec with wildcards?  Some > abstracted examples would be interesting. > >                -- Pete Hi Pete, Yeah, I have been perusing the code and would like to give it a shot. Is it ok to initially add partial support for the easy cases? My usage of "*" is straight forward: //depot/project/* //my_clientspec/depot/project/* Thanks, -Matt ``` ## Pete Wyckoff, 2012-05-07 15:28 Subject: Re: git-p4: planned view wildcard support Message-ID: <20120507152833.GA30191@padd.com> URL: https://gitlist.dev/e/20120507152833.GA30191%40padd.com In-Reply-To: ``` matthew.mendell@gmail.com wrote on Mon, 07 May 2012 08:19 -0700: > On Mon, May 7, 2012 at 3:44 AM, Pete Wyckoff wrote: > > matthew.mendell@gmail.com wrote on Sun, 06 May 2012 16:46 -0700: > >> Is there any plan for the git-p4.py script to support the "*" wildcard > >> in a p4 client? > >> > >> The specific test that exposes this unsupported feature: > >> ./t9809-git-p4-client-view.sh > >> ... > >> ok 4 - unsupported view wildcard * > > > > It hasn't been on anybody's priority list so far that I know, but > > this would be not too hard to implement in theory. > > > > The code changes would need to alter just one class.  In > > View.Path, functions Path.find_wildcards, match_wildcards and > > fill_in_wildcards, if you're interested in giving it a try. > > > > Can you constrain your use of "*" a bit?  What makes these > > wildcards difficult is all the edge cases.  For instance, is > > there ever more than one "*"?  Is it combined with "..."?  Are > > there multiple lines in the client spec with wildcards?  Some > > abstracted examples would be interesting. > > Yeah, I have been perusing the code and would like to give it a shot. > Is it ok to initially add partial support for the easy cases? > My usage of "*" is straight forward: > > //depot/project/* //my_clientspec/depot/project/* That one does seem like it wouldn't be too hard. Similar to trailing "...", but matching only one path component. As long as git-p4 can reliably detect when it can deal with a *, I think partial support would be just fine. I'll help think about test cases and such once you have some code that's ready to look at. Thanks! -- Pete ```