# [PATCH 4/6] http: handle proxy authentication failure (error 407) 2 messages from 2012-05-03 to 2012-05-04. Participants: Nelson Benitez Leon, Jeff King. Thread: https://gitlist.dev/t/30410 ## Nelson Benitez Leon, 2012-05-03 16:40 Subject: [PATCH 4/6] http: handle proxy authentication failure (error 407) Message-ID: <4FA2B4EE.6010008@seap.minhap.es> URL: https://gitlist.dev/e/4FA2B4EE.6010008%40seap.minhap.es ``` Handle http 407 error code by asking for credentials and retrying request in case credentials were not present, or marking credentials as rejected if they were already provided. Signed-off-by: Nelson Benitez Leon Signed-off-by: Junio C Hamano --- http.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/http.c b/http.c index 22ffe0c..c87c66c 100644 --- a/http.c +++ b/http.c @@ -879,6 +879,15 @@ static int http_request(const char *url, void *result, int target, int options) init_curl_http_auth(slot->curl); ret = HTTP_REAUTH; } + } else if (results.http_code == 407) { /* Proxy authentication failure */ + if (proxy_auth.username && proxy_auth.password) { + credential_reject(&proxy_auth); + ret = HTTP_NOAUTH; + } else { + credential_fill(&proxy_auth); + set_proxy_auth(slot->curl); + ret = HTTP_REAUTH; + } } else { if (!curl_errorstr[0]) strlcpy(curl_errorstr, -- 1.7.7.6 ``` ## Jeff King, 2012-05-04 07:23 Subject: Re: [PATCH 4/6] http: handle proxy authentication failure (error 407) Message-ID: <20120504072329.GD21895@sigill.intra.peff.net> URL: https://gitlist.dev/e/20120504072329.GD21895%40sigill.intra.peff.net In-Reply-To: <4FA2B4EE.6010008@seap.minhap.es> ``` On Thu, May 03, 2012 at 06:40:14PM +0200, Nelson Benitez Leon wrote: > Handle http 407 error code by asking for credentials and > retrying request in case credentials were not present, or > marking credentials as rejected if they were already provided. This one looks good to me. -Peff ```