# [PATCH] git p4: fix unit tests 3 messages from 2012-04-25 to 2012-04-25. Participants: Luke Diamand, Junio C Hamano. Thread: https://gitlist.dev/t/30332 ## Luke Diamand, 2012-04-25 08:16 Subject: [PATCHv1] git p4: fix for submit/edit unit test Message-ID: <1335341814-1598-1-git-send-email-luke@diamand.org> URL: https://gitlist.dev/e/1335341814-1598-1-git-send-email-luke%40diamand.org ``` My P4EDITOR changes broke the submit/edit "git p4" unit test. This fixes it. Junio - would you prefer me to resubmit the entire series? Thanks Luke Luke Diamand (1): git p4: fix unit tests t/t9805-git-p4-skip-submit-edit.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.7.10.473.g0796 ``` ## Luke Diamand, 2012-04-25 08:16 Subject: [PATCH] git p4: fix unit tests Message-ID: <1335341814-1598-2-git-send-email-luke@diamand.org> URL: https://gitlist.dev/e/1335341814-1598-2-git-send-email-luke%40diamand.org In-Reply-To: <1335341814-1598-1-git-send-email-luke@diamand.org> ``` The submit-edit tests relied on P4EDITOR being unset. Set it explicitly to an empty string. Signed-off-by: Luke Diamand --- t/t9805-git-p4-skip-submit-edit.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t9805-git-p4-skip-submit-edit.sh b/t/t9805-git-p4-skip-submit-edit.sh index 4a72f79..353dcfb 100755 --- a/t/t9805-git-p4-skip-submit-edit.sh +++ b/t/t9805-git-p4-skip-submit-edit.sh @@ -91,7 +91,7 @@ test_expect_success 'no config, edited' ' cd "$git" && echo line >>file1 && git commit -a -m "change 5" && - EDITOR="\"$ed\"" git p4 submit && + P4EDITOR="" EDITOR="\"$ed\"" git p4 submit && p4 changes //depot/... >wc && test_line_count = 5 wc ) -- 1.7.10.473.g0796 ``` ## Junio C Hamano, 2012-04-25 15:18 Subject: Re: [PATCHv1] git p4: fix for submit/edit unit test Message-ID: URL: https://gitlist.dev/e/xmqq4ns7et5p.fsf%40junio.mtv.corp.google.com In-Reply-To: <1335341814-1598-1-git-send-email-luke@diamand.org> ``` Luke Diamand writes: > My P4EDITOR changes broke the submit/edit "git p4" unit test. > This fixes it. > > Junio - would you prefer me to resubmit the entire series? It is too late for replacement, as the series is in 'next'. Incremental updates like you did is good. Thanks. ```