threads / patch / 30326

patchgitweb: Don't set owner if got empty value from projects.list

Subject: [PATCH] gitweb: Don't set owner if got empty value from projects.list

## tl;dr

One message between Apr 24, 2012 and Apr 24, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Kacper Kornet· Apr 24, 2012, 17:50 UTC · lore

Prevent setting owner to an empty value if it is not specified in projects.list file. Otherwise it stops retrieving information about the owner from other files.

Signed-off-by: Kacper Kornet <draenog@pld-linux.org>
---
The change is necessary due to 14b289bdf7c31176dc525cbe81173ec636598782:
"gitweb: Refactor checking if part of project info need filling", which
replaced !defined with !exists in check if owner is set.  
 gitweb/gitweb.perl |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Show changes to gitweb/gitweb.perl +4 −2
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 3aeeb8b..adb0caa 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2906,9 +2906,11 @@ sub git_get_projects_list {
 			}
 			if (check_export_ok("$projectroot/$path")) {
 				my $pr = {
-					path => $path,
-					owner => to_utf8($owner),
+					path => $path
 				};
+				if ($owner) {
+					$pr->{'owner'} = to_utf8($owner);
+				}
 				push @list, $pr;
 			}
 		}
-- 
1.7.10

-- 
  Kacper Kornet

← back to recent threads