# [PATCH] revert: add missing va_end 2 messages from 2012-04-21 to 2012-04-22. Participants: Christian Couder, Junio C Hamano. Thread: https://gitlist.dev/t/30303 ## Christian Couder, 2012-04-21 21:15 Subject: [PATCH] revert: add missing va_end Message-ID: <20120421211520.2797.87418.chriscool@tuxfamily.org> URL: https://gitlist.dev/e/20120421211520.2797.87418.chriscool%40tuxfamily.org ``` Signed-off-by: Christian Couder --- builtin/revert.c | 1 + 1 file changed, 1 insertion(+) diff --git a/builtin/revert.c b/builtin/revert.c index e6840f2..e4ed023 100644 --- a/builtin/revert.c +++ b/builtin/revert.c @@ -86,6 +86,7 @@ static void verify_opt_mutually_compatible(const char *me, ...) break; } } + va_end(ap); if (opt1 && opt2) die(_("%s: %s cannot be used with %s"), me, opt1, opt2); -- 1.7.10.rc0.17.g74595 ``` ## Junio C Hamano, 2012-04-22 05:20 Subject: Re: [PATCH] revert: add missing va_end Message-ID: URL: https://gitlist.dev/e/xmqqd370mjgd.fsf%40junio.mtv.corp.google.com In-Reply-To: <20120421211520.2797.87418.chriscool@tuxfamily.org> ``` Christian Couder writes: > Signed-off-by: Christian Couder > --- > builtin/revert.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/builtin/revert.c b/builtin/revert.c > index e6840f2..e4ed023 100644 > --- a/builtin/revert.c > +++ b/builtin/revert.c > @@ -86,6 +86,7 @@ static void verify_opt_mutually_compatible(const char *me, ...) > break; > } > } > + va_end(ap); Yeah, the original from v1.7.8-rc0~141^2~2 is obviously wrong. Thanks. ```