threads / patch / 30176

patchgitk: avoid Meta1-F5

Subject: [PATCH] gitk: avoid Meta1-F5

## tl;dr

6 messages between Apr 7, 2012 and Jun 13, 2012. Diffs are folded; open one to read it.

replies: 5people: 3as markdown or json

Felipe Contreras· Apr 7, 2012, 00:29 UTC · lore

This is commonly mapped by window managers and what not. Use Shift-F5 instead.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 gitk-git/gitk |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Show changes to gitk-git/gitk +2 −2

diff --git a/gitk-git/gitk b/gitk-git/gitk
index 22270ce..9bba9aa 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2038,7 +2038,7 @@ proc makewindow {} {
     set file {
 	mc "File" cascade {
 	    {mc "Update" command updatecommits -accelerator F5}
-	    {mc "Reload" command reloadcommits -accelerator Meta1-F5}
+	    {mc "Reload" command reloadcommits -accelerator Shift-F5}
 	    {mc "Reread references" command rereadrefs}
 	    {mc "List references" command showrefs -accelerator F2}
 	    {xx "" separator}
@@ -2495,7 +2495,7 @@ proc makewindow {} {
     bindkey ? {dofind -1 1}
     bindkey f nextfile
     bind . <F5> updatecommits
-    bind . <$M1B-F5> reloadcommits
+    bind . <Shift-F5> reloadcommits
     bind . <F2> showrefs
     bind . <Shift-F4> {newview 0}
     catch { bind . <Shift-Key-XF86_Switch_VT_4> {newview 0} }

-- 
1.7.10

Felipe Contreras· Apr 24, 2012, 01:41 UTC · re: Felipe Contreras · lore

Re: [PATCH] gitk: avoid Meta1-F5

Helloo?

On Sat, Apr 7, 2012 at 3:29 AM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 33 quoted lines

> This is commonly mapped by window managers and what not. Use Shift-F5
> instead.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  gitk-git/gitk |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 22270ce..9bba9aa 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -2038,7 +2038,7 @@ proc makewindow {} {
>     set file {
>        mc "File" cascade {
>            {mc "Update" command updatecommits -accelerator F5}
> -           {mc "Reload" command reloadcommits -accelerator Meta1-F5}
> +           {mc "Reload" command reloadcommits -accelerator Shift-F5}
>            {mc "Reread references" command rereadrefs}
>            {mc "List references" command showrefs -accelerator F2}
>            {xx "" separator}
> @@ -2495,7 +2495,7 @@ proc makewindow {} {
>     bindkey ? {dofind -1 1}
>     bindkey f nextfile
>     bind . <F5> updatecommits
> -    bind . <$M1B-F5> reloadcommits
> +    bind . <Shift-F5> reloadcommits
>     bind . <F2> showrefs
>     bind . <Shift-F4> {newview 0}
>     catch { bind . <Shift-Key-XF86_Switch_VT_4> {newview 0} }
> --
> 1.7.10
>

-- 
Felipe Contreras

Paul Mackerras· Apr 25, 2012, 03:45 UTC · re: Felipe Contreras · lore

Re: [PATCH] gitk: avoid Meta1-F5

On Sat, Apr 07, 2012 at 03:29:38AM +0300, Felipe Contreras wrote:

> This is commonly mapped by window managers and what not. Use Shift-F5
> instead.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

Thanks, applied.

Paul.

Felipe Contreras· Jun 13, 2012, 15:00 UTC · re: Paul Mackerras · lore

Re: [PATCH] gitk: avoid Meta1-F5

On Wed, Apr 25, 2012 at 5:45 AM, Paul Mackerras <paulus@samba.org> wrote:

Show 7 quoted lines

> On Sat, Apr 07, 2012 at 03:29:38AM +0300, Felipe Contreras wrote:
>> This is commonly mapped by window managers and what not. Use Shift-F5
>> instead.
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>
> Thanks, applied.

Does this translate into some action? I still don't see this change in Junio's tree.

Cheers.

-- 
Felipe Contreras

Zbigniew Jędrzejewski-Szmek· Jun 13, 2012, 22:01 UTC · re: Felipe Contreras · lore

Re: [PATCH] gitk: avoid Meta1-F5

On 06/13/2012 05:00 PM, Felipe Contreras wrote:

Show 11 quoted lines

> On Wed, Apr 25, 2012 at 5:45 AM, Paul Mackerras <paulus@samba.org> wrote:
>> On Sat, Apr 07, 2012 at 03:29:38AM +0300, Felipe Contreras wrote:
>>> This is commonly mapped by window managers and what not. Use Shift-F5
>>> instead.
>>>
>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>
>> Thanks, applied.
> 
> Does this translate into some action? I still don't see this change in
> Junio's tree.

It's in git://ozlabs.org/~paulus/gitk, the place where gitk lives.

Zbyszek

Felipe Contreras· Jun 13, 2012, 22:36 UTC · re: Zbigniew Jędrzejewski-Szmek · lore

Re: [PATCH] gitk: avoid Meta1-F5

On Thu, Jun 14, 2012 at 12:01 AM, Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> wrote:

Show 13 quoted lines

> On 06/13/2012 05:00 PM, Felipe Contreras wrote:
>> On Wed, Apr 25, 2012 at 5:45 AM, Paul Mackerras <paulus@samba.org> wrote:
>>> On Sat, Apr 07, 2012 at 03:29:38AM +0300, Felipe Contreras wrote:
>>>> This is commonly mapped by window managers and what not. Use Shift-F5
>>>> instead.
>>>>
>>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>>
>>> Thanks, applied.
>>
>> Does this translate into some action? I still don't see this change in
>> Junio's tree.
> It's in git://ozlabs.org/~paulus/gitk, the place where gitk lives.

So what is this? http://git.kernel.org/?p=git/git.git;a=blob;f=gitk-git/gitk

-- 
Felipe Contreras