threads / patch / 30162

patchcompletion: use more proper emulation for zsh

Subject: [PATCH] completion: use more proper emulation for zsh

## tl;dr

One message between Apr 6, 2012 and Apr 6, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Felipe Contreras· Apr 6, 2012, 12:19 UTC · lore

It turns out there's no 'bash' emulation in zsh. Anything that starts with a 'b' is mapped to the 'sh' emulation, presumably because of _b_ourne shell.

kzh emulation seems closer to bash, and at least I haven't had problems with this.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Show changes to contrib/completion/git-completion.bash +2 −4
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 31f714d..e75925f 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2604,8 +2604,7 @@ _git ()
 	local i c=1 command __git_dir
 
 	if [[ -n ${ZSH_VERSION-} ]]; then
-		emulate -L bash
-		setopt KSH_TYPESET
+		emulate -L ksh
 
 		# workaround zsh's bug that leaves 'words' as a special
 		# variable in versions < 4.3.12
@@ -2664,8 +2663,7 @@ _git ()
 _gitk ()
 {
 	if [[ -n ${ZSH_VERSION-} ]]; then
-		emulate -L bash
-		setopt KSH_TYPESET
+		emulate -L ksh
 
 		# workaround zsh's bug that leaves 'words' as a special
 		# variable in versions < 4.3.12
-- 
1.7.9.6

← back to recent threads