# [PATCH] config: remove useless assignment 2 messages from 2012-03-28 to 2012-03-28. Participants: René Scharfe, Jeff King. Thread: https://gitlist.dev/t/30088 ## René Scharfe, 2012-03-28 20:18 Subject: [PATCH] config: remove useless assignment Message-ID: <4F73721D.4010808@lsrfire.ath.cx> URL: https://gitlist.dev/e/4F73721D.4010808%40lsrfire.ath.cx ``` v1.7.9-8-g270a344 (config: stop using config_exclusive_filename) replaced config_exclusive_filename with given_config_file. In one case this resulted in a self-assignment, which is reported by clang as a warning. Remove the useless code. Signed-off-by: Rene Scharfe --- builtin/config.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/builtin/config.c b/builtin/config.c index d41a9bf..33c8820 100644 --- a/builtin/config.c +++ b/builtin/config.c @@ -397,8 +397,6 @@ int cmd_config(int argc, const char **argv, const char *prefix) xstrdup(prefix_filename(prefix, strlen(prefix), given_config_file)); - else - given_config_file = given_config_file; } if (respect_includes == -1) -- 1.7.9.2 ``` ## Jeff King, 2012-03-28 20:22 Subject: Re: [PATCH] config: remove useless assignment Message-ID: <20120328202233.GB29315@sigill.intra.peff.net> URL: https://gitlist.dev/e/20120328202233.GB29315%40sigill.intra.peff.net In-Reply-To: <4F73721D.4010808@lsrfire.ath.cx> ``` On Wed, Mar 28, 2012 at 10:18:37PM +0200, René Scharfe wrote: > v1.7.9-8-g270a344 (config: stop using config_exclusive_filename) replaced > config_exclusive_filename with given_config_file. In one case this > resulted in a self-assignment, which is reported by clang as a warning. > Remove the useless code. > > Signed-off-by: Rene Scharfe > --- > builtin/config.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/builtin/config.c b/builtin/config.c > index d41a9bf..33c8820 100644 > --- a/builtin/config.c > +++ b/builtin/config.c > @@ -397,8 +397,6 @@ int cmd_config(int argc, const char **argv, const char *prefix) > xstrdup(prefix_filename(prefix, > strlen(prefix), > given_config_file)); > - else > - given_config_file = given_config_file; > } Thanks. I remember refactoring that part of the conditional several times while figuring out the right ordering of my refactoring patches, but obviously I missed removing the stale code on the final pass-through. Acked-by: Jeff King -Peff ```