# [PATCH] gitweb(1): Fixed improper use of "it's" when it should be "its" 7 messages from 2012-03-23 to 2012-03-23. Participants: David Waitzman, Ben Walton, D Waitzman, Thomas Rast, Junio C Hamano. Thread: https://gitlist.dev/t/30034 ## David Waitzman, 2012-03-23 13:13 Subject: [PATCH] gitweb(1): Fixed improper use of "it's" when it should be "its" Message-ID: <0316A9BA-627B-4B43-8BF1-392DD7408146@bbn.com> URL: https://gitlist.dev/e/0316A9BA-627B-4B43-8BF1-392DD7408146%40bbn.com ``` This is a trivial patch to correct the english in the man page. Signed-off-by: David Waitzman --- Documentation/gitweb.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt index 605a085..065c54e 100644 --- a/Documentation/gitweb.txt +++ b/Documentation/gitweb.txt @@ -14,7 +14,7 @@ gitweb. DESCRIPTION ----------- -Gitweb provides a web interface to git repositories. It's features include: +Gitweb provides a web interface to git repositories. Its features include: * Viewing multiple Git repositories with common root. * Browsing every revision of the repository. @@ -60,7 +60,7 @@ to gitweb. The list of projects is generated by default by scanning the more exact; gitweb is not interested in a working area, and is best suited to showing "bare" repositories). -The name of repository in gitweb is path to it's `$GIT_DIR` (it's object +The name of repository in gitweb is path to its `$GIT_DIR` (its object database) relative to `$projectroot`. Therefore the repository $repo can be found at "$projectroot/$repo". -- 1.7.9.GIT ``` ## Ben Walton, 2012-03-23 13:27 Subject: Re: [PATCH] gitweb(1): Fixed improper use of "it's" when it should be "its" Message-ID: <1332509111-sup-2763@pinkfloyd.chass.utoronto.ca> URL: https://gitlist.dev/e/1332509111-sup-2763%40pinkfloyd.chass.utoronto.ca In-Reply-To: <0316A9BA-627B-4B43-8BF1-392DD7408146@bbn.com> ``` Excerpts from David Waitzman's message of Fri Mar 23 09:13:44 -0400 2012: Hi David, > This is a trivial patch to correct the english in the man page. Good catch! > -The name of repository in gitweb is path to it's `$GIT_DIR` (it's object > +The name of repository in gitweb is path to its `$GIT_DIR` (its object Might I suggest that this be: +The name of the repository in gitweb is the path to its `$GIT_DIR` (its object Note the inserted _the_'s. Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302 ``` ## David Waitzman, 2012-03-23 14:49 Subject: [PATCH] gitweb(1) Fixed English issues Message-ID: <53140318-34FA-4EF1-80F9-CFAD8828B3A1@bbn.com> URL: https://gitlist.dev/e/53140318-34FA-4EF1-80F9-CFAD8828B3A1%40bbn.com In-Reply-To: <1332509111-sup-2763@pinkfloyd.chass.utoronto.ca> ``` This is a trivial patch to correct the english in the man page. Ben Walton suggested an additional english fix which I have added and squashed with my change. ----- Fixed improper use of "it's" when it should be "its". Added missing "the"; noted by Ben Walton bwalton@artsci.utoronto.ca Signed-off-by: David Waitzman --- Documentation/gitweb.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt index 605a085..59bdc3e 100644 --- a/Documentation/gitweb.txt +++ b/Documentation/gitweb.txt @@ -14,7 +14,7 @@ gitweb. DESCRIPTION ----------- -Gitweb provides a web interface to git repositories. It's features include: +Gitweb provides a web interface to git repositories. Its features include: * Viewing multiple Git repositories with common root. * Browsing every revision of the repository. @@ -60,7 +60,7 @@ to gitweb. The list of projects is generated by default by scanning the more exact; gitweb is not interested in a working area, and is best suited to showing "bare" repositories). -The name of repository in gitweb is path to it's `$GIT_DIR` (it's object +The name of repository in gitweb is the path to its `$GIT_DIR` (its object database) relative to `$projectroot`. Therefore the repository $repo can be found at "$projectroot/$repo". -- 1.7.9.GIT ``` ## Ben Walton, 2012-03-23 14:52 Subject: Re: [PATCH] gitweb(1) Fixed English issues Message-ID: <1332514314-sup-412@pinkfloyd.chass.utoronto.ca> URL: https://gitlist.dev/e/1332514314-sup-412%40pinkfloyd.chass.utoronto.ca In-Reply-To: <53140318-34FA-4EF1-80F9-CFAD8828B3A1@bbn.com> ``` Excerpts from David Waitzman's message of Fri Mar 23 10:49:55 -0400 2012: Hi David, > +The name of repository in gitweb is the path to its `$GIT_DIR` (its object > database) relative to `$projectroot`. Therefore the repository $repo can be > found at "$projectroot/$repo". Two _the_'s were missing in the original. This should read: The name of _the_ repository in gitweb is _the_ path to its... Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302 ``` ## D Waitzman, 2012-03-23 15:02 Subject: [PATCH] gitweb(1) Fixed English issues Message-ID: <08B31D69-CE1F-4D27-8AE6-C1C0D76BEED5@spamcop.net> URL: https://gitlist.dev/e/08B31D69-CE1F-4D27-8AE6-C1C0D76BEED5%40spamcop.net In-Reply-To: <53140318-34FA-4EF1-80F9-CFAD8828B3A1@bbn.com> ``` This is a trivial patch to correct the english in the man page. Ben Walton suggested an additional english fix which I have added and squashed with my change. And then I added it again when he pointed out I missed something in his original email. -- Fixed improper use of "it's" when it should be "its". Added missing "the"; noted by Ben Walton bwalton@artsci.utoronto.ca Signed-off-by: David Waitzman --- Documentation/gitweb.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt index 605a085..168e8bf 100644 --- a/Documentation/gitweb.txt +++ b/Documentation/gitweb.txt @@ -14,7 +14,7 @@ gitweb. DESCRIPTION ----------- -Gitweb provides a web interface to git repositories. It's features include: +Gitweb provides a web interface to git repositories. Its features include: * Viewing multiple Git repositories with common root. * Browsing every revision of the repository. @@ -60,7 +60,7 @@ to gitweb. The list of projects is generated by default by scanning the more exact; gitweb is not interested in a working area, and is best suited to showing "bare" repositories). -The name of repository in gitweb is path to it's `$GIT_DIR` (it's object +The name of the repository in gitweb is the path to its `$GIT_DIR` (its object database) relative to `$projectroot`. Therefore the repository $repo can be found at "$projectroot/$repo". -- 1.7.9.GIT ``` ## Thomas Rast, 2012-03-23 15:46 Subject: Re: [PATCH] gitweb(1) Fixed English issues Message-ID: <878vircoby.fsf@thomas.inf.ethz.ch> URL: https://gitlist.dev/e/878vircoby.fsf%40thomas.inf.ethz.ch In-Reply-To: <08B31D69-CE1F-4D27-8AE6-C1C0D76BEED5@spamcop.net> ``` D Waitzman writes: > This is a trivial patch to correct the english in the man page. Ben Walton suggested an additional english fix which I have added and squashed with my change. And then I added it again when he pointed out I missed something in his original email. > > -- > > Fixed improper use of "it's" when it should be "its". > Added missing "the"; noted by Ben Walton bwalton@artsci.utoronto.ca > > Signed-off-by: David Waitzman > --- > Documentation/gitweb.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt > index 605a085..168e8bf 100644 [snip patch] Note that the correct way to put commentary in the patch mail that does not go into the commit message is putting it after the --- marker. Also, we write commit messages in the imperative. The above should probably look roughly like Subject: Documentation/gitweb: trivial English fixes Change "it's" to "its" where a possessive is intended. Also add two missing "the" that were noticed by Ben Walton . Signed-off-by: David Waitzman --- This is a trivial patch to correct the english in the man page. Ben Walton suggested an additional english fix which I have added and squashed with my change. And then I added it again when he pointed out I missed something in his original email. Documentation/gitweb.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt index 605a085..168e8bf 100644 Note that I added "Subject:" here to make it an inline patch (though you obviously need to remove my extra formatting indent). If there's no Subject pseudoheader, the patch gets the subject of your email, and similarly for From and author. -- Thomas Rast trast@{inf,student}.ethz.ch ``` ## Junio C Hamano, 2012-03-23 18:19 Subject: Re: [PATCH] gitweb(1) Fixed English issues Message-ID: <7vpqc3tc1n.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vpqc3tc1n.fsf%40alter.siamese.dyndns.org In-Reply-To: <878vircoby.fsf@thomas.inf.ethz.ch> ``` Thomas Rast writes: > Note that the correct way to put commentary in the patch mail that does > not go into the commit message is putting it after the --- marker. > Also, we write commit messages in the imperative. The above should > probably look roughly like > > Subject: Documentation/gitweb: trivial English fixes > > Change "it's" to "its" where a possessive is intended. > > Also add two missing "the" that were noticed by Ben Walton > . > > Signed-off-by: David Waitzman > --- > This is a trivial patch to correct the english in the man page. Ben > Walton suggested an additional english fix which I have added and > squashed with my change. And then I added it again when he pointed > out I missed something in his original email. > > Documentation/gitweb.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt > index 605a085..168e8bf 100644 > > Note that I added "Subject:" here to make it an inline patch (though you > obviously need to remove my extra formatting indent). If there's no > Subject pseudoheader, the patch gets the subject of your email, and > similarly for From and author. Thanks. I'll use this with the patch text you are responding to. ```