threads / patch / 29936

v5, 5 partshttp: handle proxy authentication failure (error 407)

Subject: [PATCH v5 3/5] http: handle proxy authentication failure (error 407)

## tl;dr

One message between Mar 13, 2012 and Mar 13, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Nelson Benitez Leon· Mar 13, 2012, 14:04 UTC · lore

Handle http 407 error code by asking for credentials and retrying request in case credentials were not present, or marking credentials as rejected if they were already provided.

Signed-off-by: Nelson Benitez Leon <nbenitezl@gmail.com>
---
 http.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
Show changes to http.c +9 −0
diff --git a/http.c b/http.c
index e7410f8..d3d9d24 100644
--- a/http.c
+++ b/http.c
@@ -839,6 +839,15 @@ static int http_request(const char *url, void *result, int target, int options)
 				init_curl_http_auth(slot->curl);
 				ret = HTTP_REAUTH;
 			}
+		} else if (results.http_code == 407) { /* Proxy authentication failure */
+			if (proxy_auth.username && proxy_auth.password) {
+				credential_reject(&proxy_auth);
+				ret = HTTP_NOAUTH;
+			} else {
+				credential_fill(&proxy_auth);
+				set_proxy_auth(slot->curl);
+				ret = HTTP_REAUTH;
+			}
 		} else {
 			if (!curl_errorstr[0])
 				strlcpy(curl_errorstr,
-- 
1.7.7.6

← back to recent threads