threads / patch / 29919

v4, 5 partsNew roll of proxy improvements

Subject: [PATCH v4 0/5] New roll of proxy improvements

## tl;dr

One message between Mar 12, 2012 and Mar 12, 2012. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Nelson Benitez Leon· Mar 12, 2012, 17:24 UTC · lore

So here is a new roll based on last comments, changes from last roll are:

- Unify in new function set_proxy_auth() the code for
setting proxy username and password in cURL options, which is
indepently setted and not as part of the CURLOPT_PROXY as before.
- If using libcurl >= 7.19.1 use options CURLOPT_PROXYUSERNAME
and CURLOPT_PROXYPASSWORD which let special characters like '@'
or ':' to be present in those options and be correctly treated
by libcurl. If libcurl is < 7.19.1 then use CURLOPT_PROXYUSERPWD
option.
- Refactor http_request_reauth() function to permit more than two
retries, this comes from a jeff king's patch.
- Rename HTTP_REAUTH return status to HTTP_RETRY to better fit the
new semantics according to the aforementioned refactor in
http_request_reauth().
Regards,
Nelson Benitez Leon (5):
  http: try http_proxy env var when http.proxy config option is not set
  http: handle proxy proactive authentication
  http: handle proxy authentication failure (error 407)
  http: Avoid limit of retrying request only twice
  http: rename HTTP_REAUTH to HTTP_RETRY
 http.c |   56 ++++++++++++++++++++++++++++++++++++++++++++++++++------
 http.h |    2 +-
 2 files changed, 51 insertions(+), 7 deletions(-)
-- 
1.7.7.6

← back to recent threads